Re: [PATCH] perf lzma: Quieten lzma warning

[Arnaldo Carvalho de Melo <acme@kernel.org>]

Em Tue, Oct 04, 2022 at 12:06:15PM -0700, Andi Kleen escreveu:
> On my Fedora system which is missing some modules I always get a long flood
> of
> 
> lzma: fopen failed on /usr/lib/modules/5.3.9-300.fc31.x86_64/kernel/sound/pci/hda/snd-hda-codec.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.16.7-200.fc35.x86_64/kernel/sound/pci/hda/snd-hda-intel.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.1.11-200.fc29.x86_64/kernel/drivers/vhost/vhost_net.ko.xz: 'No such file or directory'
> 
> for each use of "perf list".
> 
> Disable the message.
> 
> Also I'm not sure why it's looking at the modules of each kernel, not
> just the running one, but that's a different problem.

Yeah, I see this from time to time, would be interesting to find the
root cause for looking at te modules for each kernel :-\

I'll try to take a look if Jiri doesn't have any idea about this.

- Arnaldo
 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/perf/util/lzma.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/tools/perf/util/lzma.c b/tools/perf/util/lzma.c
> index 51424cdc3b68..ef0520c82245 100644
> --- a/tools/perf/util/lzma.c
> +++ b/tools/perf/util/lzma.c
> @@ -44,11 +44,8 @@ int lzma_decompress_to_file(const char *input, int output_fd)
>  	FILE *infile;
>  
>  	infile = fopen(input, "rb");
> -	if (!infile) {
> -		pr_err("lzma: fopen failed on %s: '%s'\n",
> -		       input, strerror(errno));
> +	if (!infile)
>  		return -1;
> -	}
>  
>  	ret = lzma_stream_decoder(&strm, UINT64_MAX, LZMA_CONCATENATED);
>  	if (ret != LZMA_OK) {
> -- 
> 2.37.2

-- 

- Arnaldo