Re: [PATCH 0/2] gpio: pca953x: Add interrupt mask support for pca953x chips

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Oct 17, 2022 at 12:02:16PM +0200, Linus Walleij wrote:
> On Mon, Oct 10, 2022 at 3:23 PM Levente Révész
> <levente.revesz@eilabs.com> wrote:
> 
> > Some chips in the pca953x family have an interrupt mask register in
> > addition to the standard 4 registers:
> >
> >     0: INPUT
> >     1: OUTPUT
> >     2: POLARITY
> >     3: CONFIGURATION
> >     4: INTERRUPT MASK
> >
> > Chips with this register:
> >
> >     - pca9505
> >     - pca9506
> >     - pca9698
> >
> > The interrupt mask register defaults to all interrupts disabled, so
> > interrupts are unusable unless the driver sets this register.
> >
> > Interrupt masking is already implemented for pcal chips. That
> > implementation could be extended to support this register as well.
> >
> > This patch series adds support for the interrupt mask register in
> > mentioned pca chips.
> 
> Added some PCA953x users to the To-line, lots of people use
> this driver so please review!

Thank you for Cc'ing me!

At first glance I think this needs two prerequisite patches:

1) convert _TYPE from bits to plain numbers, so we will have room
   for up to 16 types;

2) Introducing PCAL953X_TYPE.

After this is done, the current series will be neater.

-- 
With Best Regards,
Andy Shevchenko