From: "Daniel P. Berrangé" <berrange@redhat.com>
To: amarjargal <amarjargal16@gmail.com>
Cc: qemu-devel@nongnu.org, sgarzare@redhat.com
Subject: Re: [PATCH 1/4] ui: fix tab indentation
Date: Tue, 18 Oct 2022 10:38:00 +0100 [thread overview]
Message-ID: <Y05z+HGk8zyRmIGf@redhat.com> (raw)
In-Reply-To: <91d870b3c88c5c31bb8cfcabbf7ca28b34899aa4.1666029821.git.amarjargal16@gmail.com>
On Tue, Oct 18, 2022 at 02:23:56AM +0800, amarjargal wrote:
> The TABs should be replaced with spaces, to make sure that we have a
> consistent coding style with an indentation of 4 spaces everywhere.
>
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/370
> Signed-off-by: amarjargal <amarjargal16@gmail.com>
> ---
> ui/vgafont.h | 9214 +++++++++++++++++-----------------
> ui/vnc-enc-zywrle-template.c | 20 +-
> ui/vnc-enc-zywrle.h | 16 +-
> ui/vnc_keysym.h | 2 +-
> 4 files changed, 4626 insertions(+), 4626 deletions(-)
>
> diff --git a/ui/vnc_keysym.h b/ui/vnc_keysym.h
> index e8a2ec73c5..19d5ce7cf7 100644
> --- a/ui/vnc_keysym.h
> +++ b/ui/vnc_keysym.h
> @@ -102,7 +102,7 @@ static const name2keysym_t name2keysym[]={
> /* latin 1 extensions */
> { "nobreakspace", 0x0a0},
> { "exclamdown", 0x0a1},
> -{ "cent", 0x0a2},
> +{ "cent", 0x0a2},
The rest of the entries are vertically aligned. Can you fix this
to match.
> { "sterling", 0x0a3},
> { "currency", 0x0a4},
> { "yen", 0x0a5},
With that addressed, the whole patch would be
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-10-18 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 18:23 [PATCH 0/4] ui:hw: fix tab indentation amarjargal
2022-10-17 18:23 ` [PATCH 1/4] ui: " amarjargal
2022-10-18 9:38 ` Daniel P. Berrangé [this message]
2022-10-17 18:23 ` [PATCH 2/4] hw/audio: fix tab indentation into spaces amarjargal
2022-10-17 18:23 ` [PATCH 3/4] hw/display: fix tab indentation amarjargal
2022-10-17 18:23 ` [PATCH 4/4] hw/usb: " amarjargal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y05z+HGk8zyRmIGf@redhat.com \
--to=berrange@redhat.com \
--cc=amarjargal16@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.