From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88B9BC4332F for ; Tue, 18 Oct 2022 14:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EkC8+WGeUGTXQNYemkU8Rd4RKFIv9OhyCgHOQAl48fE=; b=TQ+QtOMPSZu+fJ Xj0X5LjDjSty4bamFU7g7nwOLnTnhncyc7a03oXL/vwZkPKqwe86twbgT413ty+kz35SaEW3lp6Mq AsWBuo2n/33t6at9QSLR84eBvfyrW/zpazCNsYbcCmK6STK9Q5IerPti8prcRL02cdPZzsimZISn7 Wo8PClrfoRguVrC1OVcWxIkY8EUSH5XCuF+o2t61zbwygvvMGfL6tROExOhgSWTZ6EPsHEjWpKJMN hpNUa+MFZmI8zDCpGRnxx+UZqV+UO4eQre8X8QwSRuGvwR6xmYhiiilGt2KS3awLLtfBlvmupxM+x jRwFU8S6TgLcZR2C9d8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oknUQ-007Hro-Pk; Tue, 18 Oct 2022 14:22:42 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oknUK-007HqK-BS for linux-riscv@lists.infradead.org; Tue, 18 Oct 2022 14:22:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666102956; x=1697638956; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=r8hfM9vlb4HsYk2fm6pCiYv38TSz52CmPPsPliY0T8I=; b=xQ0jZSHAUgcdkfBZoVkDFj1l7p3QEi5/JgkjPdQN8gnrAV3SiXV4/MNg T1itr1IuKQ7H+PeUMNPOAWkPAeQvVf5dsysp6leQQur8XWUpWZtB3sRN3 99Q+yNhuTY52eCORoAlAsQmFUr2PaNF95XfAHmzh5nWEnhvZGOqvbbwM8 v1CSR65HSsn5UrZjvUdhZZqyWskhPpEkTD24ktN9rYPG+6wQ3IOt3yg+n fG7ISJVvLCSeTXiR2wpWzMi6ucmTqez3ZoxZGI4yVHTlRK0NqiyBaVQ9m PjB6zjIPgNOfxbdwQgWSNVJRE2eY2OfpGYnhKxc5rpSFsoExTlfsfzrn5 w==; X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="182745264" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Oct 2022 07:22:31 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 18 Oct 2022 07:22:30 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Tue, 18 Oct 2022 07:22:29 -0700 Date: Tue, 18 Oct 2022 15:22:06 +0100 From: Conor Dooley To: binglei wang CC: Conor Dooley , , , , , , , , , Subject: Re: [PATCH v8] rethook: add riscv rethook implementation Message-ID: References: <20220930081357.651914-1-l3b2w1@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221018_072236_485259_BAEF352B X-CRM114-Status: GOOD ( 57.80 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVHVlLCBPY3QgMTgsIDIwMjIgYXQgMTA6MDg6NTVQTSArMDgwMCwgYmluZ2xlaSB3YW5nIHdy b3RlOgo+IEhpIENvbm9yOgo+IFRoYW5rIHlvdSBmb3IgeW91ciBoZWxwIHRvIGNoZWNrIHRoZSBt ZXJnaW5nIHByb2Nlc3MgZm9yIHRoaXMgcGF0Y2guCj4gCj4gPiBUaHJlYWQgb3ZlcnZpZXc6IDMr IG1lc3NhZ2VzIChkb3dubG9hZDogbWJveC5neiAvIGZvbGxvdzogQXRvbSBmZWVkKQo+ID4gLS0g bGlua3MgYmVsb3cganVtcCB0byB0aGUgbWVzc2FnZSBvbiB0aGlzIHBhZ2UgLS0KPiA+ICAgICAg W25vdCBmb3VuZF0gPDIwMjIwOTMwMDgxMzU3LjY1MTkxNC0xLWwzYjJ3MUBnbWFpbC5jb20+Cj4g SSBoYXZlIG5vIGlkZWEgd2hhdCB0aGlzIG1lYW5zLCBJIGd1ZXNzIG1heWJlIHRoZSB3YXkgaSBz ZW5kZWQgdGhlCj4gcGF0Y2ggd2FzIG5vdCByaWdodC4KPiAKPiBJIGZvdW5kIHRoZSBwYXRjaCBv biB0aGUgbG9yZSBpbiB0aGlzIHVybCwgaXMgdGhpcyBoZWxwZnVsID8KPiBodHRwczovL2xvcmUu a2VybmVsLm9yZy9sa21sLzIwMjIxMDAyMTgxMDM1LjQ5MGFkMDE1NWQ3NDFlMzlmYWEyOTcxNkBr ZXJuZWwub3JnLwoKSG1tLCBsb29rcyBsaWtlIHlvdXIgcGF0Y2ggbWFkZSBpdCB0byBsa21sIGl0 c2VsZiBidXQgZ290IHJlamVjdGVkIGJ5CmxpbnV4LXJpc2N2IHdoaWNoIGlzIGhvc3RlZCBieSBp bmZyYWRlYWQuIEl0J3MgbWlzc2luZyBoZXJlOgpodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51 eC1yaXNjdi9DQUozQzRLd2oweVlTNUpDUHc9ZzBYOXFpUWh3MDRpS3lfY1RqYzB4OGlXZHkwYXk3 YmdAbWFpbC5nbWFpbC5jb20vVC8jdAoKPiAKPiA+IEknbSBub3QgcmVhbGx5IHN1cmUgd2hhdCdz IGhhcHBlbmVkIHRoZXJlLi4gSSBjYW4gb25seSBzZWUgeW91ciB2MSBhbmQKPiA+IHlvdXIgdjQg b24gbG9yZS9wYXRjaHdvcmsuCj4gSSBmaW5kIGFsbCBteSBjb21taXRzIGZyb20gdjEgdG8gdjgg aW4gdGhpcyBhZGRyCj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8/cT1sM2IydzEKPiAK PiBTaG91bGQgSSByZXNlbmQgdGhlIHBhdGNoIGFzIGEgbGFzdCByZXNvcnQgPwoKRWgsIEkgZ3Vl c3MgeW91IGNvdWxkIHRyeSAoYW5kIENDIHBhdGNoZXNAbGlzdHMubGludXguZGV2KS4gSSdtIG5v dCBzdXJlCmlmIHRoYXQnbGwgaGVscCBhdCBhbGwgdGhvdWdoLi4gQXQgd29yc3QsIGlmIHRoYXQg ZG9lc24ndCB3b3JrIEkgY291bGQKcG9zc2libHkgc2VuZCB0aGUgcGF0Y2hlcyBmb3IgeW91LiBP ciBpZiB5b3UgdGhpbmsgeW91IG1heSBlbmQgdXAgZG9pbmcKbW9yZSB1cHN0cmVhbSB3b3JrIHlv dSBjb3VsZCBhbHdheXMgYXBwbHkgZm9yIGFuIEBsaW51eC5kZXYgYWNjb3VudD8KU2VlIGh0dHBz Oi8va29yZy5kb2NzLmtlcm5lbC5vcmcvbGludXhkZXYuaHRtbCBmb3IgbW9yZSBpbmZvcm1hdGlv biBvbgp0aGF0LgoKPiAKPiBCaW5nbGVpIFdhbmcKPiBCZXN0IHdpc2hlcy4KPiAKPiBDb25vciBE b29sZXkgPGNvbm9yQGtlcm5lbC5vcmc+IOS6jjIwMjLlubQxMOaciDE35pel5ZGo5LiAIDIyOjU4 5YaZ6YGT77yaCj4gPgo+ID4gT24gTW9uLCBPY3QgMTcsIDIwMjIgYXQgMTA6MzE6MjhQTSArMDgw MCwgYmluZ2xlaSB3YW5nIHdyb3RlOgo+ID4gPiBIaSBDb25vciwKPiA+ID4gY291bGQgeW91IHBs ZWFzZSBoZWxwIG1lIHRvIHB1c2ggZm9yd2FyZCBtZXJnaW5nIHByb2Nlc3Mgb2YgdGhpcyBwYXRj aAo+ID4gPiBpbnRvIHRoZSA2LjEgPyAgVGhhbmsgeW91IQo+ID4KPiA+IEhleSBCaW5nbGVpLAo+ ID4gVW5mb3J0dW5hdGVseSBpdCBpcyB0b28gbGF0ZSBmb3IgdjYuMSAodGhlIG1lcmdlIHdpbmRv dyBjbG9zZWQgb24KPiA+IFN1bmRheSwgUGFsbWVyIHNlbnQgaGlzIHNlY29uZCBQUiBvbiBGcmlk YXkpIGJ1dCBJIGRvbid0IHNlZSB3aHkgdGhpcwo+ID4gc2hvdWxkIG5vdCBiZSBwaWNrZWQgZm9y IHY2LjIuIEkgdHJpZWQgbGFzdCB3ZWVrICYgYWdhaW4ganVzdCBub3cgdG8KPiA+IGNoZWNrIHRo ZSBzdGF0dXMgb2YgdGhpcyBwYXRjaCBvbiBwYXRjaHdvcmsgYnV0IEkgY2Fubm90IGZpbmQgaXQg dGhlcmUuCj4gPiBTaW1pbGFybHksIHRoZSBwYXRjaCBkb2VzIG5vdCBhcHBlYXIgb24gbG9yZToK PiA+IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXJpc2N2L0NBSjNDNEt6eUFSN2RLWUZC S0h6RkVYci1kenItSk1HUkZWeCtkeWJNaFJQeTB1SFVnQUBtYWlsLmdtYWlsLmNvbS9ULyN0Cj4g PiBUaHJlYWQgb3ZlcnZpZXc6IDMrIG1lc3NhZ2VzIChkb3dubG9hZDogbWJveC5neiAvIGZvbGxv dzogQXRvbSBmZWVkKQo+ID4gLS0gbGlua3MgYmVsb3cganVtcCB0byB0aGUgbWVzc2FnZSBvbiB0 aGlzIHBhZ2UgLS0KPiA+ICAgICAgW25vdCBmb3VuZF0gPDIwMjIwOTMwMDgxMzU3LjY1MTkxNC0x LWwzYjJ3MUBnbWFpbC5jb20+Cj4gPiAyMDIyLTEwLTAyICA5OjEwIGAgW1BBVENIIHY4XSByZXRo b29rOiBhZGQgcmlzY3YgcmV0aG9vayBpbXBsZW1lbnRhdGlvbiBNYXNhbWkgSGlyYW1hdHN1Cj4g PiAyMDIyLTEwLTAyIDE2OjM5IGAgQ29ub3IgRG9vbGV5Cj4gPiAyMDIyLTEwLTE3IDE0OjMxICAg YCBiaW5nbGVpIHdhbmcKPiA+Cj4gPiBJJ20gbm90IHJlYWxseSBzdXJlIHdoYXQncyBoYXBwZW5l ZCB0aGVyZS4uIEkgY2FuIG9ubHkgc2VlIHlvdXIgdjEgYW5kCj4gPiB5b3VyIHY0IG9uIGxvcmUv cGF0Y2h3b3JrLiBNYXliZSB0YWtlIGEgbG9vayBpZiB5b3UgY2hhbmdlZCBhbnl0aGluZwo+ID4g YmV0d2VlbiB2ZXJzaW9ucyAmIHRyeSByZXNlbmRpbmcgYXMgdjk/Cj4gPgo+ID4gSFRILAo+ID4g Q29ub3IuCj4gPgo+ID4gPgo+ID4gPiBCaW5nbGVpIFdhbmcKPiA+ID4gQmVzdCB3aXNoZXMuCj4g PiA+Cj4gPiA+Cj4gPiA+IE9uIDIwMjItMTAtMDMgMDA6MzksIENvbm9yIERvb2xleSB3cm90ZToK PiA+ID4gPiBIZXkgQmluZ2xlaSwKPiA+ID4gPiBJIGFtIG5vdCBxdWFsaWZpZWQgdG8gZ2l2ZSB5 b3UgYW4gYWN0dWFsIFItYiBvbiB0aGlzIHBhdGNoLCBidXQgSSBzZWUKPiA+ID4gPiB5b3UgZGlk IGdldCBvbmUgZnJvbSBNYXNhbWkgd2hvIHZlcnkgbXVjaCBpcyEKPiA+ID4gPgo+ID4gPiA+IFRo YXQgc2FpZCwgdGhlIHBhdGNoIGxvb2tzIGEgbG90IGJldHRlciAoYW5kIG11Y2ggc2ltcGxlciEp IG5vdy4gVGhhbmtzCj4gPiA+ID4gZm9yIHN0aWNraW5nIHdpdGggaXQgZGVzcGl0ZSB0aGUgaW5p dGlhbCBpc3N1ZXMgd2l0aCB5b3VyIGVtYWlsIHNldHVwCj4gPiA+ID4gYW5kIHRoZSBzdWJtaXNz aW9uIHByb2Nlc3MuCj4gPiA+ID4KPiA+ID4gPiBUaGFua3MsCj4gPiA+ID4gQ29ub3IuCj4gPiA+ ID4KPiA+ID4gPiBPbiBGcmksIFNlcCAzMCwgMjAyMiBhdCAwNDoxMzo1N1BNICswODAwLCBCaW5n bGVpIFdhbmcgd3JvdGU6Cj4gPiA+ID4+IEZyb206IEJpbmdsZWkgV2FuZyA8bDNiMncxQGdtYWls LmNvbT4KPiA+ID4gPj4KPiA+ID4gPj4gSW1wbGVtZW50IHRoZSBrcmV0cHJvYmVzIG9uIHJpc2N2 IGFyY2ggYnkgdXNpbmcgcmV0aG9vayBtYWNoZW5pc20KPiA+ID4gPj4gd2hpY2ggYWJzdHJhY3Rz IGdlbmVyYWwga3JldHByb2JlIGluZm8gaW50byBhIHN0cnVjdCByZXRob29rX25vZGUKPiA+ID4g Pj4gdG8gYmUgZW1iZWRkZWQgaW4gdGhlIHN0cnVjdCBrcmV0cHJvYmVfaW5zdGFuY2UuCj4gPiA+ ID4+Cj4gPiA+ID4+IFNpZ25lZC1vZmYtYnk6IEJpbmdsZWkgV2FuZyA8bDNiMncxQGdtYWlsLmNv bT4KPiA+ID4gPj4gLS0tCj4gPiA+ID4+Cj4gPiA+ID4+IE5vdGVzOgo+ID4gPiA+PiAgICAgIHY4 OiBBZGQgdGhlIG9taXR0ZWQgcmV0aG9vay5oCj4gPiA+ID4+ICAgICAgdjc6IEFkZCB0aGUgY2hh bmdlbG9nLgo+ID4gPiA+PiAgICAgIHY2OiBSZW1vdmUgdGhlIGtyZXRwcm9iZXMgdHJhbXBvbGlu ZS4KPiA+ID4gPj4gICAgICB2NTogVHJ0IHRvIGZpeCByb2JvdCBjb21waWxpbmcgZXJyb3IgYW5k IHdhcm5pbmdzLgo+ID4gPiA+PiAgICAgIHY0OiBBZGQgcGF0Y2ggdmVyc2lvbiBudW1iZXIuCj4g PiA+ID4+ICAgICAgdjM6IFRydCB0byBmaXggcm9ib3QgY29tcGlsaW5nIGVycm9yIGFuZCB3YXJu aW5ncy4KPiA+ID4gPj4gICAgICB2MjogQWRkIGNvbWl0IGxvZyB0byBleHBsYWluIHJlYXNvbnMg YmVoaW5kIGNoYW5nZXMuCj4gPiA+ID4+ICAgICAgICAgIFVzZSBteSBwZXJzb25hbCBlbWFpbCBp bnN0ZWFkIG9mIHdvcmsgZW1haWwKPiA+ID4gPj4gICAgICAgICAgICAgIHRvIGF2b2lkIHRoZSBh dHRhY2htZW50cyBvZiBjb21wYW55IGluZm9ybWF0b24uCj4gPiA+ID4+ICAgICAgICAgIE1ha2Ug dGhlIGtwcm9iZXNfdHJhbXBvbGluZS5TIGNvZGUgdG8gYmUgc2hhcmVkLgo+ID4gPiA+PiAgICAg IHYxOiBBZGQgcmlzY3YgcmV0aG9vayBpbXBsZW1lbnRhdGlvbi4KPiA+ID4gPj4KPiA+ID4gPj4g ICBhcmNoL3Jpc2N2L0tjb25maWcgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSArCj4g PiA+ID4+ICAgYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9rcHJvYmVzLmggICAgICAgICAgICAgIHwg IDIgLS0KPiA+ID4gPj4gICBhcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvTWFrZWZpbGUgICAgICAg ICAgICAgfCAgMiArLQo+ID4gPiA+PiAgIGFyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9rcHJvYmVz LmMgICAgICAgICAgICB8IDEzIC0tLS0tLS0tLQo+ID4gPiA+PiAgIGFyY2gvcmlzY3Yva2VybmVs L3Byb2Jlcy9yZXRob29rLmMgICAgICAgICAgICB8IDI3ICsrKysrKysrKysrKysrKysrKysKPiA+ ID4gPj4gICBhcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9vay5oICAgICAgICAgICAgfCAg OCArKysrKysKPiA+ID4gPj4gICAuLi5vYmVzX3RyYW1wb2xpbmUuUyA9PiByZXRob29rX3RyYW1w b2xpbmUuU30gfCAgNiArKy0tLQo+ID4gPiA+PiAgIDcgZmlsZXMgY2hhbmdlZCwgNDAgaW5zZXJ0 aW9ucygrKSwgMTkgZGVsZXRpb25zKC0pCj4gPiA+ID4+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGFy Y2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9yZXRob29rLmMKPiA+ID4gPj4gICBjcmVhdGUgbW9kZSAx MDA2NDQgYXJjaC9yaXNjdi9rZXJuZWwvcHJvYmVzL3JldGhvb2suaAo+ID4gPiA+PiAgIHJlbmFt ZSBhcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMve2twcm9iZXNfdHJhbXBvbGluZS5TID0+IHJldGhv b2tfdHJhbXBvbGluZS5TfSAoOTQlKQo+ID4gPiA+Pgo+ID4gPiA+PiBkaWZmIC0tZ2l0IGEvYXJj aC9yaXNjdi9LY29uZmlnIGIvYXJjaC9yaXNjdi9LY29uZmlnCj4gPiA+ID4+IGluZGV4IDU5ZDE4 ODgxZi4uYmZiNjZjZGM1IDEwMDY0NAo+ID4gPiA+PiAtLS0gYS9hcmNoL3Jpc2N2L0tjb25maWcK PiA+ID4gPj4gKysrIGIvYXJjaC9yaXNjdi9LY29uZmlnCj4gPiA+ID4+IEBAIC05Nyw2ICs5Nyw3 IEBAIGNvbmZpZyBSSVNDVgo+ID4gPiA+PiAgICAgIHNlbGVjdCBIQVZFX0tQUk9CRVMgaWYgIVhJ UF9LRVJORUwKPiA+ID4gPj4gICAgICBzZWxlY3QgSEFWRV9LUFJPQkVTX09OX0ZUUkFDRSBpZiAh WElQX0tFUk5FTAo+ID4gPiA+PiAgICAgIHNlbGVjdCBIQVZFX0tSRVRQUk9CRVMgaWYgIVhJUF9L RVJORUwKPiA+ID4gPj4gKyAgICBzZWxlY3QgSEFWRV9SRVRIT09LIGlmICFYSVBfS0VSTkVMCj4g PiA+ID4+ICAgICAgc2VsZWN0IEhBVkVfTU9WRV9QTUQKPiA+ID4gPj4gICAgICBzZWxlY3QgSEFW RV9NT1ZFX1BVRAo+ID4gPiA+PiAgICAgIHNlbGVjdCBIQVZFX1BDSQo+ID4gPiA+PiBkaWZmIC0t Z2l0IGEvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9rcHJvYmVzLmggYi9hcmNoL3Jpc2N2L2luY2x1 ZGUvYXNtL2twcm9iZXMuaAo+ID4gPiA+PiBpbmRleCAyMTdlZjg5ZjIuLmU3ODgyY2NiMCAxMDA2 NDQKPiA+ID4gPj4gLS0tIGEvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9rcHJvYmVzLmgKPiA+ID4g Pj4gKysrIGIvYXJjaC9yaXNjdi9pbmNsdWRlL2FzbS9rcHJvYmVzLmgKPiA+ID4gPj4gQEAgLTQw LDggKzQwLDYgQEAgdm9pZCBhcmNoX3JlbW92ZV9rcHJvYmUoc3RydWN0IGtwcm9iZSAqcCk7Cj4g PiA+ID4+ICAgaW50IGtwcm9iZV9mYXVsdF9oYW5kbGVyKHN0cnVjdCBwdF9yZWdzICpyZWdzLCB1 bnNpZ25lZCBpbnQgdHJhcG5yKTsKPiA+ID4gPj4gICBib29sIGtwcm9iZV9icmVha3BvaW50X2hh bmRsZXIoc3RydWN0IHB0X3JlZ3MgKnJlZ3MpOwo+ID4gPiA+PiAgIGJvb2wga3Byb2JlX3Npbmds ZV9zdGVwX2hhbmRsZXIoc3RydWN0IHB0X3JlZ3MgKnJlZ3MpOwo+ID4gPiA+PiAtdm9pZCBfX2ty ZXRwcm9iZV90cmFtcG9saW5lKHZvaWQpOwo+ID4gPiA+PiAtdm9pZCBfX2twcm9iZXMgKnRyYW1w b2xpbmVfcHJvYmVfaGFuZGxlcihzdHJ1Y3QgcHRfcmVncyAqcmVncyk7Cj4gPiA+ID4+Cj4gPiA+ ID4+ICAgI2VuZGlmIC8qIENPTkZJR19LUFJPQkVTICovCj4gPiA+ID4+ICAgI2VuZGlmIC8qIF9B U01fUklTQ1ZfS1BST0JFU19IICovCj4gPiA+ID4+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2tl cm5lbC9wcm9iZXMvTWFrZWZpbGUgYi9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvTWFrZWZpbGUK PiA+ID4gPj4gaW5kZXggN2YwODQwZGNjLi5jNDAxMzllOWMgMTAwNjQ0Cj4gPiA+ID4+IC0tLSBh L2FyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9NYWtlZmlsZQo+ID4gPiA+PiArKysgYi9hcmNoL3Jp c2N2L2tlcm5lbC9wcm9iZXMvTWFrZWZpbGUKPiA+ID4gPj4gQEAgLTEsNiArMSw2IEBACj4gPiA+ ID4+ICAgIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ID4gPiA+PiAgIG9iai0k KENPTkZJR19LUFJPQkVTKSAgICAgICAgICAgICAgKz0ga3Byb2Jlcy5vIGRlY29kZS1pbnNuLm8g c2ltdWxhdGUtaW5zbi5vCj4gPiA+ID4+IC1vYmotJChDT05GSUdfS1BST0JFUykgICAgICAgICAg ICAgICArPSBrcHJvYmVzX3RyYW1wb2xpbmUubwo+ID4gPiA+PiArb2JqLSQoQ09ORklHX1JFVEhP T0spICAgICAgICAgICAgICAgKz0gcmV0aG9vay5vIHJldGhvb2tfdHJhbXBvbGluZS5vCj4gPiA+ ID4+ICAgb2JqLSQoQ09ORklHX0tQUk9CRVNfT05fRlRSQUNFKSAgICArPSBmdHJhY2Uubwo+ID4g PiA+PiAgIG9iai0kKENPTkZJR19VUFJPQkVTKSAgICAgICAgICAgICAgKz0gdXByb2Jlcy5vIGRl Y29kZS1pbnNuLm8gc2ltdWxhdGUtaW5zbi5vCj4gPiA+ID4+ICAgQ0ZMQUdTX1JFTU9WRV9zaW11 bGF0ZS1pbnNuLm8gPSAkKENDX0ZMQUdTX0ZUUkFDRSkKPiA+ID4gPj4gZGlmZiAtLWdpdCBhL2Fy Y2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9rcHJvYmVzLmMgYi9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9i ZXMva3Byb2Jlcy5jCj4gPiA+ID4+IGluZGV4IGU2ZTk1MGI3Yy4uZjIxNTkyZDIwIDEwMDY0NAo+ ID4gPiA+PiAtLS0gYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMva3Byb2Jlcy5jCj4gPiA+ID4+ ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9rcHJvYmVzLmMKPiA+ID4gPj4gQEAgLTM0 NSwxOSArMzQ1LDYgQEAgaW50IF9faW5pdCBhcmNoX3BvcHVsYXRlX2twcm9iZV9ibGFja2xpc3Qo dm9pZCkKPiA+ID4gPj4gICAgICByZXR1cm4gcmV0Owo+ID4gPiA+PiAgIH0KPiA+ID4gPj4KPiA+ ID4gPj4gLXZvaWQgX19rcHJvYmVzIF9fdXNlZCAqdHJhbXBvbGluZV9wcm9iZV9oYW5kbGVyKHN0 cnVjdCBwdF9yZWdzICpyZWdzKQo+ID4gPiA+PiAtewo+ID4gPiA+PiAtICAgIHJldHVybiAodm9p ZCAqKWtyZXRwcm9iZV90cmFtcG9saW5lX2hhbmRsZXIocmVncywgTlVMTCk7Cj4gPiA+ID4+IC19 Cj4gPiA+ID4+IC0KPiA+ID4gPj4gLXZvaWQgX19rcHJvYmVzIGFyY2hfcHJlcGFyZV9rcmV0cHJv YmUoc3RydWN0IGtyZXRwcm9iZV9pbnN0YW5jZSAqcmksCj4gPiA+ID4+IC0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHB0X3JlZ3MgKnJlZ3MpCj4gPiA+ID4+IC17Cj4g PiA+ID4+IC0gICAgcmktPnJldF9hZGRyID0gKGtwcm9iZV9vcGNvZGVfdCAqKXJlZ3MtPnJhOwo+ ID4gPiA+PiAtICAgIHJpLT5mcCA9IE5VTEw7Cj4gPiA+ID4+IC0gICAgcmVncy0+cmEgPSAodW5z aWduZWQgbG9uZykgJl9fa3JldHByb2JlX3RyYW1wb2xpbmU7Cj4gPiA+ID4+IC19Cj4gPiA+ID4+ IC0KPiA+ID4gPj4gICBpbnQgX19rcHJvYmVzIGFyY2hfdHJhbXBvbGluZV9rcHJvYmUoc3RydWN0 IGtwcm9iZSAqcCkKPiA+ID4gPj4gICB7Cj4gPiA+ID4+ICAgICAgcmV0dXJuIDA7Cj4gPiA+ID4+ IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9iZXMvcmV0aG9vay5jIGIvYXJjaC9y aXNjdi9rZXJuZWwvcHJvYmVzL3JldGhvb2suYwo+ID4gPiA+PiBuZXcgZmlsZSBtb2RlIDEwMDY0 NAo+ID4gPiA+PiBpbmRleCAwMDAwMDAwMDAuLmNiZDBkYTA1OQo+ID4gPiA+PiAtLS0gL2Rldi9u dWxsCj4gPiA+ID4+ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVsL3Byb2Jlcy9yZXRob29rLmMKPiA+ ID4gPj4gQEAgLTAsMCArMSwyNyBAQAo+ID4gPiA+PiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZp ZXI6IEdQTC0yLjAtb25seQo+ID4gPiA+PiArLyoKPiA+ID4gPj4gKyAqIEdlbmVyaWMgcmV0dXJu IGhvb2sgZm9yIHJpc2N2Lgo+ID4gPiA+PiArICovCj4gPiA+ID4+ICsKPiA+ID4gPj4gKyNpbmNs dWRlIDxsaW51eC9rcHJvYmVzLmg+Cj4gPiA+ID4+ICsjaW5jbHVkZSA8bGludXgvcmV0aG9vay5o Pgo+ID4gPiA+PiArI2luY2x1ZGUgInJldGhvb2suaCIKPiA+ID4gPj4gKwo+ID4gPiA+PiArLyog VGhpcyBpcyBjYWxsZWQgZnJvbSBhcmNoX3JldGhvb2tfdHJhbXBvbGluZSgpICovCj4gPiA+ID4+ ICt1bnNpZ25lZCBsb25nIF9fdXNlZCBhcmNoX3JldGhvb2tfdHJhbXBvbGluZV9jYWxsYmFjayhz dHJ1Y3QgcHRfcmVncyAqcmVncykKPiA+ID4gPj4gK3sKPiA+ID4gPj4gKyAgICByZXR1cm4gcmV0 aG9va190cmFtcG9saW5lX2hhbmRsZXIocmVncywgcmVncy0+czApOwo+ID4gPiA+PiArfQo+ID4g PiA+PiArTk9LUFJPQkVfU1lNQk9MKGFyY2hfcmV0aG9va190cmFtcG9saW5lX2NhbGxiYWNrKTsK PiA+ID4gPj4gKwo+ID4gPiA+PiArCj4gPiA+ID4+ICt2b2lkIGFyY2hfcmV0aG9va19wcmVwYXJl KHN0cnVjdCByZXRob29rX25vZGUgKnJobiwgc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIGJvb2wgbWNv dW50KQo+ID4gPiA+PiArewo+ID4gPiA+PiArICAgIHJobi0+cmV0X2FkZHIgPSByZWdzLT5yYTsK PiA+ID4gPj4gKyAgICByaG4tPmZyYW1lID0gcmVncy0+czA7Cj4gPiA+ID4+ICsKPiA+ID4gPj4g KyAgICAvKiByZXBsYWNlIHJldHVybiBhZGRyIHdpdGggdHJhbXBvbGluZSAqLwo+ID4gPiA+PiAr ICAgIHJlZ3MtPnJhID0gKHVuc2lnbmVkIGxvbmcpYXJjaF9yZXRob29rX3RyYW1wb2xpbmU7Cj4g PiA+ID4+ICt9Cj4gPiA+ID4+ICtOT0tQUk9CRV9TWU1CT0woYXJjaF9yZXRob29rX3ByZXBhcmUp Owo+ID4gPiA+PiArCj4gPiA+ID4+IGRpZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9i ZXMvcmV0aG9vay5oIGIvYXJjaC9yaXNjdi9rZXJuZWwvcHJvYmVzL3JldGhvb2suaAo+ID4gPiA+ PiBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gPiA+PiBpbmRleCAwMDAwMDAwMDAuLmNjNTczZDcw MQo+ID4gPiA+PiAtLS0gL2Rldi9udWxsCj4gPiA+ID4+ICsrKyBiL2FyY2gvcmlzY3Yva2VybmVs L3Byb2Jlcy9yZXRob29rLmgKPiA+ID4gPj4gQEAgLTAsMCArMSw4IEBACj4gPiA+ID4+ICsvLyBT UERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMC1vbmx5Cj4gPiA+ID4+ICsjaWZuZGVmIF9f UklTQ1ZfUkVUSE9PS19ICj4gPiA+ID4+ICsjZGVmaW5lIF9fUklTQ1ZfUkVUSE9PS19ICj4gPiA+ ID4+ICsKPiA+ID4gPj4gK3Vuc2lnbmVkIGxvbmcgYXJjaF9yZXRob29rX3RyYW1wb2xpbmVfY2Fs bGJhY2soc3RydWN0IHB0X3JlZ3MgKnJlZ3MpOwo+ID4gPiA+PiArdm9pZCBhcmNoX3JldGhvb2tf cHJlcGFyZShzdHJ1Y3QgcmV0aG9va19ub2RlICpyaG4sIHN0cnVjdCBwdF9yZWdzICpyZWdzLCBi b29sIG1jb3VudCk7Cj4gPiA+ID4+ICsKPiA+ID4gPj4gKyNlbmRpZgo+ID4gPiA+PiBkaWZmIC0t Z2l0IGEvYXJjaC9yaXNjdi9rZXJuZWwvcHJvYmVzL2twcm9iZXNfdHJhbXBvbGluZS5TIGIvYXJj aC9yaXNjdi9rZXJuZWwvcHJvYmVzL3JldGhvb2tfdHJhbXBvbGluZS5TCj4gPiA+ID4+IHNpbWls YXJpdHkgaW5kZXggOTQlCj4gPiA+ID4+IHJlbmFtZSBmcm9tIGFyY2gvcmlzY3Yva2VybmVsL3By b2Jlcy9rcHJvYmVzX3RyYW1wb2xpbmUuUwo+ID4gPiA+PiByZW5hbWUgdG8gYXJjaC9yaXNjdi9r ZXJuZWwvcHJvYmVzL3JldGhvb2tfdHJhbXBvbGluZS5TCj4gPiA+ID4+IGluZGV4IDdiZGIwOWRl ZC4uMjFiYWM5MmExIDEwMDY0NAo+ID4gPiA+PiAtLS0gYS9hcmNoL3Jpc2N2L2tlcm5lbC9wcm9i ZXMva3Byb2Jlc190cmFtcG9saW5lLlMKPiA+ID4gPj4gKysrIGIvYXJjaC9yaXNjdi9rZXJuZWwv cHJvYmVzL3JldGhvb2tfdHJhbXBvbGluZS5TCj4gPiA+ID4+IEBAIC03NSwxMyArNzUsMTMgQEAK PiA+ID4gPj4gICAgICBSRUdfTCB4MzEsIFBUX1Q2KHNwKQo+ID4gPiA+PiAgICAgIC5lbmRtCj4g PiA+ID4+Cj4gPiA+ID4+IC1FTlRSWShfX2tyZXRwcm9iZV90cmFtcG9saW5lKQo+ID4gPiA+PiAr RU5UUlkoYXJjaF9yZXRob29rX3RyYW1wb2xpbmUpCj4gPiA+ID4+ICAgICAgYWRkaSBzcCwgc3As IC0oUFRfU0laRV9PTl9TVEFDSykKPiA+ID4gPj4gICAgICBzYXZlX2FsbF9iYXNlX3JlZ3MKPiA+ ID4gPj4KPiA+ID4gPj4gICAgICBtb3ZlIGEwLCBzcCAvKiBwdF9yZWdzICovCj4gPiA+ID4+Cj4g PiA+ID4+IC0gICAgY2FsbCB0cmFtcG9saW5lX3Byb2JlX2hhbmRsZXIKPiA+ID4gPj4gKyAgICBj YWxsIGFyY2hfcmV0aG9va190cmFtcG9saW5lX2NhbGxiYWNrCj4gPiA+ID4+Cj4gPiA+ID4+ICAg ICAgLyogdXNlIHRoZSByZXN1bHQgYXMgdGhlIHJldHVybi1hZGRyZXNzICovCj4gPiA+ID4+ICAg ICAgbW92ZSByYSwgYTAKPiA+ID4gPj4gQEAgLTkwLDQgKzkwLDQgQEAgRU5UUlkoX19rcmV0cHJv YmVfdHJhbXBvbGluZSkKPiA+ID4gPj4gICAgICBhZGRpIHNwLCBzcCwgUFRfU0laRV9PTl9TVEFD Swo+ID4gPiA+Pgo+ID4gPiA+PiAgICAgIHJldAo+ID4gPiA+PiAtRU5EUFJPQyhfX2tyZXRwcm9i ZV90cmFtcG9saW5lKQo+ID4gPiA+PiArRU5EUFJPQyhhcmNoX3JldGhvb2tfdHJhbXBvbGluZSkK PiA+ID4gPj4gLS0KPiA+ID4gPj4gMi4yNy4wCj4gPiA+ID4+Cj4gPiA+Cj4gPiA+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiA+IGxpbnV4LXJpc2N2 IG1haWxpbmcgbGlzdAo+ID4gPiBsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCj4gPiA+ IGh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK PiA+ID4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxp bnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D92C4332F for ; Tue, 18 Oct 2022 14:22:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231392AbiJROW6 (ORCPT ); Tue, 18 Oct 2022 10:22:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231445AbiJROWs (ORCPT ); Tue, 18 Oct 2022 10:22:48 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C3AD7E01 for ; Tue, 18 Oct 2022 07:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1666102953; x=1697638953; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=r8hfM9vlb4HsYk2fm6pCiYv38TSz52CmPPsPliY0T8I=; b=lITEvrOZdTagXwRn8aHS8MyJdoYQ+3Ev8V4GFrcP61KX7pf7yGh07pyY +QXG2y2j4eoLiS+pXMrwz0H7Er3IC+MN1rAilnzeS/pnCgm2t+3JqVhk8 HM3N0W3EICe7GQ2BBhZhQyEyZBdiDseS9D/RPtK3sP6Gv0d/v9lX2L+G5 yjXtGKMrpaaH0C4dsCtUt2zq3kYODysMwP7JzvSeSYBZiNc/xYgXHWkB5 dVJpOINO+g1R/9uV8NFowi1/hHJxOhPQ8V79nSvT0cq1S39M9SGQXX7sZ XS0weAWYV6uPwQUl3lmH0eudYiMdXbPwxwk7zNKtMIRga0o92Za8dwTnH w==; X-IronPort-AV: E=Sophos;i="5.95,193,1661842800"; d="scan'208";a="182745264" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa2.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 18 Oct 2022 07:22:31 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12; Tue, 18 Oct 2022 07:22:30 -0700 Received: from wendy (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.12 via Frontend Transport; Tue, 18 Oct 2022 07:22:29 -0700 Date: Tue, 18 Oct 2022 15:22:06 +0100 From: Conor Dooley To: binglei wang CC: Conor Dooley , , , , , , , , , Subject: Re: [PATCH v8] rethook: add riscv rethook implementation Message-ID: References: <20220930081357.651914-1-l3b2w1@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 18, 2022 at 10:08:55PM +0800, binglei wang wrote: > Hi Conor: > Thank you for your help to check the merging process for this patch. > > > Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) > > -- links below jump to the message on this page -- > > [not found] <20220930081357.651914-1-l3b2w1@gmail.com> > I have no idea what this means, I guess maybe the way i sended the > patch was not right. > > I found the patch on the lore in this url, is this helpful ? > https://lore.kernel.org/lkml/20221002181035.490ad0155d741e39faa29716@kernel.org/ Hmm, looks like your patch made it to lkml itself but got rejected by linux-riscv which is hosted by infradead. It's missing here: https://lore.kernel.org/linux-riscv/CAJ3C4Kwj0yYS5JCPw=g0X9qiQhw04iKy_cTjc0x8iWdy0ay7bg@mail.gmail.com/T/#t > > > I'm not really sure what's happened there.. I can only see your v1 and > > your v4 on lore/patchwork. > I find all my commits from v1 to v8 in this addr > https://lore.kernel.org/lkml/?q=l3b2w1 > > Should I resend the patch as a last resort ? Eh, I guess you could try (and CC patches@lists.linux.dev). I'm not sure if that'll help at all though.. At worst, if that doesn't work I could possibly send the patches for you. Or if you think you may end up doing more upstream work you could always apply for an @linux.dev account? See https://korg.docs.kernel.org/linuxdev.html for more information on that. > > Binglei Wang > Best wishes. > > Conor Dooley 于2022年10月17日周一 22:58写道： > > > > On Mon, Oct 17, 2022 at 10:31:28PM +0800, binglei wang wrote: > > > Hi Conor, > > > could you please help me to push forward merging process of this patch > > > into the 6.1 ? Thank you! > > > > Hey Binglei, > > Unfortunately it is too late for v6.1 (the merge window closed on > > Sunday, Palmer sent his second PR on Friday) but I don't see why this > > should not be picked for v6.2. I tried last week & again just now to > > check the status of this patch on patchwork but I cannot find it there. > > Similarly, the patch does not appear on lore: > > https://lore.kernel.org/linux-riscv/CAJ3C4KzyAR7dKYFBKHzFEXr-dzr-JMGRFVx+dybMhRPy0uHUgA@mail.gmail.com/T/#t > > Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) > > -- links below jump to the message on this page -- > > [not found] <20220930081357.651914-1-l3b2w1@gmail.com> > > 2022-10-02 9:10 ` [PATCH v8] rethook: add riscv rethook implementation Masami Hiramatsu > > 2022-10-02 16:39 ` Conor Dooley > > 2022-10-17 14:31 ` binglei wang > > > > I'm not really sure what's happened there.. I can only see your v1 and > > your v4 on lore/patchwork. Maybe take a look if you changed anything > > between versions & try resending as v9? > > > > HTH, > > Conor. > > > > > > > > Binglei Wang > > > Best wishes. > > > > > > > > > On 2022-10-03 00:39, Conor Dooley wrote: > > > > Hey Binglei, > > > > I am not qualified to give you an actual R-b on this patch, but I see > > > > you did get one from Masami who very much is! > > > > > > > > That said, the patch looks a lot better (and much simpler!) now. Thanks > > > > for sticking with it despite the initial issues with your email setup > > > > and the submission process. > > > > > > > > Thanks, > > > > Conor. > > > > > > > > On Fri, Sep 30, 2022 at 04:13:57PM +0800, Binglei Wang wrote: > > > >> From: Binglei Wang > > > >> > > > >> Implement the kretprobes on riscv arch by using rethook machenism > > > >> which abstracts general kretprobe info into a struct rethook_node > > > >> to be embedded in the struct kretprobe_instance. > > > >> > > > >> Signed-off-by: Binglei Wang > > > >> --- > > > >> > > > >> Notes: > > > >> v8: Add the omitted rethook.h > > > >> v7: Add the changelog. > > > >> v6: Remove the kretprobes trampoline. > > > >> v5: Trt to fix robot compiling error and warnings. > > > >> v4: Add patch version number. > > > >> v3: Trt to fix robot compiling error and warnings. > > > >> v2: Add comit log to explain reasons behind changes. > > > >> Use my personal email instead of work email > > > >> to avoid the attachments of company informaton. > > > >> Make the kprobes_trampoline.S code to be shared. > > > >> v1: Add riscv rethook implementation. > > > >> > > > >> arch/riscv/Kconfig | 1 + > > > >> arch/riscv/include/asm/kprobes.h | 2 -- > > > >> arch/riscv/kernel/probes/Makefile | 2 +- > > > >> arch/riscv/kernel/probes/kprobes.c | 13 --------- > > > >> arch/riscv/kernel/probes/rethook.c | 27 +++++++++++++++++++ > > > >> arch/riscv/kernel/probes/rethook.h | 8 ++++++ > > > >> ...obes_trampoline.S => rethook_trampoline.S} | 6 ++--- > > > >> 7 files changed, 40 insertions(+), 19 deletions(-) > > > >> create mode 100644 arch/riscv/kernel/probes/rethook.c > > > >> create mode 100644 arch/riscv/kernel/probes/rethook.h > > > >> rename arch/riscv/kernel/probes/{kprobes_trampoline.S => rethook_trampoline.S} (94%) > > > >> > > > >> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > > > >> index 59d18881f..bfb66cdc5 100644 > > > >> --- a/arch/riscv/Kconfig > > > >> +++ b/arch/riscv/Kconfig > > > >> @@ -97,6 +97,7 @@ config RISCV > > > >> select HAVE_KPROBES if !XIP_KERNEL > > > >> select HAVE_KPROBES_ON_FTRACE if !XIP_KERNEL > > > >> select HAVE_KRETPROBES if !XIP_KERNEL > > > >> + select HAVE_RETHOOK if !XIP_KERNEL > > > >> select HAVE_MOVE_PMD > > > >> select HAVE_MOVE_PUD > > > >> select HAVE_PCI > > > >> diff --git a/arch/riscv/include/asm/kprobes.h b/arch/riscv/include/asm/kprobes.h > > > >> index 217ef89f2..e7882ccb0 100644 > > > >> --- a/arch/riscv/include/asm/kprobes.h > > > >> +++ b/arch/riscv/include/asm/kprobes.h > > > >> @@ -40,8 +40,6 @@ void arch_remove_kprobe(struct kprobe *p); > > > >> int kprobe_fault_handler(struct pt_regs *regs, unsigned int trapnr); > > > >> bool kprobe_breakpoint_handler(struct pt_regs *regs); > > > >> bool kprobe_single_step_handler(struct pt_regs *regs); > > > >> -void __kretprobe_trampoline(void); > > > >> -void __kprobes *trampoline_probe_handler(struct pt_regs *regs); > > > >> > > > >> #endif /* CONFIG_KPROBES */ > > > >> #endif /* _ASM_RISCV_KPROBES_H */ > > > >> diff --git a/arch/riscv/kernel/probes/Makefile b/arch/riscv/kernel/probes/Makefile > > > >> index 7f0840dcc..c40139e9c 100644 > > > >> --- a/arch/riscv/kernel/probes/Makefile > > > >> +++ b/arch/riscv/kernel/probes/Makefile > > > >> @@ -1,6 +1,6 @@ > > > >> # SPDX-License-Identifier: GPL-2.0 > > > >> obj-$(CONFIG_KPROBES) += kprobes.o decode-insn.o simulate-insn.o > > > >> -obj-$(CONFIG_KPROBES) += kprobes_trampoline.o > > > >> +obj-$(CONFIG_RETHOOK) += rethook.o rethook_trampoline.o > > > >> obj-$(CONFIG_KPROBES_ON_FTRACE) += ftrace.o > > > >> obj-$(CONFIG_UPROBES) += uprobes.o decode-insn.o simulate-insn.o > > > >> CFLAGS_REMOVE_simulate-insn.o = $(CC_FLAGS_FTRACE) > > > >> diff --git a/arch/riscv/kernel/probes/kprobes.c b/arch/riscv/kernel/probes/kprobes.c > > > >> index e6e950b7c..f21592d20 100644 > > > >> --- a/arch/riscv/kernel/probes/kprobes.c > > > >> +++ b/arch/riscv/kernel/probes/kprobes.c > > > >> @@ -345,19 +345,6 @@ int __init arch_populate_kprobe_blacklist(void) > > > >> return ret; > > > >> } > > > >> > > > >> -void __kprobes __used *trampoline_probe_handler(struct pt_regs *regs) > > > >> -{ > > > >> - return (void *)kretprobe_trampoline_handler(regs, NULL); > > > >> -} > > > >> - > > > >> -void __kprobes arch_prepare_kretprobe(struct kretprobe_instance *ri, > > > >> - struct pt_regs *regs) > > > >> -{ > > > >> - ri->ret_addr = (kprobe_opcode_t *)regs->ra; > > > >> - ri->fp = NULL; > > > >> - regs->ra = (unsigned long) &__kretprobe_trampoline; > > > >> -} > > > >> - > > > >> int __kprobes arch_trampoline_kprobe(struct kprobe *p) > > > >> { > > > >> return 0; > > > >> diff --git a/arch/riscv/kernel/probes/rethook.c b/arch/riscv/kernel/probes/rethook.c > > > >> new file mode 100644 > > > >> index 000000000..cbd0da059 > > > >> --- /dev/null > > > >> +++ b/arch/riscv/kernel/probes/rethook.c > > > >> @@ -0,0 +1,27 @@ > > > >> +// SPDX-License-Identifier: GPL-2.0-only > > > >> +/* > > > >> + * Generic return hook for riscv. > > > >> + */ > > > >> + > > > >> +#include > > > >> +#include > > > >> +#include "rethook.h" > > > >> + > > > >> +/* This is called from arch_rethook_trampoline() */ > > > >> +unsigned long __used arch_rethook_trampoline_callback(struct pt_regs *regs) > > > >> +{ > > > >> + return rethook_trampoline_handler(regs, regs->s0); > > > >> +} > > > >> +NOKPROBE_SYMBOL(arch_rethook_trampoline_callback); > > > >> + > > > >> + > > > >> +void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount) > > > >> +{ > > > >> + rhn->ret_addr = regs->ra; > > > >> + rhn->frame = regs->s0; > > > >> + > > > >> + /* replace return addr with trampoline */ > > > >> + regs->ra = (unsigned long)arch_rethook_trampoline; > > > >> +} > > > >> +NOKPROBE_SYMBOL(arch_rethook_prepare); > > > >> + > > > >> diff --git a/arch/riscv/kernel/probes/rethook.h b/arch/riscv/kernel/probes/rethook.h > > > >> new file mode 100644 > > > >> index 000000000..cc573d701 > > > >> --- /dev/null > > > >> +++ b/arch/riscv/kernel/probes/rethook.h > > > >> @@ -0,0 +1,8 @@ > > > >> +// SPDX-License-Identifier: GPL-2.0-only > > > >> +#ifndef __RISCV_RETHOOK_H > > > >> +#define __RISCV_RETHOOK_H > > > >> + > > > >> +unsigned long arch_rethook_trampoline_callback(struct pt_regs *regs); > > > >> +void arch_rethook_prepare(struct rethook_node *rhn, struct pt_regs *regs, bool mcount); > > > >> + > > > >> +#endif > > > >> diff --git a/arch/riscv/kernel/probes/kprobes_trampoline.S b/arch/riscv/kernel/probes/rethook_trampoline.S > > > >> similarity index 94% > > > >> rename from arch/riscv/kernel/probes/kprobes_trampoline.S > > > >> rename to arch/riscv/kernel/probes/rethook_trampoline.S > > > >> index 7bdb09ded..21bac92a1 100644 > > > >> --- a/arch/riscv/kernel/probes/kprobes_trampoline.S > > > >> +++ b/arch/riscv/kernel/probes/rethook_trampoline.S > > > >> @@ -75,13 +75,13 @@ > > > >> REG_L x31, PT_T6(sp) > > > >> .endm > > > >> > > > >> -ENTRY(__kretprobe_trampoline) > > > >> +ENTRY(arch_rethook_trampoline) > > > >> addi sp, sp, -(PT_SIZE_ON_STACK) > > > >> save_all_base_regs > > > >> > > > >> move a0, sp /* pt_regs */ > > > >> > > > >> - call trampoline_probe_handler > > > >> + call arch_rethook_trampoline_callback > > > >> > > > >> /* use the result as the return-address */ > > > >> move ra, a0 > > > >> @@ -90,4 +90,4 @@ ENTRY(__kretprobe_trampoline) > > > >> addi sp, sp, PT_SIZE_ON_STACK > > > >> > > > >> ret > > > >> -ENDPROC(__kretprobe_trampoline) > > > >> +ENDPROC(arch_rethook_trampoline) > > > >> -- > > > >> 2.27.0 > > > >> > > > > > > _______________________________________________ > > > linux-riscv mailing list > > > linux-riscv@lists.infradead.org > > > http://lists.infradead.org/mailman/listinfo/linux-riscv > > >