From: Jiri Pirko <jiri@resnulli.us>
To: Michal Wilczynski <michal.wilczynski@intel.com>
Cc: netdev@vger.kernel.org, alexandr.lobakin@intel.com,
jacob.e.keller@intel.com, jesse.brandeburg@intel.com,
przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com,
kuba@kernel.org, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next v6 1/4] devlink: Extend devlink-rate api with export functions and new params
Date: Tue, 18 Oct 2022 16:08:13 +0200 [thread overview]
Message-ID: <Y06zTYTdNPJAKfcw@nanopsycho> (raw)
In-Reply-To: <20221018123543.1210217-2-michal.wilczynski@intel.com>
Tue, Oct 18, 2022 at 02:35:39PM CEST, michal.wilczynski@intel.com wrote:
>ice driver needs an ability to create devlink-rate nodes from inside the
>driver. We have default Tx-scheduler tree that we would like to
>export as devlink-rate objects.
>
>There is also a need to support additional parameters, besides two that
>are supported currently:
>tx_priority - priority among siblings (0-7)
>tx_weight - weights for the WFQ algorithm (1-200)
>
>Allow creation of nodes from the driver, and introduce new argument
>to devl_rate_leaf_create, so the parent can be set during the creation
>of the leaf node.
>
>Implement new parameters - tx_priority, tx_weight.
>
>Allow modification of the priv field in the devlink_rate from parent_set
>callbacks. This is needed because creating nodes without parents doesn't
>make any sense in ice driver case. It's much more elegant to actually
>create a node when the parent is assigned.
This should be split into like 3-4 patches.
next prev parent reply other threads:[~2022-10-18 14:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 12:35 [PATCH net-next v6 0/4] Implement devlink-rate API and extend it Michal Wilczynski
2022-10-18 12:35 ` [PATCH net-next v6 1/4] devlink: Extend devlink-rate api with export functions and new params Michal Wilczynski
2022-10-18 14:08 ` Jiri Pirko [this message]
2022-10-18 15:13 ` Wilczynski, Michal
2022-10-18 12:35 ` [PATCH net-next v6 2/4] ice: Introduce new parameters in ice_sched_node Michal Wilczynski
2022-10-18 12:35 ` [PATCH net-next v6 3/4] ice: Implement devlink-rate API Michal Wilczynski
2022-10-18 12:35 ` [PATCH net-next v6 4/4] ice: Prevent DCB coexistence with Custom Tx scheduler Michal Wilczynski
2022-10-18 14:16 ` [PATCH net-next v6 0/4] Implement devlink-rate API and extend it Jiri Pirko
2022-10-18 15:13 ` Wilczynski, Michal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y06zTYTdNPJAKfcw@nanopsycho \
--to=jiri@resnulli.us \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ecree.xilinx@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=michal.wilczynski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.