All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Mingwei Zhang <mizhang@google.com>
Cc: "Kalra, Ashish" <ashish.kalra@amd.com>,
	ovidiu.panait@windriver.com, kvm@vger.kernel.org,
	liam.merwick@oracle.com, pbonzini@redhat.com,
	thomas.lendacky@amd.com, michael.roth@amd.com, pgonda@google.com,
	marcorr@google.com, alpergun@google.com, jarkko@kernel.org,
	jroedel@suse.de, bp@alien8.de, rientjes@google.com
Subject: Re: [PATCH 5.4 1/1] KVM: SEV: add cache flush to solve SEV cache incoherency issues
Date: Fri, 7 Oct 2022 17:00:55 +0000	[thread overview]
Message-ID: <Y0BbR7o5OZg59Bc8@google.com> (raw)
In-Reply-To: <Y0BK9/uo9eUE1RKb@google.com>

On Fri, Oct 07, 2022, Sean Christopherson wrote:
> On Thu, Oct 06, 2022, Mingwei Zhang wrote:
> > I have a limited knowledge on MM, but from my observations, it looks
> > like the property of a page being "PINNED" is very unreliable (or
> > expensive), i.e., anyone can jump in and pin the page. So it is hard
> > to see whether a page is truly "PINNED" or maybe just someone is
> > "working" on it without holding the lock.
> 
> mm/ differentiates between various types of pins, e.g. elevated refcount vs. pin
> vs. longterm pin.  See the comments in include/linux/mm.h for FOLL_PIN.

Ah, after catching up on the off-list thread, I suspect you're referring to the
the fact that even longterm pins don't prevent zapping[*].

NUMA balancing - already discussed

PMD splitting - If necessary, solvable by introducing MMU_NOTIFY_SPLIT, as a true
                split doesn't reclaim memory, i.e. KVM doesn't need to do WBINVD.
                Unfortunately, not straightforward as __split_huge_pmd_locked() may
                zap instead of split, but it is solvable.

KSM - absolutely should not be turned on for SEV guests

[*] https://lore.kernel.org/linux-arm-kernel/YuEMkKY2RU%2F2KiZW@monolith.localdoman

  reply	other threads:[~2022-10-07 17:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 14:52 [PATCH 5.4 1/1] KVM: SEV: add cache flush to solve SEV cache incoherency issues Ovidiu Panait
2022-09-26 19:00 ` Liam Merwick
2022-09-27  0:07 ` Ashish Kalra
2022-09-27  0:37   ` Sean Christopherson
2022-10-06 17:36     ` Kalra, Ashish
2022-10-07  1:15       ` Sean Christopherson
2022-10-07  6:03         ` Mingwei Zhang
2022-10-07 15:51           ` Sean Christopherson
2022-10-07 17:00             ` Sean Christopherson [this message]
2022-09-27  8:03 ` Ovidiu Panait

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0BbR7o5OZg59Bc8@google.com \
    --to=seanjc@google.com \
    --cc=alpergun@google.com \
    --cc=ashish.kalra@amd.com \
    --cc=bp@alien8.de \
    --cc=jarkko@kernel.org \
    --cc=jroedel@suse.de \
    --cc=kvm@vger.kernel.org \
    --cc=liam.merwick@oracle.com \
    --cc=marcorr@google.com \
    --cc=michael.roth@amd.com \
    --cc=mizhang@google.com \
    --cc=ovidiu.panait@windriver.com \
    --cc=pbonzini@redhat.com \
    --cc=pgonda@google.com \
    --cc=rientjes@google.com \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.