All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: "flyingpeng(彭浩)" <flyingpeng@tencent.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>
Subject: Re: [PATCH]  kvm: vmx: keep constant definition format consistent
Date: Fri, 7 Oct 2022 17:54:49 +0000	[thread overview]
Message-ID: <Y0Bn6SSFcwGt2II0@google.com> (raw)
In-Reply-To: <E2C645A3-8160-41A7-A8D3-F605946DFEF2@tencent.com>

On Tue, Sep 20, 2022, flyingpeng(彭浩) wrote:
> Keep all constants using lowercase "x".
> 
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
>  arch/x86/include/asm/vmx.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 0ffaa3156a4e..d1791b612170 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -296,7 +296,7 @@ enum vmcs_field {
>         GUEST_LDTR_AR_BYTES             = 0x00004820,
>         GUEST_TR_AR_BYTES               = 0x00004822,
>         GUEST_INTERRUPTIBILITY_INFO     = 0x00004824,
> -       GUEST_ACTIVITY_STATE            = 0X00004826,
> +       GUEST_ACTIVITY_STATE            = 0x00004826,

Heh, I'm somewhat surprised clang didn't throw an error on this.

Reviewed-by: Sean Christopherson <seanjc@google.com>

  reply	other threads:[~2022-10-07 17:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-20  4:52 [PATCH] kvm: vmx: keep constant definition format consistent flyingpeng(彭浩)
2022-10-07 17:54 ` Sean Christopherson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-09-23 15:03 Hao Peng
2022-09-27 12:15 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0Bn6SSFcwGt2II0@google.com \
    --to=seanjc@google.com \
    --cc=flyingpeng@tencent.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.