From: Christoph Hellwig <hch@infradead.org>
To: Guillaume Nault <gnault@redhat.com>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>,
Anna Schumaker <anna@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Benjamin Coddington <bcodding@redhat.com>
Subject: Re: [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag.
Date: Mon, 10 Oct 2022 07:55:29 -0700 [thread overview]
Message-ID: <Y0QyYV1Wyo4vof70@infradead.org> (raw)
In-Reply-To: <de6d99321d1dcaa2ad456b92b3680aa77c07a747.1665401788.git.gnault@redhat.com>
On Mon, Oct 10, 2022 at 01:41:57PM +0200, Guillaume Nault wrote:
> However, ->sk_allocation isn't used just by the memory allocator.
> In particular, sk_page_frag() uses it to figure out if it can return
> the page_frag from current or if it has to use the socket one.
Well, that just means sk_page_frag really needs to look at
PF_MEMALLOC_* as well. So instead of reverting the proper change
please fix that. A helper that looks at sk_allocation and
current->flags is probably the right way to deal with that.
next prev parent reply other threads:[~2022-10-10 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 11:41 [PATCH v2] sunrpc: Use GFP_NOFS to prevent use of current->task_frag Guillaume Nault
2022-10-10 14:55 ` Christoph Hellwig [this message]
2022-10-10 16:56 ` Guillaume Nault
2022-10-11 6:18 ` Christoph Hellwig
2022-10-11 15:00 ` Guillaume Nault
2022-10-11 15:57 ` Trond Myklebust
2022-10-11 21:14 ` Guillaume Nault
2022-10-13 12:18 ` Guillaume Nault
2022-10-25 11:15 ` Guillaume Nault
2022-12-07 11:47 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0QyYV1Wyo4vof70@infradead.org \
--to=hch@infradead.org \
--cc=anna@kernel.org \
--cc=bcodding@redhat.com \
--cc=chuck.lever@oracle.com \
--cc=gnault@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.