From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 940D1C433FE for ; Mon, 10 Oct 2022 15:59:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=06yQIrXH4hq1CqNUuav54WZr70HUPZ6j2G8IsJsbw6U=; b=E0dCf+kA1CqGsm VL+sWRp25jG2U32knCPP5p2yWr6OZsCUc0dIJTjL7VZwGkhyYc7qUznV2ebd55jrOtL1XDjOgyPUm dn5rAHryPBrae8UQfDgJ3HKaUSqYCmIm1pYjDb/xeYNq97nm63t0H6/TLmcbc59H33X6/GFY6kepn pxr4BHw1XrlIeU7uN54HZ4yVuU+4naAsZ0wKb2q+9VOD9AhiAd0MYp6T4O9VQ36eYt8Cd8P7k2/KW EY+DQicLU6IdrGoI0FlL3MSmu6eaw6exBVd2SgANmumC9HoGsWkBKyvQNF3OieeDH8eJVA7aq1iNp xvkdw9c4uA1jy1C+IF9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohvAS-001QW4-Mg; Mon, 10 Oct 2022 15:58:12 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohvAP-001QJI-DZ for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 15:58:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpOA3yDkOhhLvlnmsAVbYcm3nzeMbmZuIBkpzhRIZOI=; b=p65M3v9WQrCi7bcHQV5xlVnK0j ot7O6nOZ+yKjc2xMvbK2eh0JaV/tXy/1MT1h7isK40qeoia4HhmjixqIkQrjDFl8hkC367qySghQ2 9gHZLaAOWh+k33Q9tX1uC+QLgWtUTwq2nUWwOFm6+dfc4630y7z8zOyPNcPGIQRU5BCeVP0mx7Ele VG4UdCfEVmrxZx6md1TyyyrmcgA6/7rTEzuA0ZsmYhN1tkIhcZCzItA+1dlkXXKvPs1+jwGQ/bLtl Wor54DMrLbmQY1CFFXnIVDaxKlHi4dWGVrCHEnrTN1ywby77xz/py6ihrJrwPvm99mWTXZUoprGkO sb34A6SA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34664) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ohv8G-0004qc-3Z; Mon, 10 Oct 2022 16:55:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ohv8B-0001xp-P9; Mon, 10 Oct 2022 16:55:51 +0100 Date: Mon, 10 Oct 2022 16:55:51 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ARM: mm: Provide better message when kernel fault Message-ID: References: <20220927062134.99019-1-wangkefeng.wang@huawei.com> <4339e1f4-b5c1-0b61-3a37-e63aafe22857@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4339e1f4-b5c1-0b61-3a37-e63aafe22857@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_085809_473896_725091BB X-CRM114-Status: GOOD ( 11.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 10, 2022 at 07:24:15PM +0800, Kefeng Wang wrote: > > On 2022/9/27 14:21, Kefeng Wang wrote: > > If there is a kernel fault, see do_kernel_fault(), we only print > > the generic "paging request" or "NULL pointer dereference" message > > which don't show read, write or excute information, let's provide > > better fault message for them. > > Hi Russell, what's your option about this one, if no object, LGTM. > I will send to ARM patch system, thanks, Yes please, if not already done. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DD1FC433F5 for ; Mon, 10 Oct 2022 15:56:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229943AbiJJP4H (ORCPT ); Mon, 10 Oct 2022 11:56:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229644AbiJJP4E (ORCPT ); Mon, 10 Oct 2022 11:56:04 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676FE74CE1 for ; Mon, 10 Oct 2022 08:56:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpOA3yDkOhhLvlnmsAVbYcm3nzeMbmZuIBkpzhRIZOI=; b=p65M3v9WQrCi7bcHQV5xlVnK0j ot7O6nOZ+yKjc2xMvbK2eh0JaV/tXy/1MT1h7isK40qeoia4HhmjixqIkQrjDFl8hkC367qySghQ2 9gHZLaAOWh+k33Q9tX1uC+QLgWtUTwq2nUWwOFm6+dfc4630y7z8zOyPNcPGIQRU5BCeVP0mx7Ele VG4UdCfEVmrxZx6md1TyyyrmcgA6/7rTEzuA0ZsmYhN1tkIhcZCzItA+1dlkXXKvPs1+jwGQ/bLtl Wor54DMrLbmQY1CFFXnIVDaxKlHi4dWGVrCHEnrTN1ywby77xz/py6ihrJrwPvm99mWTXZUoprGkO sb34A6SA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34664) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ohv8G-0004qc-3Z; Mon, 10 Oct 2022 16:55:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ohv8B-0001xp-P9; Mon, 10 Oct 2022 16:55:51 +0100 Date: Mon, 10 Oct 2022 16:55:51 +0100 From: "Russell King (Oracle)" To: Kefeng Wang Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] ARM: mm: Provide better message when kernel fault Message-ID: References: <20220927062134.99019-1-wangkefeng.wang@huawei.com> <4339e1f4-b5c1-0b61-3a37-e63aafe22857@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4339e1f4-b5c1-0b61-3a37-e63aafe22857@huawei.com> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2022 at 07:24:15PM +0800, Kefeng Wang wrote: > > On 2022/9/27 14:21, Kefeng Wang wrote: > > If there is a kernel fault, see do_kernel_fault(), we only print > > the generic "paging request" or "NULL pointer dereference" message > > which don't show read, write or excute information, let's provide > > better fault message for them. > > Hi Russell, what's your option about this one, if no object, LGTM. > I will send to ARM patch system, thanks, Yes please, if not already done. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!