From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Lei He <helei.sig11@bytedance.com>
Cc: arei.gonglei@huawei.com, mst@redhat.com, pizhenwei@bytedance.com,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 2/4] crypto: Support DER encodings
Date: Tue, 11 Oct 2022 10:31:25 +0100 [thread overview]
Message-ID: <Y0U37bV0H4cFji2b@redhat.com> (raw)
In-Reply-To: <20221008085030.70212-3-helei.sig11@bytedance.com>
On Sat, Oct 08, 2022 at 04:50:28PM +0800, Lei He wrote:
> Add encoding interfaces for DER encoding:
> 1. support decoding of 'bit string', 'octet string', 'object id'
> and 'context specific tag' for DER encoder.
> 2. implemented a simple DER encoder.
> 3. add more testsuits for DER encoder.
>
> Signed-off-by: lei he <helei.sig11@bytedance.com>
> ---
> crypto/der.c | 307 +++++++++++++++++++++++++++++++++++++++----
> crypto/der.h | 211 ++++++++++++++++++++++++++++-
> tests/unit/test-crypto-der.c | 126 ++++++++++++++----
> 3 files changed, 597 insertions(+), 47 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2022-10-11 9:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-08 8:50 [PATCH v2 0/4] Add a new backend for cryptodev Lei He
2022-10-08 8:50 ` [PATCH v2 1/4] virtio-crypto: Support asynchronous mode Lei He
2022-11-01 10:37 ` Michael S. Tsirkin
2022-11-01 19:51 ` Michael S. Tsirkin
2022-11-02 2:24 ` Lei He
2022-11-02 8:18 ` Lei He
2022-10-08 8:50 ` [PATCH v2 2/4] crypto: Support DER encodings Lei He
2022-10-11 9:31 ` Daniel P. Berrangé [this message]
2022-10-08 8:50 ` [PATCH v2 3/4] crypto: Support export akcipher to pkcs8 Lei He
2022-10-11 9:33 ` Daniel P. Berrangé
2022-10-08 8:50 ` [PATCH v2 4/4] cryptodev: Add a lkcf-backend for cryptodev Lei He
2022-10-24 8:55 ` [PATCH v2 0/4] Add a new backend " Lei He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0U37bV0H4cFji2b@redhat.com \
--to=berrange@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=helei.sig11@bytedance.com \
--cc=mst@redhat.com \
--cc=pizhenwei@bytedance.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.