From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 117FCC43217 for ; Tue, 11 Oct 2022 06:22:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229972AbiJKGWz (ORCPT ); Tue, 11 Oct 2022 02:22:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229724AbiJKGWe (ORCPT ); Tue, 11 Oct 2022 02:22:34 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 45DD688DF2; Mon, 10 Oct 2022 23:22:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3931E61089; Tue, 11 Oct 2022 06:21:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26C7BC433B5; Tue, 11 Oct 2022 06:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665469311; bh=ZEn+9l/tLbnAqejF5hooJf26ogqUNObWamKwtHfGaAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MV1nZhLog3CLEEINQ29wAaICGOCBYEFGmmAJOAB93L55BORkUhc7Lk9V15gZTxjy8 Rp3DLoj4Nmfs9DrAAWoW5s4SCVLgLOhBIhBtP20B6lceAP3TCv6JHCFn6SaU4Co7sf UCciOXhBv7NtuNQe8WsQX3ROlNK3XDd0NLGFBZxw= Date: Tue, 11 Oct 2022 08:22:34 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Jiri Slaby , Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-15-quic_eberman@quicinc.com> <14d0ff9f-60f3-71cc-ea42-ceee389298ac@quicinc.com> <615493a8-449d-b105-709e-0642dfb5359b@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Oct 10, 2022 at 01:58:00PM -0700, Elliot Berman wrote: > > > On 10/10/2022 1:23 PM, Greg Kroah-Hartman wrote: > > On Sun, Oct 09, 2022 at 01:59:21PM -0700, Elliot Berman wrote: > > > > > > > > > On 10/7/2022 12:40 AM, Greg Kroah-Hartman wrote: > > > > On Thu, Oct 06, 2022 at 10:59:51PM -0700, Elliot Berman wrote: > > > > > > > > > > "GH" is the shorthand we've been using for "Gunyah". I didn't find > > > > > documentation for dynamically assigned char devices, but if it exists, I can > > > > > add entry for ttyGH. > > > > > > > > Why use a new name at all? Why not stick with the existing tty names > > > > and device numbers? > > > > > > > > > > I can use hvc framework, although driver-level buffering is needed on > > > both the get_chars/put_chars paths because: > > > > I'm not asking about the framework (although that is a good question, > > you need to document why this has to be new.) I'm asking why pick a new > > name? You will not have a name conflict in your system with this device > > with any other tty name right? > > > > That's correct, I didn't see any other instances of "ttyGH" in kernel. Do you see any instances of ttyS? Any other existing name? Why pick a new name at all? And if you do pick a new name, you need to document it really really well, not bury it downn within the tty driver code. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BA2FC433F5 for ; Tue, 11 Oct 2022 06:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7o0x2w1WL/SCXSWMTdxbVOxZYCEEYhL6ci2gD+Z2SOw=; b=QhGmx0PJRBypHh kSxmNAjuTOMV3R3IX8Y0yU5tmsUs55Yt7fccETCkp4sMxhmwz/y5LCPgvhdBu5O+tvFCo4K7A/I/k O35YLJSLhAYdu43s/ooLw3dxo0Jwsrmjxy4QUXzIcXcAzPaqj7lKCG2e+mPI3oGYcdSnqvGqkM7os xWYboAQvgzWT5DXSLqhP9RQmMNp1uK/Uid6tycVlh/tuN7gUmI8TtLVLLuNd+GdGGnL/ZT5k1TU44 CUcfWixpA3GCPYwKYqLaaNaV/iZ3RwOdHlWto1db3j2xVzIsqzXnUjqtRk2GITaL/KQIeQ/gYQ4Cx AeksKXnRFYy97bDWGGPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oi8fc-003PqH-6G; Tue, 11 Oct 2022 06:23:16 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oi8eG-003PI0-9D for linux-arm-kernel@lists.infradead.org; Tue, 11 Oct 2022 06:21:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCA6E61117; Tue, 11 Oct 2022 06:21:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26C7BC433B5; Tue, 11 Oct 2022 06:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665469311; bh=ZEn+9l/tLbnAqejF5hooJf26ogqUNObWamKwtHfGaAw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MV1nZhLog3CLEEINQ29wAaICGOCBYEFGmmAJOAB93L55BORkUhc7Lk9V15gZTxjy8 Rp3DLoj4Nmfs9DrAAWoW5s4SCVLgLOhBIhBtP20B6lceAP3TCv6JHCFn6SaU4Co7sf UCciOXhBv7NtuNQe8WsQX3ROlNK3XDd0NLGFBZxw= Date: Tue, 11 Oct 2022 08:22:34 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Jiri Slaby , Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-15-quic_eberman@quicinc.com> <14d0ff9f-60f3-71cc-ea42-ceee389298ac@quicinc.com> <615493a8-449d-b105-709e-0642dfb5359b@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_232152_389059_57F66CAF X-CRM114-Status: GOOD ( 24.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 10, 2022 at 01:58:00PM -0700, Elliot Berman wrote: > > > On 10/10/2022 1:23 PM, Greg Kroah-Hartman wrote: > > On Sun, Oct 09, 2022 at 01:59:21PM -0700, Elliot Berman wrote: > > > > > > > > > On 10/7/2022 12:40 AM, Greg Kroah-Hartman wrote: > > > > On Thu, Oct 06, 2022 at 10:59:51PM -0700, Elliot Berman wrote: > > > > > > > > > > "GH" is the shorthand we've been using for "Gunyah". I didn't find > > > > > documentation for dynamically assigned char devices, but if it exists, I can > > > > > add entry for ttyGH. > > > > > > > > Why use a new name at all? Why not stick with the existing tty names > > > > and device numbers? > > > > > > > > > > I can use hvc framework, although driver-level buffering is needed on > > > both the get_chars/put_chars paths because: > > > > I'm not asking about the framework (although that is a good question, > > you need to document why this has to be new.) I'm asking why pick a new > > name? You will not have a name conflict in your system with this device > > with any other tty name right? > > > > That's correct, I didn't see any other instances of "ttyGH" in kernel. Do you see any instances of ttyS? Any other existing name? Why pick a new name at all? And if you do pick a new name, you need to document it really really well, not bury it downn within the tty driver code. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel