From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Miguel Almeida Date: Wed, 12 Oct 2022 08:28:54 +1300 Subject: [Cluster-devel] [PATCH] [next] dlm: replace one-element array with fixed size array In-Reply-To: References: Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Oct 11, 2022 at 02:24:50PM -0500, Gustavo A. R. Silva wrote: > On Wed, Oct 12, 2022 at 08:15:17AM +1300, Paulo Miguel Almeida wrote: > > One-element arrays are deprecated. So, replace one-element array with > > fixed size array member in struct dlm_ls, and refactor the rest of the > > code, accordingly. > > > > Link: https://github.com/KSPP/linux/issues/79 > > Link: https://github.com/KSPP/linux/issues/228 > > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 > > Link: https://lore.kernel.org/lkml/Y0W5jkiXUkpNl4ap at mail.google.com/ > > > > Signed-off-by: Paulo Miguel Almeida > > I think this should be versioned as v3. > I didn't add v3 here because the the patch got changed from 'replacing [1]-array with flex-array' to 'replacing [1]-array to fixed-size array'. Let me know if you still want me to send it as v3 instead. Paulo A. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B830AC433F5 for ; Tue, 11 Oct 2022 19:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229748AbiJKT3D (ORCPT ); Tue, 11 Oct 2022 15:29:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229884AbiJKT3C (ORCPT ); Tue, 11 Oct 2022 15:29:02 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41AA37B2BC; Tue, 11 Oct 2022 12:29:01 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id b15so13372012pje.1; Tue, 11 Oct 2022 12:29:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d9o2w1TYXttFTTjml30YJIaN8TXEmaRFT+y/H7e7rsw=; b=dC1wzGp766abb0SfwXPsfebOw9HgWgXNqdpO6qpq7s+LBsK6ZNz+dWTdOUE0tLXYVq GY/O2+yVras3FbMVGMWt3JdzCTKO7bNfZNG3NDgCN+vlBbUtxBEo7TelNiyziE9zKYZz gD3wad0/0h9AnobdjeVX9HWbet9eL3k5IkGF5FKKtIu9kioahxh3jveXgMObXth7QKcb g5sVAz++SdUCt/kBGLrtAvZrEF13eim5Vbo2T8/o1xvlrDxwQWtXABM/JBfxurXQtWsa puUfMKJnQPMNGqN4BzvD9/8JzZ4gGAr7a3Z1ZQF6e/2XvWbtubCnyBcW4hZGEFL4mT/j jnwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d9o2w1TYXttFTTjml30YJIaN8TXEmaRFT+y/H7e7rsw=; b=xTHMZDYSXYiTkCa069+LL2Xh3tvdgv1yRbT8KrPnrMa6iml3UjV/EhhS03Psd3gUwz mUEvXix9ynlkIfv5wCeBcr0C5pQb2oYE8MEyY2B8PqECC3KYyjTKuWIMEXfZIifnVWKK tol8wV4Jy/SUQxXsPjF8OJtclcoGV+GBBWfIVIDE/DCPiT0irwquhOQGDUQfW+GyXgaA fmUPGjiFVIrEu/RuoqmEx/stqE1I1d8lZYvhezyq/nmhUdCq/0bDX6UrPDek3teRD57L GEHZwL9nX3cqAYJsPPMl2LdM9WUmODhsUMXfYSQe2jWnUKNsSxxQlestPUauEH0ZeuZL 29eA== X-Gm-Message-State: ACrzQf0mtKHi1nWVXQPRpdkgrChnXVS4oFWsv3yFHx1gJo0Xl89ka3W6 3nEsWNhnBiiBPW7nfycVLkQ= X-Google-Smtp-Source: AMsMyM7dTD9RlFu9H5B9jEVB/wKJRWOR006AKjiJYpzVFTj2wSDi2tFyAjbzJJ45g1ETN/A6035lbw== X-Received: by 2002:a17:90b:4b48:b0:20a:8ea4:a18d with SMTP id mi8-20020a17090b4b4800b0020a8ea4a18dmr775859pjb.75.1665516540714; Tue, 11 Oct 2022 12:29:00 -0700 (PDT) Received: from mail.google.com (122-58-209-93-fibre.sparkbb.co.nz. [122.58.209.93]) by smtp.gmail.com with ESMTPSA id d10-20020a17090a628a00b0020aaa678098sm553263pjj.49.2022.10.11.12.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Oct 2022 12:29:00 -0700 (PDT) Date: Wed, 12 Oct 2022 08:28:54 +1300 From: Paulo Miguel Almeida To: "Gustavo A. R. Silva" Cc: Christine Caulfield , David Teigland , cluster-devel@redhat.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] [next] dlm: replace one-element array with fixed size array Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Tue, Oct 11, 2022 at 02:24:50PM -0500, Gustavo A. R. Silva wrote: > On Wed, Oct 12, 2022 at 08:15:17AM +1300, Paulo Miguel Almeida wrote: > > One-element arrays are deprecated. So, replace one-element array with > > fixed size array member in struct dlm_ls, and refactor the rest of the > > code, accordingly. > > > > Link: https://github.com/KSPP/linux/issues/79 > > Link: https://github.com/KSPP/linux/issues/228 > > Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101836 > > Link: https://lore.kernel.org/lkml/Y0W5jkiXUkpNl4ap@mail.google.com/ > > > > Signed-off-by: Paulo Miguel Almeida > > I think this should be versioned as v3. > I didn't add v3 here because the the patch got changed from 'replacing [1]-array with flex-array' to 'replacing [1]-array to fixed-size array'. Let me know if you still want me to send it as v3 instead. Paulo A.