From: Borislav Petkov <bp@alien8.de>
To: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
"H . Peter Anvin" <hpa@zytor.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
Tony Luck <tony.luck@intel.com>, Kai Huang <kai.huang@intel.com>,
Wander Lairson Costa <wander@redhat.com>,
Isaku Yamahata <isaku.yamahata@gmail.com>,
marcelo.cerri@canonical.com, tim.gardner@canonical.com,
khalid.elmously@canonical.com, philip.cox@canonical.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in driver module
Date: Wed, 12 Oct 2022 12:18:23 +0200 [thread overview]
Message-ID: <Y0aUb3n7ouaeAt2a@zn.tnic> (raw)
In-Reply-To: <20220928215535.26527-2-sathyanarayanan.kuppuswamy@linux.intel.com>
On Wed, Sep 28, 2022 at 02:55:33PM -0700, Kuppuswamy Sathyanarayanan wrote:
> To support TDX attestation, the TDX guest user interface driver must
> use the __tdx module_call() function in the driver to allow the user to
> obtain the TDREPORT.
>
> So export the __tdx_module_call() and move the TDX Module IDs to
> asm/tdx.h.
The functions with the __ prefix are usually lower-level interfaces
which should be internal. Usually.
Why aren't you exporting the tdx_module_call() one instead?
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-10-12 10:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 21:55 [PATCH v14 0/3] Add TDX Guest Attestation support Kuppuswamy Sathyanarayanan
2022-09-28 21:55 ` [PATCH v14 1/3] x86/tdx: Make __tdx_module_call() usable in driver module Kuppuswamy Sathyanarayanan
2022-10-12 10:18 ` Borislav Petkov [this message]
2022-10-12 13:35 ` Sathyanarayanan Kuppuswamy
2022-10-12 14:27 ` Borislav Petkov
2022-10-12 15:44 ` Sathyanarayanan Kuppuswamy
2022-10-12 16:23 ` Greg Kroah-Hartman
2022-10-12 17:13 ` Sathyanarayanan Kuppuswamy
2022-10-12 17:26 ` Greg Kroah-Hartman
2022-10-12 18:11 ` Sathyanarayanan Kuppuswamy
2022-09-28 21:55 ` [PATCH v14 2/3] virt: Add TDX guest driver Kuppuswamy Sathyanarayanan
2022-09-29 18:02 ` Wander Lairson Costa
2022-09-29 18:11 ` Sathyanarayanan Kuppuswamy
2022-09-30 12:22 ` Greg Kroah-Hartman
2022-09-30 15:27 ` Sathyanarayanan Kuppuswamy
2022-10-12 15:47 ` Borislav Petkov
2022-10-12 23:01 ` Sathyanarayanan Kuppuswamy
2022-10-13 13:21 ` Borislav Petkov
2022-09-28 21:55 ` [PATCH v14 3/3] selftests: tdx: Test TDX attestation GetReport support Kuppuswamy Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0aUb3n7ouaeAt2a@zn.tnic \
--to=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=isaku.yamahata@gmail.com \
--cc=kai.huang@intel.com \
--cc=khalid.elmously@canonical.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=marcelo.cerri@canonical.com \
--cc=mingo@redhat.com \
--cc=philip.cox@canonical.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=tim.gardner@canonical.com \
--cc=tony.luck@intel.com \
--cc=wander@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.