From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96A5EC4167B for ; Thu, 13 Oct 2022 00:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231351AbiJMAaF (ORCPT ); Wed, 12 Oct 2022 20:30:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231429AbiJMA2h (ORCPT ); Wed, 12 Oct 2022 20:28:37 -0400 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC330171CE4 for ; Wed, 12 Oct 2022 17:25:30 -0700 (PDT) Received: by mail-pf1-f172.google.com with SMTP id d10so498566pfh.6 for ; Wed, 12 Oct 2022 17:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K7whd1nR2fxk/R3cx2zyxmptqUHfIbD5kvw3pDYFzeY=; b=e566s0v9gEdcj855wSrlCgX4YHujADy4NcAJWC9Hw8Xqj3kQVu0jVG6JAlWRUPnA2d yMUNl1hul0C3uJu8TMi93rbQDQjmNNir0NL2bFhBAaqpzPr8L93y3rS6uhzXM/dOf/0l h30s45JEPeLSOFq5sKQjtBbuLeDyndNpZg8V1UCuKHzS/X5UB3t0eg5Z83V51RUKAa3v XKRLj6hUCg0gBjVVI39A8o4HbwkzVDGGQz14VUh0SCtFjmzz/Cf4rpjLngnD8rPNRa8T CVL68UmBzXVxXanfxMyH/rWWwwNsrZezOUnw8ffeK/8e9pekpJ4uUj/iGD/FbXUH7qb3 ywEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K7whd1nR2fxk/R3cx2zyxmptqUHfIbD5kvw3pDYFzeY=; b=yh35VPDP4i7fRU7KurQhcamU2ai/vQm7Tdji0YTAZiXiejwfa4KCNkbGku8EV8caXH NmFKVbFxvv/MbS4oLY6HCcT1YYQlXoMSr+7y2rVkbnGw+6HNLfA+YfxxuEjcJqZn+0MU 8i01qk2vUUKbTrzP65fHJQQq64uR0Rg+0YEtiIWA1qpWiTeQ+1u/SQKHqNkz1FCPrmYy Z8H1ildnvu567UinW3cwPlliYjqoGGr56w1DznLbbL6gFEsKcU7Uj+Vck/xX9va32reM EbgmKoJKdFVaOpYlx0q0DeqM1mvJFWi+KvM4+2U3PPA1M94RJ/ur2ppWRGtkGb6t6bGB z1Sg== X-Gm-Message-State: ACrzQf0YfeypRtRHnu4H2TJhf+WZEFEif4JpBxZiMRmV9+Z9DoMkhQKB GY2M0eE2MDePUDr/v57+dKFTtA== X-Google-Smtp-Source: AMsMyM7U3ZOfPGst/WeZswFT/39Idt5/dCb2XWX4uzAW6+oLRyDTmnV8VxXSnqpodQSFBE/Vjs0J5g== X-Received: by 2002:aa7:93a8:0:b0:563:4dc2:9e5f with SMTP id x8-20020aa793a8000000b005634dc29e5fmr20061854pff.68.1665620543941; Wed, 12 Oct 2022 17:22:23 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id w187-20020a6262c4000000b00562f431f3d2sm460119pfb.83.2022.10.12.17.22.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 17:22:23 -0700 (PDT) Date: Thu, 13 Oct 2022 00:22:20 +0000 From: Sean Christopherson To: Michal Luczaj Cc: kvm@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH 8/8] KVM: x86: Fix NULL pointer dereference in kvm_xen_set_evtchn_fast() Message-ID: References: <20220921020140.3240092-1-mhal@rbox.co> <20220921020140.3240092-9-mhal@rbox.co> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Oct 10, 2022, Sean Christopherson wrote: > On Wed, Sep 21, 2022, Michal Luczaj wrote: > If this fixes things on your end (I'll properly test tomorrow too), I'll post a > v2 of the entire series. There are some cleanups that can be done on top, e.g. > I think we should drop kvm_gpc_unmap() entirely until there's actually a user, > because it's not at all obvious that it's (a) necessary and (b) has desirable > behavior. Sorry for the delay, I initially missed that you included a selftest for the race in the original RFC. The kernel is no longer exploding, but the test is intermittently soft hanging waiting for the "IRQ". I'll debug and hopefully post tomorrow.