All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Michael Guralnik <michaelgur@nvidia.com>,
	linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-rc] RDMA/cma: Use output interface for net_dev check
Date: Thu, 13 Oct 2022 11:43:42 +0300	[thread overview]
Message-ID: <Y0fPvlrpapweqrdA@unreal> (raw)
In-Reply-To: <20221012141542.16925-1-haakon.bugge@oracle.com>

On Wed, Oct 12, 2022 at 04:15:42PM +0200, Håkon Bugge wrote:
> Commit 27cfde795a96 ("RDMA/cma: Fix arguments order in net device
> validation") swapped the src and dst addresses in the call to
> validate_net_dev().
> 
> As a consequence, the test in validate_ipv4_net_dev() to see if the
> net_dev is the right one, is incorrect for port 1 <-> 2 communication
> when the ports are on the same sub-net. This is fixed by denoting the
> flowi4_oif as the device instead of the incoming one.
> 
> The bug has not been observed using IPv6 addresses.
> 
> Fixes: 27cfde795a96 ("RDMA/cma: Fix arguments order in net device validation")
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
> ---
>  drivers/infiniband/core/cma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

  reply	other threads:[~2022-10-13  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-12 14:15 [PATCH rdma-rc] RDMA/cma: Use output interface for net_dev check Håkon Bugge
2022-10-13  8:43 ` Leon Romanovsky [this message]
2022-10-13 10:31   ` Haakon Bugge
2022-10-13 10:49     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y0fPvlrpapweqrdA@unreal \
    --to=leon@kernel.org \
    --cc=haakon.bugge@oracle.com \
    --cc=jgg@nvidia.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=michaelgur@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.