From: Petr Vorel <pvorel@suse.cz>
To: zhaogongyi <zhaogongyi@huawei.com>
Cc: "ltp@lists.linux.it" <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 2/2] needs_root: Add setting of needs_root
Date: Thu, 13 Oct 2022 11:19:06 +0200 [thread overview]
Message-ID: <Y0fYCp2PdJ14/JYk@pevik> (raw)
In-Reply-To: <04dbdaf51ae940289775353f0535c4a4@huawei.com>
> Hi Petr,
> It is failed on my system:
> sh-4.4$ ./msgget03
> tst_test.c:1535: TINFO: Timeout per run is 0h 00m 30s
> msgget03.c:42: TINFO: Current environment 0 message queues are already in use
> msgget03.c:45: TBROK: Failed to open FILE '/proc/sys/kernel/msgmni' for writing: EACCES (13)
Ah, b740bfac5 ("msgget03: Set custom queue limit")
causes the need for root. IMHO this one is valid.
I'd suggest to remove needs_root for needs_device and mount_device now
(i.e. send v2).
nit: FYI most of the people use bottom posting on mailing lists, you use top
posting. Combine both makes it hard to follow.
https://en.wikipedia.org/wiki/Posting_style
Kind regards,
Petr
> Summary:
> passed 0
> failed 0
> broken 1
> skipped 0
> warnings 0
> tst_sys_conf.c:118: TWARN: Failed to open FILE '/proc/sys/kernel/msgmni'
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-10-13 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 7:45 [LTP] [PATCH 2/2] needs_root: Add setting of needs_root zhaogongyi via ltp
2022-10-13 9:19 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-20 12:21 zhaogongyi via ltp
2022-10-14 7:02 zhaogongyi via ltp
2022-10-14 2:00 zhaogongyi via ltp
2022-10-14 6:50 ` Petr Vorel
2022-10-13 14:03 zhaogongyi via ltp
2022-10-13 22:26 ` Petr Vorel
2022-10-12 9:15 [LTP] [PATCH 0/2] Optimization reference to needs_root Zhao Gongyi via ltp
2022-10-12 9:15 ` [LTP] [PATCH 2/2] needs_root: Add setting of needs_root Zhao Gongyi via ltp
2022-10-13 7:41 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0fYCp2PdJ14/JYk@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zhaogongyi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.