From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: jolsa@kernel.org, linux-perf-users@vger.kernel.org
Subject: Re: [PATCH] perf list: Fix title message
Date: Fri, 14 Oct 2022 12:22:12 -0300 [thread overview]
Message-ID: <Y0l+pNuWrIZVt3ZI@kernel.org> (raw)
In-Reply-To: <20221004192634.998984-1-ak@linux.intel.com>
Em Tue, Oct 04, 2022 at 12:26:34PM -0700, Andi Kleen escreveu:
> perf list metricgroups
>
> gives
>
> List of pre-defined events (to be used in -e):
>
> Metric Groups:
>
> Backend
> Bad
> BadSpec
>
> But that's incorrect of course because metric groups or metrics can only
> be specified with -M. So fix the message to say -e or -M
Thanks, applied.
- Arnaldo
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
> tools/perf/builtin-list.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c
> index 744dd3520584..58e1ec1654ef 100644
> --- a/tools/perf/builtin-list.c
> +++ b/tools/perf/builtin-list.c
> @@ -60,7 +60,7 @@ int cmd_list(int argc, const char **argv)
> setup_pager();
>
> if (!raw_dump && pager_in_use())
> - printf("\nList of pre-defined events (to be used in -e):\n\n");
> + printf("\nList of pre-defined events (to be used in -e or -M):\n\n");
>
> if (hybrid_type) {
> pmu_name = perf_pmu__hybrid_type_to_pmu(hybrid_type);
> --
> 2.37.2
--
- Arnaldo
prev parent reply other threads:[~2022-10-14 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 19:26 [PATCH] perf list: Fix title message Andi Kleen
2022-10-14 15:22 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0l+pNuWrIZVt3ZI@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-perf-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.