From: Brian Norris <briannorris@chromium.org>
To: Tzung-Bi Shih <tzungbi@kernel.org>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] platform/chrome: cros_ec_lpc: Move mec_init/destroy to device probe/remove
Date: Mon, 31 Oct 2022 09:42:54 -0700 [thread overview]
Message-ID: <Y1/7DgHiWLqbrDIi@google.com> (raw)
In-Reply-To: <Y19VXaB1531V64EI@google.com>
On Mon, Oct 31, 2022 at 12:55:57PM +0800, Tzung-Bi Shih wrote:
> There are 2 more cros_ec_lpc_mec_destroy()s need to be removed [2][3] though.
>
> [2]: https://elixir.bootlin.com/linux/v6.0/source/drivers/platform/chrome/cros_ec_lpc.c#L596
> [3]: https://elixir.bootlin.com/linux/v6.0/source/drivers/platform/chrome/cros_ec_lpc.c#L606
Your links / line numbers don't make sense, but I see your point. That
was a bad oversight on my part, sorry.
I see you're probably dropping the destroy() function, so I guess I'll
send v2 without this problem.
Brian
next prev parent reply other threads:[~2022-10-31 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 21:14 [PATCH 1/5] platform/chrome: cros_ec_lpc: Move mec_init/destroy to device probe/remove Brian Norris
2022-10-28 21:14 ` [PATCH 2/5] platform/chrome: cros_ec_lpc: Mark PROBE_PREFER_ASYNCHRONOUS Brian Norris
2022-10-28 21:14 ` [PATCH 3/5] platform/chrome: cros_ec_debugfs: Set PROBE_PREFER_ASYNCHRONOUS Brian Norris
2022-10-28 21:14 ` [PATCH 4/5] platform/chrome: cros_ec_lightbar: " Brian Norris
2022-10-28 21:14 ` [PATCH 5/5] platform/chrome: cros_ec_spi: " Brian Norris
2022-10-31 4:55 ` [PATCH 1/5] platform/chrome: cros_ec_lpc: Move mec_init/destroy to device probe/remove Tzung-Bi Shih
2022-10-31 5:14 ` Tzung-Bi Shih
2022-10-31 16:42 ` Brian Norris [this message]
2022-11-02 4:30 ` patchwork-bot+chrome-platform
2022-11-02 12:30 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/7DgHiWLqbrDIi@google.com \
--to=briannorris@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.