From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>,
hch@infradead.org, viro@zeniv.linux.org.uk, dhowells@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs: fix undefined behavior in bit shift for SB_NOUSER
Date: Mon, 31 Oct 2022 07:05:32 -0700 [thread overview]
Message-ID: <Y1/WLC3s7HHbSoSt@infradead.org> (raw)
In-Reply-To: <Y1/TWdY//yUgXGck@casper.infradead.org>
On Mon, Oct 31, 2022 at 01:53:29PM +0000, Matthew Wilcox wrote:
> On Mon, Oct 31, 2022 at 09:48:11PM +0800, Gaosheng Cui wrote:
> > +++ b/include/linux/fs.h
> > @@ -1384,19 +1384,19 @@ extern int send_sigurg(struct fown_struct *fown);
> > #define SB_NOATIME 1024 /* Do not update access times. */
> > #define SB_NODIRATIME 2048 /* Do not update directory access times */
> > #define SB_SILENT 32768
>
> Shouldn't those ^^^ also be marked as unsigned? And it's confusing to
> have the style change halfway through the sequence; can you convert them
> to (1U << n) as well?
I was planning on just sending a followup instead of blowing up the
scope even more, but yes - they should.
next prev parent reply other threads:[~2022-10-31 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 13:48 [PATCH v2] fs: fix undefined behavior in bit shift for SB_NOUSER Gaosheng Cui
2022-10-31 13:50 ` Christoph Hellwig
2022-10-31 13:53 ` Matthew Wilcox
2022-10-31 14:05 ` Christoph Hellwig [this message]
2022-10-31 14:36 ` cuigaosheng
-- strict thread matches above, loose matches on Subject: below --
2023-04-24 3:00 [PATCH] " Hao Ge
2023-04-24 4:51 ` [PATCH V2] " Hao Ge
2023-04-24 5:01 ` Al Viro
2023-04-24 5:43 ` Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1/WLC3s7HHbSoSt@infradead.org \
--to=hch@infradead.org \
--cc=cuigaosheng1@huawei.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.