From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F5A017F4 for ; Mon, 31 Oct 2022 09:29:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A29DC433D7; Mon, 31 Oct 2022 09:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667208572; bh=EOxMPFPGpawxIf7UM65WMi9P1mM8ehyiz49BsTEcp0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bYuvAf28heB93WEwZnbHlsXzizY/jNa+SasXsnHCcG9D5rp0yWB8326r4a4NMxuC5 dvx6HW59/3cJV/SIVq8o3XOf0xIqnASvs51z2lQeTGHg5NAdXzL4W5PoYJXWyYiR9u ZjRq98yryZN8xM/rfD/GYJlbb0jN1LhtHWEywSooBstO0x55NMchqFDZyFmbd0E0fr D8TWJbW1gcR6ytP/2rMLeURhHicri5MSsfr7vuSAaLW1Ommqem/tuBqSMF10rAsYAq T4hggu4GLDyLduPCsYrK23NSVMkItmZOBTqdbITrJdbXtiYXscgE6HwxolxSHZpmY/ oJcoQz8xJH6Jg== Date: Mon, 31 Oct 2022 09:29:26 +0000 From: Lee Jones To: Hector Martin Cc: Russell King , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter Subject: Re: [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Message-ID: References: <45ed0a37-60ac-3a06-92d1-6b30e18261ff@marcan.st> <8f30a490-f970-6605-20cb-c2256daab9de@marcan.st> <82088b05-2a0d-69cc-ba2c-d61c74c9d855@marcan.st> Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, 31 Oct 2022, Hector Martin wrote: > On 31/10/2022 17.48, Lee Jones wrote: > > On Sat, 29 Oct 2022, Hector Martin wrote: > > > >> On 09/09/2022 16.50, Lee Jones wrote: > >>>> What's the point of just having effectively an array of mfd_cell and > >>>> wrappers to call into the mfd core in the drivers/mfd/ tree and the > >>>> rest of the driver elsewhere? > >>> > >>> They should be separate drivers, with MFD registering the Platform. > >> > >> Why? What purpose does this serve? I'm still confused. There's one > >> parent device, which provides services to the child devices. There isn't > >> one parent device which wraps a platform service which is used by > >> children. This makes no sense. The platform device is the root, if it > >> exposes MFD services, then it has to be in that direction, not the other > >> way around. > >> > >> Look at how this patch series is architected. There is smc_core.c, which > >> implements SMC helpers and wrappers on top of a generic backend, and > >> registers with the MFD subsystem. And then there is smc_rtkit.c which is > >> the actual platform implementation on top of the RTKit framework, and is > >> the actual platform device entry point. > >> > >> A priori, the only thing that makes sense to me right now would be to > >> move smc_core.c into drivers/mfd, and leave smc_rtkit.c in platform. > >> That way the mfd registration would be in drivers/mfd (as would be the > >> services offered to sub-drivers), but the actual backend implementation > >> would be in platform/ (and there would eventually be others, e.g. at > >> least two more for x86 systems). That does mean that the driver entry > >> point will be in platform/, with mfd/smc_core.c serving as effectively > >> library code to plumb in the mfd stuff into one of several possible > >> platform devices. Would that work for you? > > > > Yes, sounds sensible. However, keep all of the abstraction craziness > > somewhere else and fetch and share all of your shared resources from > > the MFD (SMC) driver. > > I'm not sure what you mean by that. The abstraction (smc_core.c) *is* > the shared resource. All it does is wrap ops callbacks with a mutex and > add a couple helpers for finding keys. Do you literally want us to just > have this in drivers/mfd? > > // SPDX-License-Identifier: GPL-2.0-only OR MIT > /* > * Apple SMC MFD wrapper > * Copyright The Asahi Linux Contributors > */ > > #include > #include "smc.h" > > static const struct mfd_cell apple_smc_devs[] = { > { > .name = "macsmc-gpio", > }, > { > .name = "macsmc-hid", > }, > { > .name = "macsmc-power", > }, > { > .name = "macsmc-reboot", > }, > { > .name = "macsmc-rtc", > }, > }; > > int apple_smc_add_mfd_devices(struct device *dev) > { > ret = mfd_add_devices(dev, -1, apple_smc_devs, > ARRAY_SIZE(apple_smc_devs), NULL, 0, NULL); > if (ret) > return dev_err_probe(dev, ret, "Subdevice initialization failed"); > > return 0; > } > EXPORT_SYMBOL(apple_smc_add_mfd_devices); > > int apple_smc_remove_mfd_devices(struct device *dev) > { > mfd_remove_devices(smc->dev); > > return 0; > } > EXPORT_SYMBOL(apple_smc_add_mfd_devices); > > MODULE_AUTHOR("Hector Martin "); > MODULE_LICENSE("Dual MIT/GPL"); > MODULE_DESCRIPTION("Apple SMC MFD wrapper"); > > Because this feels *immensely* silly and pointless. ... and hacky. I agree. [BTW: if this is all you want to do, have you considered simple-mfd?] No, I want you to author a proper MFD device. The hardware you're describing in this submission *is* an MFD. So use the subsystem properly, instead of abusing it as a shim API to simply register platform devices. Request the device-wide memory (and other shared resources) here. Conduct core operations and initialisation here, then call into your Platform and other child devices to initiate the real work. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 600D4FA3742 for ; Mon, 31 Oct 2022 09:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aCLoiWkFCi0LPHZ8LqKHCPd8wItoycYBWLVTTI8dOHY=; b=GqCply6nj/I+vk 3XD6eIdW1GH7RAla/CYJ0SZznNRaG1msrIdHjcFwgdBG0IalwfsEV6va2+yNiAtE2TnwRd85AaX/O 1ysPRo1N2+FKAOhHGJSHIkojE83SZk+Wn0G0kQwUK0T0IK/Y0htyOdjk8UWf2BkF+ovQJ9tTwiQ6u Bih096oaN+hACyrFLCbwxPwdkmGwqc47alxBfkePnTmiRM5qkB6stu+lSnJyv8jZBTpJYw/Ttmf0r 2hax5puGBY4Gdn2rOEAFx36+QVuN0BtreGE6vRrNSZZG1O7Qk+XgOMue6Qw+7j0haR0o64mGL1K7y 3o66NSrT7EEjWppbyy6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opR74-00A6el-0g; Mon, 31 Oct 2022 09:29:47 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opR6s-00A6aI-NA for linux-arm-kernel@lists.infradead.org; Mon, 31 Oct 2022 09:29:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 58374B812A4; Mon, 31 Oct 2022 09:29:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A29DC433D7; Mon, 31 Oct 2022 09:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667208572; bh=EOxMPFPGpawxIf7UM65WMi9P1mM8ehyiz49BsTEcp0A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bYuvAf28heB93WEwZnbHlsXzizY/jNa+SasXsnHCcG9D5rp0yWB8326r4a4NMxuC5 dvx6HW59/3cJV/SIVq8o3XOf0xIqnASvs51z2lQeTGHg5NAdXzL4W5PoYJXWyYiR9u ZjRq98yryZN8xM/rfD/GYJlbb0jN1LhtHWEywSooBstO0x55NMchqFDZyFmbd0E0fr D8TWJbW1gcR6ytP/2rMLeURhHicri5MSsfr7vuSAaLW1Ommqem/tuBqSMF10rAsYAq T4hggu4GLDyLduPCsYrK23NSVMkItmZOBTqdbITrJdbXtiYXscgE6HwxolxSHZpmY/ oJcoQz8xJH6Jg== Date: Mon, 31 Oct 2022 09:29:26 +0000 From: Lee Jones To: Hector Martin Cc: Russell King , Arnd Bergmann , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter Subject: Re: [PATCH 4/6] platform/apple: Add new Apple Mac SMC driver Message-ID: References: <45ed0a37-60ac-3a06-92d1-6b30e18261ff@marcan.st> <8f30a490-f970-6605-20cb-c2256daab9de@marcan.st> <82088b05-2a0d-69cc-ba2c-d61c74c9d855@marcan.st> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_022935_101618_EFF254E7 X-CRM114-Status: GOOD ( 35.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAzMSBPY3QgMjAyMiwgSGVjdG9yIE1hcnRpbiB3cm90ZToKCj4gT24gMzEvMTAvMjAy MiAxNy40OCwgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gU2F0LCAyOSBPY3QgMjAyMiwgSGVjdG9y IE1hcnRpbiB3cm90ZToKPiA+IAo+ID4+IE9uIDA5LzA5LzIwMjIgMTYuNTAsIExlZSBKb25lcyB3 cm90ZToKPiA+Pj4+IFdoYXQncyB0aGUgcG9pbnQgb2YganVzdCBoYXZpbmcgZWZmZWN0aXZlbHkg YW4gYXJyYXkgb2YgbWZkX2NlbGwgYW5kCj4gPj4+PiB3cmFwcGVycyB0byBjYWxsIGludG8gdGhl IG1mZCBjb3JlIGluIHRoZSBkcml2ZXJzL21mZC8gdHJlZSBhbmQgdGhlCj4gPj4+PiByZXN0IG9m IHRoZSBkcml2ZXIgZWxzZXdoZXJlPwo+ID4+Pgo+ID4+PiBUaGV5IHNob3VsZCBiZSBzZXBhcmF0 ZSBkcml2ZXJzLCB3aXRoIE1GRCByZWdpc3RlcmluZyB0aGUgUGxhdGZvcm0uCj4gPj4KPiA+PiBX aHk/IFdoYXQgcHVycG9zZSBkb2VzIHRoaXMgc2VydmU/IEknbSBzdGlsbCBjb25mdXNlZC4gVGhl cmUncyBvbmUKPiA+PiBwYXJlbnQgZGV2aWNlLCB3aGljaCBwcm92aWRlcyBzZXJ2aWNlcyB0byB0 aGUgY2hpbGQgZGV2aWNlcy4gVGhlcmUgaXNuJ3QKPiA+PiBvbmUgcGFyZW50IGRldmljZSB3aGlj aCB3cmFwcyBhIHBsYXRmb3JtIHNlcnZpY2Ugd2hpY2ggaXMgdXNlZCBieQo+ID4+IGNoaWxkcmVu LiBUaGlzIG1ha2VzIG5vIHNlbnNlLiBUaGUgcGxhdGZvcm0gZGV2aWNlIGlzIHRoZSByb290LCBp ZiBpdAo+ID4+IGV4cG9zZXMgTUZEIHNlcnZpY2VzLCB0aGVuIGl0IGhhcyB0byBiZSBpbiB0aGF0 IGRpcmVjdGlvbiwgbm90IHRoZSBvdGhlcgo+ID4+IHdheSBhcm91bmQuCj4gPj4KPiA+PiBMb29r IGF0IGhvdyB0aGlzIHBhdGNoIHNlcmllcyBpcyBhcmNoaXRlY3RlZC4gVGhlcmUgaXMgc21jX2Nv cmUuYywgd2hpY2gKPiA+PiBpbXBsZW1lbnRzIFNNQyBoZWxwZXJzIGFuZCB3cmFwcGVycyBvbiB0 b3Agb2YgYSBnZW5lcmljIGJhY2tlbmQsIGFuZAo+ID4+IHJlZ2lzdGVycyB3aXRoIHRoZSBNRkQg c3Vic3lzdGVtLiBBbmQgdGhlbiB0aGVyZSBpcyBzbWNfcnRraXQuYyB3aGljaCBpcwo+ID4+IHRo ZSBhY3R1YWwgcGxhdGZvcm0gaW1wbGVtZW50YXRpb24gb24gdG9wIG9mIHRoZSBSVEtpdCBmcmFt ZXdvcmssIGFuZCBpcwo+ID4+IHRoZSBhY3R1YWwgcGxhdGZvcm0gZGV2aWNlIGVudHJ5IHBvaW50 Lgo+ID4+Cj4gPj4gQSBwcmlvcmksIHRoZSBvbmx5IHRoaW5nIHRoYXQgbWFrZXMgc2Vuc2UgdG8g bWUgcmlnaHQgbm93IHdvdWxkIGJlIHRvCj4gPj4gbW92ZSBzbWNfY29yZS5jIGludG8gZHJpdmVy cy9tZmQsIGFuZCBsZWF2ZSBzbWNfcnRraXQuYyBpbiBwbGF0Zm9ybS4KPiA+PiBUaGF0IHdheSB0 aGUgbWZkIHJlZ2lzdHJhdGlvbiB3b3VsZCBiZSBpbiBkcml2ZXJzL21mZCAoYXMgd291bGQgYmUg dGhlCj4gPj4gc2VydmljZXMgb2ZmZXJlZCB0byBzdWItZHJpdmVycyksIGJ1dCB0aGUgYWN0dWFs IGJhY2tlbmQgaW1wbGVtZW50YXRpb24KPiA+PiB3b3VsZCBiZSBpbiBwbGF0Zm9ybS8gKGFuZCB0 aGVyZSB3b3VsZCBldmVudHVhbGx5IGJlIG90aGVycywgZS5nLiBhdAo+ID4+IGxlYXN0IHR3byBt b3JlIGZvciB4ODYgc3lzdGVtcykuIFRoYXQgZG9lcyBtZWFuIHRoYXQgdGhlIGRyaXZlciBlbnRy eQo+ID4+IHBvaW50IHdpbGwgYmUgaW4gcGxhdGZvcm0vLCB3aXRoIG1mZC9zbWNfY29yZS5jIHNl cnZpbmcgYXMgZWZmZWN0aXZlbHkKPiA+PiBsaWJyYXJ5IGNvZGUgdG8gcGx1bWIgaW4gdGhlIG1m ZCBzdHVmZiBpbnRvIG9uZSBvZiBzZXZlcmFsIHBvc3NpYmxlCj4gPj4gcGxhdGZvcm0gZGV2aWNl cy4gV291bGQgdGhhdCB3b3JrIGZvciB5b3U/Cj4gPiAKPiA+IFllcywgc291bmRzIHNlbnNpYmxl LiAgSG93ZXZlciwga2VlcCBhbGwgb2YgdGhlIGFic3RyYWN0aW9uIGNyYXppbmVzcwo+ID4gc29t ZXdoZXJlIGVsc2UgYW5kIGZldGNoIGFuZCBzaGFyZSBhbGwgb2YgeW91ciBzaGFyZWQgcmVzb3Vy Y2VzIGZyb20KPiA+IHRoZSBNRkQgKFNNQykgZHJpdmVyLgo+IAo+IEknbSBub3Qgc3VyZSB3aGF0 IHlvdSBtZWFuIGJ5IHRoYXQuIFRoZSBhYnN0cmFjdGlvbiAoc21jX2NvcmUuYykgKmlzKgo+IHRo ZSBzaGFyZWQgcmVzb3VyY2UuIEFsbCBpdCBkb2VzIGlzIHdyYXAgb3BzIGNhbGxiYWNrcyB3aXRo IGEgbXV0ZXggYW5kCj4gYWRkIGEgY291cGxlIGhlbHBlcnMgZm9yIGZpbmRpbmcga2V5cy4gRG8g eW91IGxpdGVyYWxseSB3YW50IHVzIHRvIGp1c3QKPiBoYXZlIHRoaXMgaW4gZHJpdmVycy9tZmQ/ Cj4gCj4gLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjAtb25seSBPUiBNSVQKPiAv Kgo+ICAqIEFwcGxlIFNNQyBNRkQgd3JhcHBlcgo+ICAqIENvcHlyaWdodCBUaGUgQXNhaGkgTGlu dXggQ29udHJpYnV0b3JzCj4gICovCj4gCj4gI2luY2x1ZGUgPGxpbnV4L2RldmljZS5oPgo+ICNp bmNsdWRlICJzbWMuaCIKPiAKPiBzdGF0aWMgY29uc3Qgc3RydWN0IG1mZF9jZWxsIGFwcGxlX3Nt Y19kZXZzW10gPSB7Cj4gCXsKPiAJCS5uYW1lID0gIm1hY3NtYy1ncGlvIiwKPiAJfSwKPiAJewo+ IAkJLm5hbWUgPSAibWFjc21jLWhpZCIsCj4gCX0sCj4gCXsKPiAJCS5uYW1lID0gIm1hY3NtYy1w b3dlciIsCj4gCX0sCj4gCXsKPiAJCS5uYW1lID0gIm1hY3NtYy1yZWJvb3QiLAo+IAl9LAo+IAl7 Cj4gCQkubmFtZSA9ICJtYWNzbWMtcnRjIiwKPiAJfSwKPiB9Owo+IAo+IGludCBhcHBsZV9zbWNf YWRkX21mZF9kZXZpY2VzKHN0cnVjdCBkZXZpY2UgKmRldikKPiB7Cj4gCXJldCA9IG1mZF9hZGRf ZGV2aWNlcyhkZXYsIC0xLCBhcHBsZV9zbWNfZGV2cywKPiBBUlJBWV9TSVpFKGFwcGxlX3NtY19k ZXZzKSwgTlVMTCwgMCwgTlVMTCk7Cj4gCWlmIChyZXQpCj4gCQlyZXR1cm4gZGV2X2Vycl9wcm9i ZShkZXYsIHJldCwgIlN1YmRldmljZSBpbml0aWFsaXphdGlvbiBmYWlsZWQiKTsKPiAKPiAJcmV0 dXJuIDA7Cj4gfQo+IEVYUE9SVF9TWU1CT0woYXBwbGVfc21jX2FkZF9tZmRfZGV2aWNlcyk7Cj4g Cj4gaW50IGFwcGxlX3NtY19yZW1vdmVfbWZkX2RldmljZXMoc3RydWN0IGRldmljZSAqZGV2KQo+ IHsKPiAJbWZkX3JlbW92ZV9kZXZpY2VzKHNtYy0+ZGV2KTsKPiAKPiAJcmV0dXJuIDA7Cj4gfQo+ IEVYUE9SVF9TWU1CT0woYXBwbGVfc21jX2FkZF9tZmRfZGV2aWNlcyk7Cj4gCj4gTU9EVUxFX0FV VEhPUigiSGVjdG9yIE1hcnRpbiA8bWFyY2FuQG1hcmNhbi5zdD4iKTsKPiBNT0RVTEVfTElDRU5T RSgiRHVhbCBNSVQvR1BMIik7Cj4gTU9EVUxFX0RFU0NSSVBUSU9OKCJBcHBsZSBTTUMgTUZEIHdy YXBwZXIiKTsKPiAKPiBCZWNhdXNlIHRoaXMgZmVlbHMgKmltbWVuc2VseSogc2lsbHkgYW5kIHBv aW50bGVzcy4KCi4uLiBhbmQgaGFja3kuICBJIGFncmVlLgoKW0JUVzogaWYgdGhpcyBpcyBhbGwg eW91IHdhbnQgdG8gZG8sIGhhdmUgeW91IGNvbnNpZGVyZWQgc2ltcGxlLW1mZD9dCgpObywgSSB3 YW50IHlvdSB0byBhdXRob3IgYSBwcm9wZXIgTUZEIGRldmljZS4KClRoZSBoYXJkd2FyZSB5b3Un cmUgZGVzY3JpYmluZyBpbiB0aGlzIHN1Ym1pc3Npb24gKmlzKiBhbiBNRkQuICBTbyB1c2UKdGhl IHN1YnN5c3RlbSBwcm9wZXJseSwgaW5zdGVhZCBvZiBhYnVzaW5nIGl0IGFzIGEgc2hpbSBBUEkg dG8gc2ltcGx5CnJlZ2lzdGVyIHBsYXRmb3JtIGRldmljZXMuCgpSZXF1ZXN0IHRoZSBkZXZpY2Ut d2lkZSBtZW1vcnkgKGFuZCBvdGhlciBzaGFyZWQgcmVzb3VyY2VzKSBoZXJlLgpDb25kdWN0IGNv cmUgb3BlcmF0aW9ucyBhbmQgaW5pdGlhbGlzYXRpb24gaGVyZSwgdGhlbiBjYWxsIGludG8geW91 cgpQbGF0Zm9ybSBhbmQgb3RoZXIgY2hpbGQgZGV2aWNlcyB0byBpbml0aWF0ZSB0aGUgcmVhbCB3 b3JrLgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=