From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 194D0C38A02 for ; Mon, 31 Oct 2022 09:31:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/DyMFjSfXxniiWG4A7fEPikuhEvtOu9jr15vzqP4/uU=; b=IfJm9xZxArmDR7 0ZV5d3rzJEQjDA8REfRldOz9LnYddgSSGz/KhtBDTS4NhNmuRUdQFWtU6cC0UuanNckrnTpwSaSd4 375roHcybvdMhbnrGhUfGtDpjt/kmNEM+RU9ywKxVlwzxXDp6fRkQJ2Oe7FyYmkzigz4nvl72Z8MJ +qZrXOqpnM7OOrUNKs4Ub40U2UuAno/RuGGH3dHCFA77GJxRmWicAYNDd7rKb21LyH83qeXfeEEvX iQMNVBUlJ8iaEc+rFrJctoYQ89vDiufj/ynesG0eRlLgu66E/C3Gh5kQSIUGHjp4npIKvP4ZQOsYg kp58++VTkNlccZYB3sOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1opR8C-00A88C-Td; Mon, 31 Oct 2022 09:30:57 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1opR88-00A81f-AV for linux-arm-kernel@lists.infradead.org; Mon, 31 Oct 2022 09:30:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0912BB81261; Mon, 31 Oct 2022 09:30:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA16EC433D7; Mon, 31 Oct 2022 09:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667208649; bh=YUaMUT+y1DS8GEe/2s5XYv+66QzbLrUvEAKg+RlLAas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KcyLFXzEzb51ObBFj5edtmJIMhemVpWqNdFLb5Vrco53qC6L2JJlJPRQZMts6qDyF OZJ+2R5amzFUvaYgWDUlLPGffKvkOIwIiGen7yQ8xoAYGqE4BPCnbpkoNfF2D/nvIk 5N6Lp7vts4XeR8xqaXrrel6waJ2h2jJL0Rte4nr71oUXf5Vw1KjEDMS4qlTdr3IqwF +IE0REc7yPqaf2yuEFMzb9i/BgSXdAifCyphCcTg2Ykg2KX2kR8+80c4vgW8v8E1F4 I+ZG06yoZprOSS0pRsTVZ8YKkFv5gSL5Z8vEvaX5Y1C6vUI2vSQ4Pzj7dEdVa342Ys nty91idJVoOXA== Date: Mon, 31 Oct 2022 09:30:44 +0000 From: Lee Jones To: Liu Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221031_023052_521175_BDEF2A7C X-CRM114-Status: GOOD ( 19.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAzMSBPY3QgMjAyMiwgTGl1IFlpbmcgd3JvdGU6Cgo+IE9uIE1vbiwgMjAyMi0xMC0x NyBhdCAxNTo1NyArMDgwMCwgTGl1IFlpbmcgd3JvdGU6Cj4gPiBGcmVlc2NhbGUgaS5NWDhxeHAg Q29udHJvbCBhbmQgU3RhdHVzIFJlZ2lzdGVycyAoQ1NSKSBtb2R1bGUgaXMgYSBzeXN0ZW0KPiA+ IGNvbnRyb2xsZXIuIEl0IHJlcHJlc2VudHMgYSBzZXQgb2YgbWlzY2VsbGFuZW91cyByZWdpc3Rl cnMgb2YgYSBzcGVjaWZpYwo+ID4gc3Vic3lzdGVtLiBJdCBtYXkgcHJvdmlkZSBjb250cm9sIGFu ZC9vciBzdGF0dXMgcmVwb3J0IGludGVyZmFjZXMgdG8gYQo+ID4gbWl4IG9mIHN0YW5kYWxvbmUg aGFyZHdhcmUgZGV2aWNlcyB3aXRoaW4gdGhhdCBzdWJzeXN0ZW0uCj4gPiAKPiA+IFRoZSBDU1Ig bW9kdWxlIGluIGkuTVg4cW0vcXhwIFNvQ3MgaXMgYSBjaGlsZCBub2RlIG9mIGEgc2ltcGxlIHBv d2VyLW1hbmFnZWQKPiA+IGJ1cyhpLk1YOHF4cCBwaXhlbCBsaW5rIE1TSSBidXMpLiBUbyBwcm9w YWdhdGUgcG93ZXIgbWFuYWdlbWVudCBvcGVyYXRpb25zCj4gPiBvZiB0aGUgQ1NSIG1vZHVsZSdz IGNoaWxkIGRldmljZXMgdG8gdGhhdCBzaW1wbGUgcG93ZXItbWFuYWdlZCBidXMsIGFkZCBhCj4g PiBkZWRpY2F0ZWQgZHJpdmVyIGZvciB0aGUgQ1NSIG1vZHVsZS4gQWxzbywgdGhlIGRyaXZlciB3 b3VsZCBwb3B1bGF0ZSB0aGUgQ1NSCj4gPiBtb2R1bGUncyBjaGlsZCBkZXZpY2VzLgo+ID4gCj4g PiBTaWduZWQtb2ZmLWJ5OiBMaXUgWWluZyA8dmljdG9yLmxpdUBueHAuY29tPgo+ID4gLS0tCj4g PiBUaGUgRnJlZXNjYWxlIGkuTVg4cXhwIENTUiBEVCBiaW5kaW5ncyBpcyBhdAo+ID4gRG9jdW1l bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9mc2wsaW14OHF4cC1jc3IueWFtbC4KPiA+ IAo+ID4gUmVzZW5kIHRoZSBwYXRjaCBiYXNlZCBvbiB2Ni4xLXJjMS4KPiA+IAo+ID4gIGRyaXZl cnMvbWZkL0tjb25maWcgICAgICAgICAgIHwgMTAgKysrKysrKwo+ID4gIGRyaXZlcnMvbWZkL01h a2VmaWxlICAgICAgICAgIHwgIDEgKwo+ID4gIGRyaXZlcnMvbWZkL2ZzbC1pbXg4cXhwLWNzci5j IHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ICAzIGZpbGVzIGNo YW5nZWQsIDY0IGluc2VydGlvbnMoKykKPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9t ZmQvZnNsLWlteDhxeHAtY3NyLmMKPiAKPiBbLi4uXQo+IAo+IEdlbnRsZSBwaW5nLi4uCgpDb250 ZW50LWxlc3MgcGluZ3Mgd2lsbCBuZXZlciBiZSByZWNlaXZlZCB3ZWxsLgoKPiBBbnkgY29tbWVu dHMgcGxlYXNlPwoKWW91J3JlIGluIHRoZSBxdWV1ZS4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaW r10KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5A0C38A02 for ; Mon, 31 Oct 2022 09:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230220AbiJaJa4 (ORCPT ); Mon, 31 Oct 2022 05:30:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbiJaJay (ORCPT ); Mon, 31 Oct 2022 05:30:54 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56E2DDEA4 for ; Mon, 31 Oct 2022 02:30:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1483BB812A4 for ; Mon, 31 Oct 2022 09:30:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA16EC433D7; Mon, 31 Oct 2022 09:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667208649; bh=YUaMUT+y1DS8GEe/2s5XYv+66QzbLrUvEAKg+RlLAas=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KcyLFXzEzb51ObBFj5edtmJIMhemVpWqNdFLb5Vrco53qC6L2JJlJPRQZMts6qDyF OZJ+2R5amzFUvaYgWDUlLPGffKvkOIwIiGen7yQ8xoAYGqE4BPCnbpkoNfF2D/nvIk 5N6Lp7vts4XeR8xqaXrrel6waJ2h2jJL0Rte4nr71oUXf5Vw1KjEDMS4qlTdr3IqwF +IE0REc7yPqaf2yuEFMzb9i/BgSXdAifCyphCcTg2Ykg2KX2kR8+80c4vgW8v8E1F4 I+ZG06yoZprOSS0pRsTVZ8YKkFv5gSL5Z8vEvaX5Y1C6vUI2vSQ4Pzj7dEdVa342Ys nty91idJVoOXA== Date: Mon, 31 Oct 2022 09:30:44 +0000 From: Lee Jones To: Liu Ying Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com Subject: Re: [PATCH RESEND] mfd: Add Freescale i.MX8qxp Control and Status Registers (CSR) module driver Message-ID: References: <20221017075702.4182846-1-victor.liu@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Oct 2022, Liu Ying wrote: > On Mon, 2022-10-17 at 15:57 +0800, Liu Ying wrote: > > Freescale i.MX8qxp Control and Status Registers (CSR) module is a system > > controller. It represents a set of miscellaneous registers of a specific > > subsystem. It may provide control and/or status report interfaces to a > > mix of standalone hardware devices within that subsystem. > > > > The CSR module in i.MX8qm/qxp SoCs is a child node of a simple power-managed > > bus(i.MX8qxp pixel link MSI bus). To propagate power management operations > > of the CSR module's child devices to that simple power-managed bus, add a > > dedicated driver for the CSR module. Also, the driver would populate the CSR > > module's child devices. > > > > Signed-off-by: Liu Ying > > --- > > The Freescale i.MX8qxp CSR DT bindings is at > > Documentation/devicetree/bindings/mfd/fsl,imx8qxp-csr.yaml. > > > > Resend the patch based on v6.1-rc1. > > > > drivers/mfd/Kconfig | 10 +++++++ > > drivers/mfd/Makefile | 1 + > > drivers/mfd/fsl-imx8qxp-csr.c | 53 +++++++++++++++++++++++++++++++++++ > > 3 files changed, 64 insertions(+) > > create mode 100644 drivers/mfd/fsl-imx8qxp-csr.c > > [...] > > Gentle ping... Content-less pings will never be received well. > Any comments please? You're in the queue. -- Lee Jones [李琼斯]