From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations
Date: Sat, 29 Oct 2022 15:28:08 -0700 [thread overview]
Message-ID: <Y12o+Hk2qsIsDQUo@google.com> (raw)
In-Reply-To: <20221029142551.GA3222119@roeck-us.net>
On Sat, Oct 29, 2022 at 07:25:51AM -0700, Guenter Roeck wrote:
> On Fri, Sep 23, 2022 at 09:46:32PM +0300, Andy Shevchenko wrote:
> > When the data structure is only referred by pointer, compiler may not need
> > to see the contents of the data type. Thus, we may replace header inclusions
> > by respective forward declarations.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > include/linux/input/matrix_keypad.h | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/input/matrix_keypad.h b/include/linux/input/matrix_keypad.h
> > index 9476768c3b90..b8d8d69eba29 100644
> > --- a/include/linux/input/matrix_keypad.h
> > +++ b/include/linux/input/matrix_keypad.h
> > @@ -3,8 +3,9 @@
> > #define _MATRIX_KEYPAD_H
> >
> > #include <linux/types.h>
> > -#include <linux/input.h>
>
> Possibly, but may other drivers rely on those includes.
> This results in widespread build failures such as
>
> Building arm:allmodconfig ... failed
> --------------
> Error log:
> In file included from include/linux/input/samsung-keypad.h:12,
> from arch/arm/mach-s3c/keypad.h:12,
> from arch/arm/mach-s3c/mach-crag6410.c:57:
> arch/arm/mach-s3c/mach-crag6410.c:183:19: error: 'KEY_VOLUMEUP' undeclared here
I fixed this particular instance, hopefully it is one of the very
last of them...
--
Dmitry
next prev parent reply other threads:[~2022-10-29 22:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 18:46 [PATCH v1 1/2] Input: matrix_keypad - add missed header inclusion Andy Shevchenko
2022-09-23 18:46 ` [PATCH v1 2/2] Input: matrix_keypad - replace header inclusions by forward declarations Andy Shevchenko
2022-09-23 19:03 ` Dmitry Torokhov
2022-09-26 10:56 ` Andy Shevchenko
2022-09-26 10:56 ` Andy Shevchenko
2022-09-23 22:42 ` kernel test robot
2022-09-23 22:42 ` kernel test robot
2022-09-24 4:21 ` kernel test robot
2022-10-29 14:25 ` Guenter Roeck
2022-10-29 22:28 ` Dmitry Torokhov [this message]
2022-10-29 23:02 ` Guenter Roeck
2022-10-30 4:33 ` Dmitry Torokhov
2022-10-30 4:55 ` Guenter Roeck
2022-09-23 19:01 ` [PATCH v1 1/2] Input: matrix_keypad - add missed header inclusion Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y12o+Hk2qsIsDQUo@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.