From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Benson Leung <bleung@chromium.org>,
linux-rtc@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org,
Brian Norris <briannorris@chromium.org>
Subject: Re: [PATCH] rtc: cros-ec: Limit RTC alarm range if needed
Date: Mon, 31 Oct 2022 11:26:44 +0800 [thread overview]
Message-ID: <Y19AdIntJZGnBh/y@google.com> (raw)
In-Reply-To: <20221029005400.2712577-1-linux@roeck-us.net>
On Fri, Oct 28, 2022 at 05:54:00PM -0700, Guenter Roeck wrote:
> Drop error messages in cros_ec_rtc_get() and cros_ec_rtc_set() since the
> calling code also logs an error and to avoid spurious error messages if
> setting the alarm ultimately succeeds.
It only retries for cros_ec_rtc_set(). cros_ec_rtc_get() doesn't emit
spurious error messages.
cros_ec_rtc_get() could preserve the error log; cros_ec_rtc_set() could change
from using dev_err() to dev_warn() since cros_ec_rtc_set_alarm() calls
dev_err() if cros_ec_rtc_set() fails. But this is quite nitpick so anyway.
> Cc: Brian Norris <briannorris@chromium.org>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2022-10-31 3:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-29 0:54 [PATCH] rtc: cros-ec: Limit RTC alarm range if needed Guenter Roeck
2022-10-29 1:50 ` Brian Norris
2022-10-31 3:26 ` Tzung-Bi Shih [this message]
2022-10-31 16:36 ` Brian Norris
2022-10-31 17:10 ` Alexandre Belloni
2022-10-31 17:56 ` Brian Norris
2022-10-31 21:55 ` Alexandre Belloni
2022-10-31 22:47 ` Guenter Roeck
2022-10-31 18:19 ` Guenter Roeck
2022-10-31 22:14 ` Alexandre Belloni
2022-10-31 23:07 ` Guenter Roeck
2022-11-02 18:48 ` Guenter Roeck
2022-11-07 22:52 ` Alexandre Belloni
2022-11-08 16:59 ` Guenter Roeck
2022-11-14 18:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y19AdIntJZGnBh/y@google.com \
--to=tzungbi@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=bleung@chromium.org \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.