From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5ADAC4332F for ; Wed, 19 Oct 2022 23:32:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7FFCE4B8EE; Wed, 19 Oct 2022 19:32:44 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8x+sqiB99h9e; Wed, 19 Oct 2022 19:32:43 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 524864B8F2; Wed, 19 Oct 2022 19:32:43 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7685F4B64B for ; Wed, 19 Oct 2022 19:32:42 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id D6KE3A3wV681 for ; Wed, 19 Oct 2022 19:32:41 -0400 (EDT) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 4E35B4B646 for ; Wed, 19 Oct 2022 19:32:41 -0400 (EDT) Received: by mail-pl1-f172.google.com with SMTP id c24so18691298pls.9 for ; Wed, 19 Oct 2022 16:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GOdTdD623/YusJfsR/UmEt7HXnKEb0mP+WLNynhu5/Y=; b=RWtmUC50GX+0ZQ32g5qbwMLI9xk+r3RrIN8WIX6WSDXgNKi/IH1rFAOE4BaRmDOCQk q7NcLh/IYp1ium4abQncAyZUxt/D3M5+XQl9CoRXilqBPO8N7h8Jf1CsFhYVmbXfCDdJ GbBFo1r2OXRzCG1d6k4VKyRHomEcqSQLuRT1GyZuynIX/BDcf2/PoFz/pjQyhWdxhJ7R sVD0VYdKcDhEum9a00zy7yQZGSf1l+tyC0pHYAEN1ldQKbAxqHQ5v3UZrDNPbgf8ayEb tsZrpuY+i/Gwr3TBh/bb8CgBxKZoVz2rjfEqDWpfKxbbZxwNuW3dc3dvsTFn1MN1mOlW kiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GOdTdD623/YusJfsR/UmEt7HXnKEb0mP+WLNynhu5/Y=; b=P32SMf/TBGsjLWVMLYzrGs91ZP+OTwEd0zK9acnHAGseY+I+zZYDdVhkkX/itJ8DOX +lMHhpdk+wRKgb3W5SOA6bCzYPo4JtdURiKvrl+tU9elu6Ap85ctK+jl0qoQl/eKHD1m +8ykOh+aC5ysOmVM3pvCfq1143+vBF8WhlZ1EGa5ntGy2n/aBz84A1yzlRZBPAsqIMoK g7iS3i3e7rt8O6M0/E0e1noDThl1vO7810uW+t+tg/EwvFbc14hAQFS5MtUT8aBFJJTh m2wmTA1vcg6D+KcU8+GCZyoPsMhzcZO7sABCrE2/FZQA9vgmSbzF8+sgn8titzD2ZUBW MmPw== X-Gm-Message-State: ACrzQf1IC9KYrNDv6sFfNeyC7mhtOONa2EEeVufGQyS4wdM58M7B72Yt /4bkbWgZlbbrX+9kHghRg+4Y6w== X-Google-Smtp-Source: AMsMyM7CQOx8R08XpaqcxD826bEvd+nBp7WOm8CizWjgaSQhvlO4ECeDzJxBWgIKiZPBPtpO/OIQMw== X-Received: by 2002:a17:902:e3cd:b0:17f:9c94:b22f with SMTP id r13-20020a170902e3cd00b0017f9c94b22fmr10927856ple.80.1666222360234; Wed, 19 Oct 2022 16:32:40 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id f14-20020a170902ab8e00b001783f964fe3sm11270350plr.113.2022.10.19.16.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 16:32:39 -0700 (PDT) Date: Wed, 19 Oct 2022 23:32:36 +0000 From: Sean Christopherson To: Oliver Upton Subject: Re: [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel Message-ID: References: <20221007232818.459650-1-oliver.upton@linux.dev> <20221007233253.460257-1-oliver.upton@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221007233253.460257-1-oliver.upton@linux.dev> Cc: kvm@vger.kernel.org, Marc Zyngier , Will Deacon , kvmarm@lists.linux.dev, Ben Gardon , David Matlack , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Oct 07, 2022, Oliver Upton wrote: > @@ -1534,7 +1517,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > */ > kvm_pgtable_stage2_map(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT, > PAGE_SIZE, __pfn_to_phys(pfn), > - KVM_PGTABLE_PROT_R, NULL); > + KVM_PGTABLE_PROT_R, NULL, KVM_PGTABLE_WALK_SHARED); All MMU notifier events acquire mmu_lock for write when invoking arch code, i.e. this isn't a shared walk. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D63175C87 for ; Wed, 19 Oct 2022 23:32:40 +0000 (UTC) Received: by mail-pl1-f176.google.com with SMTP id h2so11350102plb.2 for ; Wed, 19 Oct 2022 16:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GOdTdD623/YusJfsR/UmEt7HXnKEb0mP+WLNynhu5/Y=; b=RWtmUC50GX+0ZQ32g5qbwMLI9xk+r3RrIN8WIX6WSDXgNKi/IH1rFAOE4BaRmDOCQk q7NcLh/IYp1ium4abQncAyZUxt/D3M5+XQl9CoRXilqBPO8N7h8Jf1CsFhYVmbXfCDdJ GbBFo1r2OXRzCG1d6k4VKyRHomEcqSQLuRT1GyZuynIX/BDcf2/PoFz/pjQyhWdxhJ7R sVD0VYdKcDhEum9a00zy7yQZGSf1l+tyC0pHYAEN1ldQKbAxqHQ5v3UZrDNPbgf8ayEb tsZrpuY+i/Gwr3TBh/bb8CgBxKZoVz2rjfEqDWpfKxbbZxwNuW3dc3dvsTFn1MN1mOlW kiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GOdTdD623/YusJfsR/UmEt7HXnKEb0mP+WLNynhu5/Y=; b=puKQndIxQyXLLfz3S/gT7tmKyUy/3dtbVGsBGMLwYCtwxbq3X6JHsTR/QENA+vnOKe eghSCfq02JaF+kvhRPU96FOsUKl5mcLaGnJ99AOJhrQq2w7FVbvzvcTxk7ePe9PdTfuY wueb0MjxUfj5GcwtMOs/btaXHS+7C0BLDRq4MpsihCsMyT+UHhZaT8A5wQKkZ12125YQ X2R29Sv/CrkGmzThaI/MZEa10ggRJJ9kdvjGEmVWSa2WfNq1E01ID0r9MG2B8ypeQL5/ LsCgkSaC6+mP4aylcK0zsZDkSfHV+qSJ6U2d18cjdrDNYBYyK2Rmkid4quIlrNhXwjPf OifQ== X-Gm-Message-State: ACrzQf3T5YsjC1ihUgIlSYXrkv1uz51hJkwRo+Do/K9Isy/3PHkTkoFu f5OuQtZfbXHNii4OhUucUH7l/g== X-Google-Smtp-Source: AMsMyM7CQOx8R08XpaqcxD826bEvd+nBp7WOm8CizWjgaSQhvlO4ECeDzJxBWgIKiZPBPtpO/OIQMw== X-Received: by 2002:a17:902:e3cd:b0:17f:9c94:b22f with SMTP id r13-20020a170902e3cd00b0017f9c94b22fmr10927856ple.80.1666222360234; Wed, 19 Oct 2022 16:32:40 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id f14-20020a170902ab8e00b001783f964fe3sm11270350plr.113.2022.10.19.16.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 16:32:39 -0700 (PDT) Date: Wed, 19 Oct 2022 23:32:36 +0000 From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , James Morse , Alexandru Elisei , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Reiji Watanabe , Ricardo Koller , David Matlack , Quentin Perret , Ben Gardon , Gavin Shan , Peter Xu , Will Deacon , kvmarm@lists.linux.dev Subject: Re: [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel Message-ID: References: <20221007232818.459650-1-oliver.upton@linux.dev> <20221007233253.460257-1-oliver.upton@linux.dev> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221007233253.460257-1-oliver.upton@linux.dev> Message-ID: <20221019233236.ojpmSPkXFCxsYzQm5U_1sfjhtk7xps7Jy1WZKOoh2r0@z> On Fri, Oct 07, 2022, Oliver Upton wrote: > @@ -1534,7 +1517,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > */ > kvm_pgtable_stage2_map(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT, > PAGE_SIZE, __pfn_to_phys(pfn), > - KVM_PGTABLE_PROT_R, NULL); > + KVM_PGTABLE_PROT_R, NULL, KVM_PGTABLE_WALK_SHARED); All MMU notifier events acquire mmu_lock for write when invoking arch code, i.e. this isn't a shared walk. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0105C4332F for ; Wed, 19 Oct 2022 23:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gaC9wNJmG6GI0dRAjvkyKY6ayz0GXEjTRFPNTKfFfts=; b=tgATHuF5SP1tGO ikL/Elt79R2S4g1RxdpU+sjVjQNoPK9mS6rb4zCwEdvC1NI8/6OU5DmRt4hakV68NcnRw2jbO4NMJ mnLyIe+N8We+pg/1EsLePsfjddEZBKpIKccE1z9VoonjMNsykTksQY7DCWd1s0ApnDYo8sK1QNIK1 q020CbRCtPsuQTMEZ7EYOvj7W6GKYq9SfOs9PWuy1hxgRsEwKqwGvIO0INH95icLYpPb05RDKXl05 XrpbVbaJCU15IgIFaMudIE7pQQJ5/aTLDzo6i8OQaJWGKPkK60qqxPrnySswHyDAesarRs2J+4tVS Cxa1QlpITsSyiQtOHCxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1olIYJ-005rZC-8I; Wed, 19 Oct 2022 23:32:47 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1olIYG-005rX7-3o for linux-arm-kernel@lists.infradead.org; Wed, 19 Oct 2022 23:32:45 +0000 Received: by mail-pl1-x62b.google.com with SMTP id f9so236292plb.13 for ; Wed, 19 Oct 2022 16:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GOdTdD623/YusJfsR/UmEt7HXnKEb0mP+WLNynhu5/Y=; b=RWtmUC50GX+0ZQ32g5qbwMLI9xk+r3RrIN8WIX6WSDXgNKi/IH1rFAOE4BaRmDOCQk q7NcLh/IYp1ium4abQncAyZUxt/D3M5+XQl9CoRXilqBPO8N7h8Jf1CsFhYVmbXfCDdJ GbBFo1r2OXRzCG1d6k4VKyRHomEcqSQLuRT1GyZuynIX/BDcf2/PoFz/pjQyhWdxhJ7R sVD0VYdKcDhEum9a00zy7yQZGSf1l+tyC0pHYAEN1ldQKbAxqHQ5v3UZrDNPbgf8ayEb tsZrpuY+i/Gwr3TBh/bb8CgBxKZoVz2rjfEqDWpfKxbbZxwNuW3dc3dvsTFn1MN1mOlW kiOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GOdTdD623/YusJfsR/UmEt7HXnKEb0mP+WLNynhu5/Y=; b=WxiQZiqRbeYM9XFSBlowGPdI3bxwr36p3zyLCz1YsEF/lGOeA2/Gg4vgFlLrzxmQ+O C5i6TEMhlrPQW+yim4KCk61FaL59hpGdnCXlrFWUTg6FnAJ+k62OTTgVehTBzPgGdpUp b83zEf2p2thNRhDxFU8wJgeE7HfM1LQALQSNDVaro2YvbnampiKAsTrOVP6WlQpX7UO6 SUHmrsffIHPFPV8gC0KB24djE1JbP85qKSpnPOf0lU9iM6OFuizeJmT8JSrRt0ReojEQ 10t2UoEn7MUwY6triTWpERZO9gmZzbmtBmkYRNIG/E9eeKaiaXpH5harzMnpcMj8dgUG xldw== X-Gm-Message-State: ACrzQf3s2HZXnjNoIL6dfkQMLAYylBFPnjKmuTIuI6vjIjcjoezDB0FG RaaXk2KrrBgFKM9hM/T5EkIdNQ== X-Google-Smtp-Source: AMsMyM7CQOx8R08XpaqcxD826bEvd+nBp7WOm8CizWjgaSQhvlO4ECeDzJxBWgIKiZPBPtpO/OIQMw== X-Received: by 2002:a17:902:e3cd:b0:17f:9c94:b22f with SMTP id r13-20020a170902e3cd00b0017f9c94b22fmr10927856ple.80.1666222360234; Wed, 19 Oct 2022 16:32:40 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id f14-20020a170902ab8e00b001783f964fe3sm11270350plr.113.2022.10.19.16.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Oct 2022 16:32:39 -0700 (PDT) Date: Wed, 19 Oct 2022 23:32:36 +0000 From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , James Morse , Alexandru Elisei , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Reiji Watanabe , Ricardo Koller , David Matlack , Quentin Perret , Ben Gardon , Gavin Shan , Peter Xu , Will Deacon , kvmarm@lists.linux.dev Subject: Re: [PATCH v2 15/15] KVM: arm64: Handle stage-2 faults in parallel Message-ID: References: <20221007232818.459650-1-oliver.upton@linux.dev> <20221007233253.460257-1-oliver.upton@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221007233253.460257-1-oliver.upton@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221019_163244_168067_934EAF9F X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 07, 2022, Oliver Upton wrote: > @@ -1534,7 +1517,7 @@ bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > */ > kvm_pgtable_stage2_map(kvm->arch.mmu.pgt, range->start << PAGE_SHIFT, > PAGE_SIZE, __pfn_to_phys(pfn), > - KVM_PGTABLE_PROT_R, NULL); > + KVM_PGTABLE_PROT_R, NULL, KVM_PGTABLE_WALK_SHARED); All MMU notifier events acquire mmu_lock for write when invoking arch code, i.e. this isn't a shared walk. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel