Re: Weird formatting in rtl8723bs driver code?

[Emily Peri <eperi1024@gmail.com>]

On Thu, Oct 20, 2022 at 07:13:58AM +0200, Julia Lawall wrote:
> 
> 
> On Wed, 19 Oct 2022, Emily Peri wrote:
> 
> > I'm working on cleaning up the rtl8723bs driver with checkpatch, but I
> > noticed that some of the variable declarations have differnt amounts of
> > whitespace, like this:
> >
> >         struct cmd_obj  *ph2c;
> >         struct sitesurvey_parm  *psurveyPara;
> >         struct cmd_priv                                 *pcmdpriv = &padapter->cmdpriv;
> >         struct mlme_ext_priv    *pmlmeext = &padapter->mlmeextpriv;
> >
> > At first I thought this was intentional, but now I'm wondering if this
> > is an accident. It's normal to just use one space between the type and
> > the variable name, right?
> 
> One space should be fine.  People may like to line up the variable names
> in some cases, but this is clearly not lined up either.
> 
> julia

Oh, that makes more sense! I'll keep that in mind.