All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: Jinhao Fan <fanjinhao21s@ict.ac.cn>
Cc: qemu-devel@nongnu.org, kbusch@kernel.org, stefanha@gmail.com
Subject: Re: [PATCH v3 0/4] irqfd, iothread and polling support
Date: Thu, 20 Oct 2022 13:16:51 +0200	[thread overview]
Message-ID: <Y1EuI60+kDFpQjlk@cormorant.local> (raw)
In-Reply-To: <20220827091258.3589230-1-fanjinhao21s@ict.ac.cn>

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

On Aug 27 17:12, Jinhao Fan wrote:
> This series of performance enhancements brings iothread and polling
> capabilities to qemu-nvme. The first two patches implements support
> for irqfd, which solves thread safety problems for interrupt emulation
> outside the main loop thread. The third patch adds support for
> emulating NVMe IO queues in a dedicated iothread, which avoid
> interference from other devices running on the main loop thread.
> The fourth patch implements SQ and CQ pollers, thus enabling polling
> on SQ and CQ.
> 
> After all these optimizations, our performance becomes similar to
> virtio-blk.
> 
> Comparison (KIOPS):
> 
> QD                    1   4  16  64
> virtio-blk           59 185 260 256
> nvme                 53 155 245 309
> virtio-blk-polling   88 212 210 213
> nvme-polling        123 165 189 191
> 

While reviewing this I noticed that the commit that introduced the
ioeventfd, we end up disabling batching of cqes (that is, we post and
interrupt for *each* cqe).

I'll post a patch to rectify that. With that, I am seeing progressive
performance improvements with the patches in this series.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      parent reply	other threads:[~2022-10-20 12:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-27  9:12 [PATCH v3 0/4] irqfd, iothread and polling support Jinhao Fan
2022-08-27  9:12 ` [PATCH v3 1/4] hw/nvme: support irq(de)assertion with eventfd Jinhao Fan
2022-08-27  9:12 ` [PATCH v3 2/4] hw/nvme: use KVM irqfd when available Jinhao Fan
2022-08-27  9:12 ` [PATCH v3 3/4] hw/nvme: add iothread support Jinhao Fan
2022-10-20 11:13   ` Klaus Jensen
2022-11-03  1:51     ` Jinhao Fan
2022-11-03 12:11       ` Klaus Jensen
2022-11-03 13:10         ` Jinhao Fan
2022-08-27  9:12 ` [PATCH v3 4/4] hw/nvme: add polling support Jinhao Fan
2022-10-20 11:10   ` Klaus Jensen
2022-11-03  2:18     ` Jinhao Fan
2022-11-03 12:10       ` Klaus Jensen
2022-11-03 13:19         ` Jinhao Fan
2022-11-04  6:32           ` Klaus Jensen
2022-11-08 12:39             ` John Levon
2022-11-08 14:11               ` Klaus Jensen
2022-11-09  4:35                 ` Jinhao Fan
2022-10-20 11:16 ` Klaus Jensen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1EuI60+kDFpQjlk@cormorant.local \
    --to=its@irrelevant.dk \
    --cc=fanjinhao21s@ict.ac.cn \
    --cc=kbusch@kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.