From: Sean Christopherson <seanjc@google.com>
To: Vipin Sharma <vipinsh@google.com>
Cc: pbonzini@redhat.com, dmatlack@google.com, andrew.jones@linux.dev,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/5] dirty_log_perf_test vCPU pinning
Date: Thu, 20 Oct 2022 21:46:44 +0000 [thread overview]
Message-ID: <Y1HBxL0frhyK3qhx@google.com> (raw)
In-Reply-To: <20221010220538.1154054-1-vipinsh@google.com>
On Mon, Oct 10, 2022, Vipin Sharma wrote:
> Pin vCPUs to a host physical CPUs (pCPUs) in dirty_log_perf_test and
> optionally pin the main application thread to a physical cpu if
> provided. All tests based on perf_test_util framework can take advantage
> of it if needed.
>
> While at it, I changed atoi() to atoi_paranoid(), atoi_positive,
> atoi_non_negative() in other tests, sorted command line options
> alphabetically in dirty_log_perf_test, and added break between -e and -g
> which was missed in original commit when -e was introduced.
...
> Vipin Sharma (5):
> KVM: selftests: Add missing break between -e and -g option in
> dirty_log_perf_test
> KVM: selftests: Put command line options in alphabetical order in
> dirty_log_perf_test
> KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi()
> KVM: selftests: Add atoi_positive() and atoi_non_negative() for input
> validation
> KVM: selftests: Run dirty_log_perf_test on specific CPUs
Minor nits on patch 5, but otherwise looks good. Might be worth sending a v6
just so there's no confusion.
prev parent reply other threads:[~2022-10-20 21:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 22:05 [PATCH v5 0/5] dirty_log_perf_test vCPU pinning Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 1/5] KVM: selftests: Add missing break between -e and -g option in dirty_log_perf_test Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 2/5] KVM: selftests: Put command line options in alphabetical order " Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 3/5] KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi() Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 4/5] KVM: selftests: Add atoi_positive() and atoi_non_negative() for input validation Vipin Sharma
2022-10-10 22:05 ` [PATCH v5 5/5] KVM: selftests: Run dirty_log_perf_test on specific CPUs Vipin Sharma
2022-10-20 21:42 ` Sean Christopherson
2022-10-20 21:44 ` Sean Christopherson
2022-10-14 15:12 ` [PATCH v5 0/5] dirty_log_perf_test vCPU pinning Wang, Wei W
2022-10-14 15:16 ` Wang, Wei W
2022-10-14 16:34 ` Sean Christopherson
2022-10-14 16:55 ` David Matlack
2022-10-14 18:26 ` Vipin Sharma
2022-10-14 19:02 ` Sean Christopherson
2022-10-14 21:21 ` Vipin Sharma
2022-10-17 0:47 ` Wang, Wei W
2022-10-20 21:46 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1HBxL0frhyK3qhx@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.