From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD26CC4332F for ; Fri, 21 Oct 2022 09:37:31 +0000 (UTC) Received: from localhost ([::1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oloSy-0008Mi-7g for qemu-devel@archiver.kernel.org; Fri, 21 Oct 2022 05:37:26 -0400 Received: from [::1] (helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oloHj-0001rG-AO for qemu-devel@archiver.kernel.org; Fri, 21 Oct 2022 05:25:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oloHc-0001KL-C0 for qemu-devel@nongnu.org; Fri, 21 Oct 2022 05:25:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oloHa-00056Z-VI for qemu-devel@nongnu.org; Fri, 21 Oct 2022 05:25:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1666344338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VaQGscKtgUp3nraZrmMcM0BHS2JrPYu9HBDwy1VHC3w=; b=HSk1deG4v4l188e8AzRLdFV+vsVE6OHAQAfrEyNTn5nn6ukTvQ2Ro6xNFBraJCtEM9YEHw 9fJHBvp+PDAg2McezbGY6hFkNY0vl+6n6uj4FEP4vbbMGE1PaD2Pgl7ivPWSaXmPk064JM m/8QaDqTwU+Ev4QvVA9qQTb1jtqames= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-82-snajutpmPkmx07O951NcVA-1; Fri, 21 Oct 2022 05:25:33 -0400 X-MC-Unique: snajutpmPkmx07O951NcVA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 909051C05B0F; Fri, 21 Oct 2022 09:25:33 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 75AAA2166B2D; Fri, 21 Oct 2022 09:25:32 +0000 (UTC) Date: Fri, 21 Oct 2022 11:25:31 +0200 From: Kevin Wolf To: Bin Meng Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Daniel P =?iso-8859-1?Q?=2E_Berrang=E9?= , Markus Armbruster , Hanna Reitz , qemu-block@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH v6 1/2] block: Ignore close() failure in get_tmp_filename() Message-ID: References: <20221010040432.3380478-1-bin.meng@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221010040432.3380478-1-bin.meng@windriver.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 10.10.2022 um 06:04 hat Bin Meng geschrieben: > The temporary file has been created and is ready for use. Checking > return value of close() does not seem useful. The file descriptor > is almost certainly closed; see close(2) under "Dealing with error > returns from close()". > > Let's simply ignore close() failure here. > > Suggested-by: Markus Armbruster > Signed-off-by: Bin Meng > Reviewed-by: Markus Armbruster Thanks, series applied to the block branch. Kevin