From: Jason Gunthorpe <jgg@nvidia.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH v3 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c
Date: Fri, 21 Oct 2022 16:39:13 -0300 [thread overview]
Message-ID: <Y1L1Yd7DfyosjbTg@nvidia.com> (raw)
In-Reply-To: <Y05CW7nYgVN53I1+@infradead.org>
On Mon, Oct 17, 2022 at 11:06:19PM -0700, Christoph Hellwig wrote:
> > + switch (op.op) {
> > + case VFIO_EEH_PE_DISABLE:
> > + ret = eeh_pe_set_option(pe, EEH_OPT_DISABLE);
> > + break;
> > + case VFIO_EEH_PE_ENABLE:
> > + ret = eeh_pe_set_option(pe, EEH_OPT_ENABLE);
> > + break;
>
> This could be simplified a bit more by moving the return from the
> end of the function into the switch statements.
Yes, all the rets can go away
> > - * Copyright Gavin Shan, IBM Corporation 2014.
>
> This notice needs to move over to vfio_iommu_spapr_tce.c.
Ok
Thanks,
Jason
next prev parent reply other threads:[~2022-10-21 19:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 18:38 [PATCH v3 0/5] Simplify the module and kconfig structure in vfio Jason Gunthorpe
2022-10-17 18:38 ` [PATCH v3 1/5] vfio/pci: Move all the SPAPR PCI specific logic to vfio_pci_core.ko Jason Gunthorpe
2022-10-18 6:03 ` Christoph Hellwig
2022-10-17 18:38 ` [PATCH v3 2/5] vfio/spapr: Move VFIO_CHECK_EXTENSION into tce_iommu_ioctl() Jason Gunthorpe
2022-10-18 6:03 ` Christoph Hellwig
2022-10-18 16:42 ` Philippe Mathieu-Daudé
2022-10-17 18:38 ` [PATCH v3 3/5] vfio: Move vfio_spapr_iommu_eeh_ioctl into vfio_iommu_spapr_tce.c Jason Gunthorpe
2022-10-18 6:06 ` Christoph Hellwig
2022-10-21 19:39 ` Jason Gunthorpe [this message]
2022-10-17 18:38 ` [PATCH v3 4/5] vfio: Remove CONFIG_VFIO_SPAPR_EEH Jason Gunthorpe
2022-10-18 6:08 ` Christoph Hellwig
2022-10-18 6:08 ` Christoph Hellwig
2022-10-21 19:46 ` Jason Gunthorpe
2022-10-21 19:46 ` Jason Gunthorpe
2022-10-17 18:38 ` [PATCH v3 5/5] vfio: Fold vfio_virqfd.ko into vfio.ko Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1L1Yd7DfyosjbTg@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=hch@infradead.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.