From: Sean Christopherson <seanjc@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH v2] x86: Add tests for Guest Processor Event Based Sampling (PEBS)
Date: Fri, 21 Oct 2022 18:51:56 +0000 [thread overview]
Message-ID: <Y1LqTKrJhDOS7pcm@google.com> (raw)
In-Reply-To: <fe9d582b-aae0-d219-863a-dbdca988e1d6@gmail.com>
On Tue, Oct 18, 2022, Like Xu wrote:
> Most of the comments will be addressed in the next version.
>
> On 6/10/2022 3:14 am, Sean Christopherson wrote:
> > On Thu, Jul 28, 2022, Like Xu wrote:
> > > +#include "vm.h"
> > > +#include "types.h"
> > > +#include "processor.h"
> > > +#include "vmalloc.h"
> > > +#include "alloc_page.h"
> > > +
> > > +#define PC_VECTOR 32
> >
> > PC?
>
> Part of legacy code, may be "performance counter vector" ?
Ah, it comes from the LVT Performance Counter Register".
> It will be reused in the new lib/pmu.h.
Any objection to renaming it to PMI_VECTOR? That's much more familiar for KVM
developers and it's still correct, e.g. it's the PMI vector that's programmed into
the LVT PC register.
prev parent reply other threads:[~2022-10-21 18:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 11:21 [kvm-unit-tests PATCH v2] x86: Add tests for Guest Processor Event Based Sampling (PEBS) Like Xu
2022-10-05 19:14 ` Sean Christopherson
2022-10-18 9:01 ` Like Xu
2022-10-21 18:51 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1LqTKrJhDOS7pcm@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.