From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1om5Zy-00004t-HP for mharc-grub-devel@gnu.org; Fri, 21 Oct 2022 23:53:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1om5Zv-0008WQ-6e for grub-devel@gnu.org; Fri, 21 Oct 2022 23:53:43 -0400 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1om5Zt-0007iM-HR for grub-devel@gnu.org; Fri, 21 Oct 2022 23:53:42 -0400 Received: by mail-pg1-x530.google.com with SMTP id s196so4211744pgs.3 for ; Fri, 21 Oct 2022 20:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OJ3ihIRL9MraIVj9GE5SrhQO6XWcgV8rR2mvmSML20E=; b=QxzZKKIpfaY6qBU4kQ+KTqHvuXrEFztvWHqr2EZSQA2VzukverFpOVy5ZrjBIiIA7b lUsVla6Iyns0/9rRL+TkBEHq4+xGWveC6PFCR+MS+1hkn50dVdy74BqRJW1Ef3u28FU1 RyHm7cDABG12QKbLaAx4DSrPWuzUOurTmoF+qzg85xIGRjiXfvM28JLer7tR8ajmjl77 sjwqtjXMTAZ7522MAj5dXpRR4V59vcdTVP6n4iUEcCMY+PnTzE90STLJtWBryjhS5pHG gy/w0RCrrRBawYjwif/AzcpnPPDWpkYdoexKoOs7gngl5b6vXS+8UeijuBgdl0vOLiT8 PYqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OJ3ihIRL9MraIVj9GE5SrhQO6XWcgV8rR2mvmSML20E=; b=NH+gvT2LYoX0yQuwuOrMEJv1q90opWlASfu1jXSPxwSZHyX/9r49+T06SW9rQ0KQEG rOznmtFzVNdmYgXCsyVsyZxLKE7Q9AuLvcR5/mOv0H5soJn7yZA9gZ0XZUUHR6pL88Ma 3nSTD3u7U0szGS1noNgCXTMb5qX8hriiqKpu+zVthmjGYvcas6H+aJWmBWRTq1TAEFEn lEPxuH5qEtPE08PUu40fF/ZaCd9Z1RR50NGcx/SIWDjLgULPaugWfnJyBJVAOHOnc+Lc 5I5EBSV3O587h4qYOpc5LwS7ITrDKHL8SJX4R7n6GJFG4ua5211NEYv10gnomzcQ2jUw 0tdw== X-Gm-Message-State: ACrzQf27JwJT9lAOmmOaxM7k+TOvVTuBxaj9cC+jnoD2KSm5zdKciNu+ PxpyhN458ifL3e+k5UjPvd4= X-Google-Smtp-Source: AMsMyM42y17bWkB/OFdTCrRm2xJDaYzraXMJRGfoX6jL/pbSMEDC528hQBUz2iqOxlgqLU8GmLUu3A== X-Received: by 2002:a63:6c07:0:b0:457:523c:4bd0 with SMTP id h7-20020a636c07000000b00457523c4bd0mr18881225pgc.101.1666410819578; Fri, 21 Oct 2022 20:53:39 -0700 (PDT) Received: from generichostname (136-25-1-99.cab.webpass.net. [136.25.1.99]) by smtp.gmail.com with ESMTPSA id p184-20020a625bc1000000b005618189b0ffsm15930477pfb.104.2022.10.21.20.53.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Oct 2022 20:53:38 -0700 (PDT) Date: Fri, 21 Oct 2022 20:53:36 -0700 From: Denton Liu To: Olaf Hering Cc: grub-devel@gnu.org, Daniel Kiper , Oskari Pirhonen , mathieu.desnoyers@efficios.com, rharwood@redhat.com, samuel.thibault@ens-lyon.org, debian-bsd@lists.debian.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v4] templates: introduce GRUB_TOP_LEVEL_* vars Message-ID: References: <20221017103532.845293-1-liu.denton@gmail.com> <20221018131235.5e70f0bc.olaf@aepfle.de> <20221018161821.149ee6fd.olaf@aepfle.de> <20221020171306.45c275f9.olaf@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221020171306.45c275f9.olaf@aepfle.de> Received-SPF: pass client-ip=2607:f8b0:4864:20::530; envelope-from=liu.denton@gmail.com; helo=mail-pg1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2022 03:53:43 -0000 Hi Olaf, On Thu, Oct 20, 2022 at 05:13:06PM +0200, Olaf Hering wrote: > After reading the patch again, the newly added documentation states: > "This option should be a path to a kernel image." > > I think it needs to be more specific: is it expecting an absolute path, or just the basename of the desired image? Thanks for the feedback, it should be an absolute path. I can submit a new version of the patch later. However, before I do so, are you still a NAK on the general idea? -Denton