All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	johannes@sipsolutions.net
Subject: Re: [PATCH -next] rfkill: replace BUG_ON() with WARN_ON() in core.c
Date: Sun, 23 Oct 2022 11:16:41 +0300	[thread overview]
Message-ID: <Y1T4aWIbueaf4jYM@unreal> (raw)
In-Reply-To: <20221021135738.524370-1-yangyingliang@huawei.com>

On Fri, Oct 21, 2022 at 09:57:38PM +0800, Yang Yingliang wrote:
> Replace BUG_ON() with WARN_ON() to handle fault more gracefully.
> 
> Suggested-by: Johannes Berg <johannes@sipsolutions.net>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  net/rfkill/core.c | 25 ++++++++++++++++---------
>  1 file changed, 16 insertions(+), 9 deletions(-)

Please add changelog and version numbers when you set your series.

The same comment as https://lore.kernel.org/all/Y1T3a1y/pWdbt2ow@unreal
or you should delete BUG_ONs completely or simply replace them with WARN_ONs.

There is no need in all these if (...).

Thanks

  reply	other threads:[~2022-10-23  8:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-21 13:57 [PATCH -next] rfkill: replace BUG_ON() with WARN_ON() in core.c Yang Yingliang
2022-10-23  8:16 ` Leon Romanovsky [this message]
2022-10-24  1:58   ` Yang Yingliang
2022-10-24  8:32     ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1T4aWIbueaf4jYM@unreal \
    --to=leon@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.