From: Bagas Sanjaya <bagasdotme@gmail.com>
To: wangjianli <wangjianli@cdjrlc.com>
Cc: mathew.j.martineau@linux.intel.com, matthieu.baerts@tessares.net,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mptcp: fix repeated words in comments
Date: Sun, 23 Oct 2022 20:47:00 +0700 [thread overview]
Message-ID: <Y1VF1DBYePbkTk8x@debian.me> (raw)
In-Reply-To: <20221022070527.55960-1-wangjianli@cdjrlc.com>
[-- Attachment #1: Type: text/plain, Size: 1616 bytes --]
On Sat, Oct 22, 2022 at 03:05:27PM +0800, wangjianli wrote:
> Delete the redundant word 'the'.
>
> Signed-off-by: wangjianli <wangjianli@cdjrlc.com>
> ---
> net/mptcp/token.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/mptcp/token.c b/net/mptcp/token.c
> index f52ee7b26aed..b817c2564300 100644
> --- a/net/mptcp/token.c
> +++ b/net/mptcp/token.c
> @@ -287,7 +287,7 @@ EXPORT_SYMBOL_GPL(mptcp_token_get_sock);
> * This function returns the first mptcp connection structure found inside the
> * token container starting from the specified position, or NULL.
> *
> - * On successful iteration, the iterator is move to the next position and the
> + * On successful iteration, the iterator is move to the next position and
> * the acquires a reference to the returned socket.
> */
> struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
NAK!
Instead, slightly reword the comment above as "On successful iteration,
the iterator moves to the next position and acquires a reference to the
returned socket.".
Also, you and other @cdjrlc.com developers ignore reviews that request
changes to your patches. If you want to participate in kernel
development community, please don't just sending random patches without
any sort of reply.
I have pointed out this behavior either as part of my review or as reply
to reviews from other developers. I may write this as final warning before
I just say NAK without further ado to your future patches.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2022-10-23 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-22 7:05 [PATCH] net/mptcp: fix repeated words in comments wangjianli
2022-10-22 9:10 ` net/mptcp: fix repeated words in comments: Tests Results MPTCP CI
2022-10-23 13:47 ` Bagas Sanjaya [this message]
2022-10-24 22:04 ` [PATCH] net/mptcp: fix repeated words in comments Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1VF1DBYePbkTk8x@debian.me \
--to=bagasdotme@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wangjianli@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.