From: Greg KH <gregkh@linuxfoundation.org>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Deepak R Varma <drv@mailo.com>,
outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: wlan-ng: remove commented debug printk messages
Date: Mon, 24 Oct 2022 06:08:42 +0200 [thread overview]
Message-ID: <Y1YPypVbN5v18uni@kroah.com> (raw)
In-Reply-To: <4863c6d7-ffdd-1304-981b-9b0644a87f4e@gmail.com>
On Mon, Oct 24, 2022 at 10:08:00AM +0700, Bagas Sanjaya wrote:
> On 10/23/22 21:13, Greg KH wrote:
> >>> @@ -1007,7 +986,6 @@ static int p80211_rx_typedrop(struct wlandevice *wlandev, u16 fc)
> >>> wlandev->rx.cfack_cfpoll++;
> >>> break;
> >>> default:
> >>> - /* printk("unknown"); */
> >>> wlandev->rx.data_unknown++;
> >>> break;
> >>> }
> >>
> >> Shouldn't these printks be guarded under CONFIG_DEBUG_KERNEL instead?
> >
> > No, they should just be removed as was done here.
> >
>
> What if in case of debugging without these printks?
I can not parse this line, sorry.
next prev parent reply other threads:[~2022-10-24 4:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 19:33 [PATCH v2] staging: wlan-ng: remove commented debug printk messages Deepak R Varma
2022-10-23 13:35 ` Bagas Sanjaya
2022-10-21 22:40 ` Deepak R Varma
2022-10-24 3:10 ` Bagas Sanjaya
2022-10-23 14:13 ` Greg KH
2022-10-24 3:08 ` Bagas Sanjaya
2022-10-24 4:08 ` Greg KH [this message]
2022-10-24 9:29 ` Bagas Sanjaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1YPypVbN5v18uni@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bagasdotme@gmail.com \
--cc=drv@mailo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.