From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFB15FA373E for ; Mon, 24 Oct 2022 14:21:58 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Mwy1x2VF1z3bjd for ; Tue, 25 Oct 2022 01:21:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=YUEP9XyI; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::72d; helo=mail-qk1-x72d.google.com; envelope-from=tcminyard@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=YUEP9XyI; dkim-atps=neutral Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Mwy0q3CfZz2xKV for ; Tue, 25 Oct 2022 01:20:57 +1100 (AEDT) Received: by mail-qk1-x72d.google.com with SMTP id f8so6142200qkg.3 for ; Mon, 24 Oct 2022 07:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=snHhLpRnzMiuF/FkUzYYR4DW/a0NGNwApchz9Ej8VRU=; b=YUEP9XyILJspEjolrjqp2Z9GjGMOMTrP45EmxEXsZljfkkiRMJwaEfnshgsJfs8X7M KNgjsXqTJhQmhXRI0AaougoHAd1ZM5MiWxlHgU+f83ikUw0WIaE3xD0cU+/ICFuviutI UJybqMEFZMf18o+q3wwUtI9WhD34rpMrCVBhcSmx57RZ817mZdAPNb+TaZE1IZTtVnfc J13VQwN6Gk7ZemBPqfi8E/tAo+RfA+q8XHsf4hBGrvHN/lBiR+F+CGw1SWxmvIaiCsec /9nmLcA7UkmseebRG5d3ZSiAUd+x0xYiFAU0DNreRXfO+w3UcrZtidnRR9zNPUXAXshz KjyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=snHhLpRnzMiuF/FkUzYYR4DW/a0NGNwApchz9Ej8VRU=; b=tggLyS5RTEQ+tcwm/HHcTWXJpd6/02oGWLUczNMXZVbmnPguWEAwaGNNPzWlhFTXOe Mj0ctJs0Ti1K66fB5ih6CeMyIeRgTpMiEBPY/hv14cwHhSFdWkRSuUJUUG/GJHC2CUkq 66OJvewQ7pM752mKvZFX12PJecd8wynn6LnYzbnhoxv+UT3sMztJEBcQDy2aH05xSx7K 9i2EFxw49K0ZFvTDTJ6Ijhzsa40lCgsIC2l3Lc4b4AUH7eArgDpkrclfPV/TdM3dHMS0 JHunbsOf5oABvN4KPtK4aFO7uitrrVKFLIToFvRYkzibuUS6qOhe8fFpQwPtGf6pGX+E QTGw== X-Gm-Message-State: ACrzQf1cvGZABP8OWM39oAr3HOXlqQoZegZ0miDBPAoJtV0O28JjtHZs wCeEKWl9gaRIT7Y6yFMfFA== X-Google-Smtp-Source: AMsMyM4x20N5g0CnTk189WOms1Rpbivdne8Eg7opnisvbRX7j+9LVguQi1ENkMDNfK6SBGQThtJoxA== X-Received: by 2002:a05:620a:12ac:b0:6ec:55bf:1d79 with SMTP id x12-20020a05620a12ac00b006ec55bf1d79mr22630933qki.598.1666621252246; Mon, 24 Oct 2022 07:20:52 -0700 (PDT) Received: from serve.minyard.net ([47.184.185.126]) by smtp.gmail.com with ESMTPSA id k11-20020a05620a414b00b006ce9e880c6fsm4141qko.111.2022.10.24.07.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 07:20:51 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:8f12:af97:5f5:1273]) by serve.minyard.net (Postfix) with ESMTPSA id 9F91E180044; Mon, 24 Oct 2022 14:20:49 +0000 (UTC) Date: Mon, 24 Oct 2022 09:20:48 -0500 From: Corey Minyard To: Quan Nguyen Subject: Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN Message-ID: References: <20221024075956.3312552-1-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024075956.3312552-1-quan@os.amperecomputing.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: kernel test robot , Andrew Jeffery , openbmc@lists.ozlabs.org, thang@os.amperecomputing.com, linux-kernel@vger.kernel.org, Phong Vo , Joel Stanley , Open Source Submission , openipmi-developer@lists.sourceforge.net Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote: > This fixes the following sparse warning: > sparse warnings: (new ones prefixed by >>) > >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |= > >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: left side has type restricted __poll_t > >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: right side has type int Thanks, you beat me to tracing this down. It's in my for-next queue. -corey > > Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") > Reported-by: kernel test robot > Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/ > Signed-off-by: Quan Nguyen > --- > drivers/char/ipmi/ssif_bmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > index a7bb4b99000e..2d8069386398 100644 > --- a/drivers/char/ipmi/ssif_bmc.c > +++ b/drivers/char/ipmi/ssif_bmc.c > @@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait) > spin_lock_irq(&ssif_bmc->lock); > /* The request is available, userspace application can get the request */ > if (ssif_bmc->request_available) > - mask |= POLLIN; > + mask |= EPOLLIN; > > spin_unlock_irq(&ssif_bmc->lock); > > -- > 2.35.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CD7C38A2D for ; Mon, 24 Oct 2022 16:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232360AbiJXQBC (ORCPT ); Mon, 24 Oct 2022 12:01:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232542AbiJXP7I (ORCPT ); Mon, 24 Oct 2022 11:59:08 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01159FC1C7 for ; Mon, 24 Oct 2022 07:54:19 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id w3so5721611qtv.9 for ; Mon, 24 Oct 2022 07:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=snHhLpRnzMiuF/FkUzYYR4DW/a0NGNwApchz9Ej8VRU=; b=YUEP9XyILJspEjolrjqp2Z9GjGMOMTrP45EmxEXsZljfkkiRMJwaEfnshgsJfs8X7M KNgjsXqTJhQmhXRI0AaougoHAd1ZM5MiWxlHgU+f83ikUw0WIaE3xD0cU+/ICFuviutI UJybqMEFZMf18o+q3wwUtI9WhD34rpMrCVBhcSmx57RZ817mZdAPNb+TaZE1IZTtVnfc J13VQwN6Gk7ZemBPqfi8E/tAo+RfA+q8XHsf4hBGrvHN/lBiR+F+CGw1SWxmvIaiCsec /9nmLcA7UkmseebRG5d3ZSiAUd+x0xYiFAU0DNreRXfO+w3UcrZtidnRR9zNPUXAXshz KjyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=snHhLpRnzMiuF/FkUzYYR4DW/a0NGNwApchz9Ej8VRU=; b=uXsWvi9DxPYg4MKmjSvEgkYrlq25wINakm6nIS8XfgOuvQ/kJK3cxWSTmEqxCnTeIe JsX0VWnRheuwIKmHqU3FSj0aeEhU2FoqzMEaCerKNr/Jcjl18VV4CZZJmYJxB1WhBOkv gHhUsS0DrRZwdTpTq1vB3+5GOla+XiVnxsa0UcSviWo3SN8MsbaziUVcpyEJ5WK3n7DD E3uXJzaLeIevhWJ4XXUO35icU0CHo+vAaa4kY63wOsHwBrmR7+Oo6+GJqnfq9OK/Ki7x QHVAItsapuT72SgTnFtneKNVQsf2K2G9WDjo8Aj+MURX8OEe4va5JppCWlgl+qXc3BKa 3nsw== X-Gm-Message-State: ACrzQf2RgZdqSKM3Q3Kjq8arEO94WcbInsRneMLBb5IkC891EtVtautQ 3NpnTOkrnFbIBSdcOkpZfsjWZH8pSg== X-Google-Smtp-Source: AMsMyM4x20N5g0CnTk189WOms1Rpbivdne8Eg7opnisvbRX7j+9LVguQi1ENkMDNfK6SBGQThtJoxA== X-Received: by 2002:a05:620a:12ac:b0:6ec:55bf:1d79 with SMTP id x12-20020a05620a12ac00b006ec55bf1d79mr22630933qki.598.1666621252246; Mon, 24 Oct 2022 07:20:52 -0700 (PDT) Received: from serve.minyard.net ([47.184.185.126]) by smtp.gmail.com with ESMTPSA id k11-20020a05620a414b00b006ce9e880c6fsm4141qko.111.2022.10.24.07.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 07:20:51 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:8f12:af97:5f5:1273]) by serve.minyard.net (Postfix) with ESMTPSA id 9F91E180044; Mon, 24 Oct 2022 14:20:49 +0000 (UTC) Date: Mon, 24 Oct 2022 09:20:48 -0500 From: Corey Minyard To: Quan Nguyen Cc: Open Source Submission , Joel Stanley , Andrew Jeffery , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, Phong Vo , thang@os.amperecomputing.com, kernel test robot Subject: Re: [PATCH] ipmi: ssif_bmc: Use EPOLLIN instead of POLLIN Message-ID: Reply-To: minyard@acm.org References: <20221024075956.3312552-1-quan@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024075956.3312552-1-quan@os.amperecomputing.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 24, 2022 at 02:59:56PM +0700, Quan Nguyen wrote: > This fixes the following sparse warning: > sparse warnings: (new ones prefixed by >>) > >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: sparse: invalid assignment: |= > >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: left side has type restricted __poll_t > >> drivers/char/ipmi/ssif_bmc.c:254:22: sparse: right side has type int Thanks, you beat me to tracing this down. It's in my for-next queue. -corey > > Fixes: dd2bc5cc9e25 ("ipmi: ssif_bmc: Add SSIF BMC driver") > Reported-by: kernel test robot > Link: https://lore.kernel.org/all/202210181103.ontD9tRT-lkp@intel.com/ > Signed-off-by: Quan Nguyen > --- > drivers/char/ipmi/ssif_bmc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > index a7bb4b99000e..2d8069386398 100644 > --- a/drivers/char/ipmi/ssif_bmc.c > +++ b/drivers/char/ipmi/ssif_bmc.c > @@ -251,7 +251,7 @@ static __poll_t ssif_bmc_poll(struct file *file, poll_table *wait) > spin_lock_irq(&ssif_bmc->lock); > /* The request is available, userspace application can get the request */ > if (ssif_bmc->request_available) > - mask |= POLLIN; > + mask |= EPOLLIN; > > spin_unlock_irq(&ssif_bmc->lock); > > -- > 2.35.1 >