From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39535C38A2D for ; Mon, 24 Oct 2022 14:57:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BrxfrDUbPsUFpThWqA9RSxt3bESyLFU8TgRiCKoKos4=; b=JTDsxtmGirwz+jb6TqiO9jdfnm SEXuVOaAXr/e8ddYir9tEl2i77f8fprWa3zptCTrnVt5wdWIU6zJov0IpYYLKei4p3lC3ByNL0Cm9 BnOaX3rvAuubzY9FkA5V5SgiHEEoVPJLfnxbiKE5Eri1VF83Mab3HAy5e2adD4kYw0j5b9HZZavC1 VTtyVr00YN44Kv5WBGEhYW9hsZcPdAiYAUncgl0zkn8NcRev0OD70wRgzciJbiHwNSBrLGOm4DrDU VRXm90PqPfYuTxLoZDl9G1fRjtzkpoAK79EEZrPGOOwRNQuwmt/lTS5om5CjXdfL8rr9uDtdblJij kQMIJCqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omytM-0020lt-K6; Mon, 24 Oct 2022 14:57:28 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omytB-0020ge-Nv; Mon, 24 Oct 2022 14:57:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BrxfrDUbPsUFpThWqA9RSxt3bESyLFU8TgRiCKoKos4=; b=hUFyDn4iEM2Umosu5AGmbJVVWt Gd8sS4dlaaccEMpfxIA+FTJfDLsCW3BaDAKG3WhFItnfHCxaubrTdZcHF8xD8CMyGl3OmKYss13IE cf7PvX1v+ed7wIBYbKJjEjVdhn9MaeL34ZUWWMpOrhVUUo9bZHo4GVCsmH33ynRef9Y1jXHk6l4fg G8iouAdGGN7jn0NThsBLmMWXfD+Xc0Zq7a7DnyNRFXx9xAcR78IQiUioEthdkXoKBCJEAQ2fpzM3Y CHABnGcBjLNwmN00otsMN4Yv0UHBCNvxhe1dp3ZPOwFbs7nuc1SQJMrsZ+/bVPXsQK4n67mIGfEfg ncRzNHSA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34932) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1omysw-0003Fd-7H; Mon, 24 Oct 2022 15:57:02 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1omysk-0007DB-GY; Mon, 24 Oct 2022 15:56:50 +0100 Date: Mon, 24 Oct 2022 15:56:50 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: Re: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_075717_801763_BAE7200F X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Oct 24, 2022 at 04:45:40PM +0200, Frank Wunderlich wrote: > Hi > > Gesendet: Montag, 24. Oktober 2022 um 11:27 Uhr > > Von: "Russell King (Oracle)" > > > Here's the combined patch for where I would like mtk_sgmii to get to. > > > > It looks like this PCS is similar to what we know as pcs-lynx.c, but > > there do seem to be differences - the duplex bit for example appears > > to be inverted. > > > > Please confirm whether this still works for you, thanks. > > basicly Patch works, but i get some (1-50) retransmitts on iperf3 on first interval in tx-mode (on r3 without -R), other 9 are clean. reverse mode is mostly clean. > run iperf3 multiple times, every first interval has retransmitts. same for gmac0 (fixed-link 2500baseX) > > i notice that you have changed the timer again to 10000000 for 1000/2500baseX...maybe use here the default value too like the older code does? You obviously missed my explanation. I will instead quote the 802.3 standard which covers 1000base-X: 37.3.1.4 Timers link_timer Timer used to ensure Auto-Negotiation protocol stability and register read/write by the management interface. Duration: 10 ms, tolerance +10 ms, –0 s. For SGMII, the situation is different. Here is what the SGMII specification says: The link_timer inside the Auto-Negotiation has been changed from 10 msec to 1.6 msec to ensure a prompt update of the link status. So, 10ms is correct for 1000base-X, and 1.6ms correct for SGMII. However, feel free to check whether changing it solves that issue, but also check whether it could be some ARP related issue - remember, if two endpoints haven't communicated, they need to ARP to get the other end's ethernet addresses which adds extra latency, and may result in some packet loss in high packet queuing rate situations. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FDFCECAAA1 for ; Mon, 24 Oct 2022 14:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pwHoqaiT9PK9imzf1taiLTnRDtfqjAq8D2S1rziAAKM=; b=Zo4jjuQzwppyFI 9+NiOk5qOJOICFqEfhMqZOXbqFD2MbZtq5n7XcjV0OqxinC+H2dftAJF4ua/A8/gXyKpz9iOoc5cN cbVFTVXEj1nhmDtV8I+/P/Avf+nW4ZRaad8TpnGcJ67zEJhXeu+GtQvjaVsUcL3HS+7kvZzj/9L6F pHhXXbBBqh+ZjJYvgutKtBamIoPimTqiKIL8YWnyvuTIUtYLZ48DSZIYkkMowhfYxIFHuRIBOFLCS JBT5RM5ooo2Hug5UUknMFSjlzgic7TmhmUfsPshxVj3Hsr63q3VPvNEJ+vtlP9/80UZpdGcCgCP+T +uw0o4SBDsIjT009UeNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1omytO-0020mP-JS; Mon, 24 Oct 2022 14:57:30 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1omytB-0020ge-Nv; Mon, 24 Oct 2022 14:57:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BrxfrDUbPsUFpThWqA9RSxt3bESyLFU8TgRiCKoKos4=; b=hUFyDn4iEM2Umosu5AGmbJVVWt Gd8sS4dlaaccEMpfxIA+FTJfDLsCW3BaDAKG3WhFItnfHCxaubrTdZcHF8xD8CMyGl3OmKYss13IE cf7PvX1v+ed7wIBYbKJjEjVdhn9MaeL34ZUWWMpOrhVUUo9bZHo4GVCsmH33ynRef9Y1jXHk6l4fg G8iouAdGGN7jn0NThsBLmMWXfD+Xc0Zq7a7DnyNRFXx9xAcR78IQiUioEthdkXoKBCJEAQ2fpzM3Y CHABnGcBjLNwmN00otsMN4Yv0UHBCNvxhe1dp3ZPOwFbs7nuc1SQJMrsZ+/bVPXsQK4n67mIGfEfg ncRzNHSA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34932) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1omysw-0003Fd-7H; Mon, 24 Oct 2022 15:57:02 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1omysk-0007DB-GY; Mon, 24 Oct 2022 15:56:50 +0100 Date: Mon, 24 Oct 2022 15:56:50 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: Re: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_075717_801763_BAE7200F X-CRM114-Status: GOOD ( 19.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBPY3QgMjQsIDIwMjIgYXQgMDQ6NDU6NDBQTSArMDIwMCwgRnJhbmsgV3VuZGVybGlj aCB3cm90ZToKPiBIaQo+ID4gR2VzZW5kZXQ6IE1vbnRhZywgMjQuIE9rdG9iZXIgMjAyMiB1bSAx MToyNyBVaHIKPiA+IFZvbjogIlJ1c3NlbGwgS2luZyAoT3JhY2xlKSIgPGxpbnV4QGFybWxpbnV4 Lm9yZy51az4KPiAKPiA+IEhlcmUncyB0aGUgY29tYmluZWQgcGF0Y2ggZm9yIHdoZXJlIEkgd291 bGQgbGlrZSBtdGtfc2dtaWkgdG8gZ2V0IHRvLgo+ID4KPiA+IEl0IGxvb2tzIGxpa2UgdGhpcyBQ Q1MgaXMgc2ltaWxhciB0byB3aGF0IHdlIGtub3cgYXMgcGNzLWx5bnguYywgYnV0Cj4gPiB0aGVy ZSBkbyBzZWVtIHRvIGJlIGRpZmZlcmVuY2VzIC0gdGhlIGR1cGxleCBiaXQgZm9yIGV4YW1wbGUg YXBwZWFycwo+ID4gdG8gYmUgaW52ZXJ0ZWQuCj4gPgo+ID4gUGxlYXNlIGNvbmZpcm0gd2hldGhl ciB0aGlzIHN0aWxsIHdvcmtzIGZvciB5b3UsIHRoYW5rcy4KPiAKPiBiYXNpY2x5IFBhdGNoIHdv cmtzLCBidXQgaSBnZXQgc29tZSAoMS01MCkgcmV0cmFuc21pdHRzIG9uIGlwZXJmMyBvbiBmaXJz dCBpbnRlcnZhbCBpbiB0eC1tb2RlIChvbiByMyB3aXRob3V0IC1SKSwgb3RoZXIgOSBhcmUgY2xl YW4uIHJldmVyc2UgbW9kZSBpcyBtb3N0bHkgY2xlYW4uCj4gcnVuIGlwZXJmMyBtdWx0aXBsZSB0 aW1lcywgZXZlcnkgZmlyc3QgaW50ZXJ2YWwgaGFzIHJldHJhbnNtaXR0cy4gc2FtZSBmb3IgZ21h YzAgKGZpeGVkLWxpbmsgMjUwMGJhc2VYKQo+IAo+IGkgbm90aWNlIHRoYXQgeW91IGhhdmUgY2hh bmdlZCB0aGUgdGltZXIgYWdhaW4gdG8gMTAwMDAwMDAgZm9yIDEwMDAvMjUwMGJhc2VYLi4ubWF5 YmUgdXNlIGhlcmUgdGhlIGRlZmF1bHQgdmFsdWUgdG9vIGxpa2UgdGhlIG9sZGVyIGNvZGUgZG9l cz8KCllvdSBvYnZpb3VzbHkgbWlzc2VkIG15IGV4cGxhbmF0aW9uLiBJIHdpbGwgaW5zdGVhZCBx dW90ZSB0aGUgODAyLjMKc3RhbmRhcmQgd2hpY2ggY292ZXJzIDEwMDBiYXNlLVg6CgozNy4zLjEu NCBUaW1lcnMKCiBsaW5rX3RpbWVyCiAgICAgICAgICBUaW1lciB1c2VkIHRvIGVuc3VyZSBBdXRv LU5lZ290aWF0aW9uIHByb3RvY29sIHN0YWJpbGl0eSBhbmQKCSAgcmVnaXN0ZXIgcmVhZC93cml0 ZSBieSB0aGUgbWFuYWdlbWVudCBpbnRlcmZhY2UuCgoJICBEdXJhdGlvbjogMTAgbXMsIHRvbGVy YW5jZSArMTAgbXMsIOKAkzAgcy4KCkZvciBTR01JSSwgdGhlIHNpdHVhdGlvbiBpcyBkaWZmZXJl bnQuIEhlcmUgaXMgd2hhdCB0aGUgU0dNSUkKc3BlY2lmaWNhdGlvbiBzYXlzOgoKICBUaGUgbGlu a190aW1lciBpbnNpZGUgdGhlIEF1dG8tTmVnb3RpYXRpb24gaGFzIGJlZW4gY2hhbmdlZCBmcm9t IDEwCiAgbXNlYyB0byAxLjYgbXNlYyB0byBlbnN1cmUgYSBwcm9tcHQgdXBkYXRlIG9mIHRoZSBs aW5rIHN0YXR1cy4KClNvLCAxMG1zIGlzIGNvcnJlY3QgZm9yIDEwMDBiYXNlLVgsIGFuZCAxLjZt cyBjb3JyZWN0IGZvciBTR01JSS4KCkhvd2V2ZXIsIGZlZWwgZnJlZSB0byBjaGVjayB3aGV0aGVy IGNoYW5naW5nIGl0IHNvbHZlcyB0aGF0IGlzc3VlLCBidXQKYWxzbyBjaGVjayB3aGV0aGVyIGl0 IGNvdWxkIGJlIHNvbWUgQVJQIHJlbGF0ZWQgaXNzdWUgLSByZW1lbWJlciwgaWYKdHdvIGVuZHBv aW50cyBoYXZlbid0IGNvbW11bmljYXRlZCwgdGhleSBuZWVkIHRvIEFSUCB0byBnZXQgdGhlIG90 aGVyCmVuZCdzIGV0aGVybmV0IGFkZHJlc3NlcyB3aGljaCBhZGRzIGV4dHJhIGxhdGVuY3ksIGFu ZCBtYXkgcmVzdWx0IGluCnNvbWUgcGFja2V0IGxvc3MgaW4gaGlnaCBwYWNrZXQgcXVldWluZyBy YXRlIHNpdHVhdGlvbnMuCgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwczovL3d3dy5hcm1s aW51eC5vcmcudWsvZGV2ZWxvcGVyL3BhdGNoZXMvCkZUVFAgaXMgaGVyZSEgNDBNYnBzIGRvd24g MTBNYnBzIHVwLiBEZWNlbnQgY29ubmVjdGl2aXR5IGF0IGxhc3QhCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==