From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F084C04A95 for ; Tue, 25 Oct 2022 12:09:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 3ED86388F; Tue, 25 Oct 2022 14:08:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 3ED86388F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1666699778; bh=KmeNx/YuQK06nE4d9J6l/1x675LkOaFX9FaQesFcRHg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=P+Xf2BAOSIIR62BxAJdnbmlZRSVWZ04JIFwXhBGyaxZdIboX52gcPQSHNs0o4XLgz /dfGzcGws6fN/9q2wFDECHmELzO8usX0u2qfaZ5KfpjEN1RgJw8Rxb/IhVuFjy4oNw Tq/Z0u9Hw89JDwjZTcoYpA87fDSppLAa8kpiY4C4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CCC49F8042F; Tue, 25 Oct 2022 14:08:47 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7E7A1F80431; Tue, 25 Oct 2022 14:08:46 +0200 (CEST) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6AAEAF80240 for ; Tue, 25 Oct 2022 14:08:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6AAEAF80240 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="CrVd9HRe" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6F597B81CF1; Tue, 25 Oct 2022 12:08:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58B3AC433C1; Tue, 25 Oct 2022 12:08:37 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="CrVd9HRe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1666699714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lDTzz8RCtiO8TmkrYzfZqplpH5tp9ZvYdKoLxqYoZgw=; b=CrVd9HReLy5CSqBBbmToAhk3P2sFOIwgsfi2fIs9mP4dYkJ+WufkgyZDKGUwD12i4tZOqI 9O2TnmESRupj37Z7svdhOU26hAbpHpVOJkK+SvbYTYbi6d+nsG7bl2NnekwTTS6kHAtCSS 7LKKuLADDA5VyJ+JapFl8+33A33n+ag= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 74f0cab3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 25 Oct 2022 12:08:33 +0000 (UTC) Date: Tue, 25 Oct 2022 14:08:29 +0200 From: "Jason A. Donenfeld" To: Takashi Iwai Subject: Re: [PATCH v2] ALSA: rme9652: use explicitly signed char Message-ID: References: <202210250456.vKv5zoLb-lkp@intel.com> <20221025000313.546261-1-Jason@zx2c4.com> <87bkq0s9rw.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87bkq0s9rw.wl-tiwai@suse.de> Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, Oct 25, 2022 at 08:21:55AM +0200, Takashi Iwai wrote: > On Tue, 25 Oct 2022 02:03:13 +0200, > Jason A. Donenfeld wrote: > > > > With char becoming unsigned by default, and with `char` alone being > > ambiguous and based on architecture, signed chars need to be marked > > explicitly as such. This fixes warnings like: > > > > sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned > > sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)' > > sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned > > > > Cc: Jaroslav Kysela > > Cc: Takashi Iwai > > Cc: alsa-devel@alsa-project.org > > Signed-off-by: Jason A. Donenfeld > > Applied now. Thanks! Thanks. For this and the other patch, applied for 6.1 or 6.2? Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 371A1C38A2D for ; Tue, 25 Oct 2022 12:08:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbiJYMIl (ORCPT ); Tue, 25 Oct 2022 08:08:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbiJYMIj (ORCPT ); Tue, 25 Oct 2022 08:08:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F7CCEC531 for ; Tue, 25 Oct 2022 05:08:39 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B0CF4618F5 for ; Tue, 25 Oct 2022 12:08:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58B3AC433C1; Tue, 25 Oct 2022 12:08:37 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="CrVd9HRe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1666699714; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lDTzz8RCtiO8TmkrYzfZqplpH5tp9ZvYdKoLxqYoZgw=; b=CrVd9HReLy5CSqBBbmToAhk3P2sFOIwgsfi2fIs9mP4dYkJ+WufkgyZDKGUwD12i4tZOqI 9O2TnmESRupj37Z7svdhOU26hAbpHpVOJkK+SvbYTYbi6d+nsG7bl2NnekwTTS6kHAtCSS 7LKKuLADDA5VyJ+JapFl8+33A33n+ag= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 74f0cab3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 25 Oct 2022 12:08:33 +0000 (UTC) Date: Tue, 25 Oct 2022 14:08:29 +0200 From: "Jason A. Donenfeld" To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ALSA: rme9652: use explicitly signed char Message-ID: References: <202210250456.vKv5zoLb-lkp@intel.com> <20221025000313.546261-1-Jason@zx2c4.com> <87bkq0s9rw.wl-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87bkq0s9rw.wl-tiwai@suse.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 25, 2022 at 08:21:55AM +0200, Takashi Iwai wrote: > On Tue, 25 Oct 2022 02:03:13 +0200, > Jason A. Donenfeld wrote: > > > > With char becoming unsigned by default, and with `char` alone being > > ambiguous and based on architecture, signed chars need to be marked > > explicitly as such. This fixes warnings like: > > > > sound/pci/rme9652/hdsp.c:3953 hdsp_channel_buffer_location() warn: 'hdsp->channel_map[channel]' is unsigned > > sound/pci/rme9652/hdsp.c:4153 snd_hdsp_channel_info() warn: impossible condition '(hdsp->channel_map[channel] < 0) => (0-255 < 0)' > > sound/pci/rme9652/rme9652.c:1833 rme9652_channel_buffer_location() warn: 'rme9652->channel_map[channel]' is unsigned > > > > Cc: Jaroslav Kysela > > Cc: Takashi Iwai > > Cc: alsa-devel@alsa-project.org > > Signed-off-by: Jason A. Donenfeld > > Applied now. Thanks! Thanks. For this and the other patch, applied for 6.1 or 6.2? Jason