From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
gregkh@linuxfoundation.org, kvalo@kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] staging: rtl8192e: remove bogus ssid character sign test
Date: Tue, 25 Oct 2022 15:34:21 +0300 [thread overview]
Message-ID: <Y1fXzQIz7nta7aE8@kadam> (raw)
In-Reply-To: <20221025122150.583617-1-Jason@zx2c4.com>
On Tue, Oct 25, 2022 at 02:21:50PM +0200, Jason A. Donenfeld wrote:
> This error triggers on some architectures with unsigned `char` types:
>
> drivers/staging/rtl8192e/rtllib_softmac_wx.c:459 rtllib_wx_set_essid() warn: impossible condition '(extra[i] < 0) => (0-255 < 0)'
>
> But actually, the entire test is bogus, as ssids don't have any sign
> validity rules like that. So just remove this check look all together.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: linux-staging@lists.linux.dev
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
> Changes v1->v2:
> - Remove ssid sign test entirely rather than casting to `s8 *`.
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
next prev parent reply other threads:[~2022-10-25 12:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:30 [PATCH] staging: rtl8192e: use explicitly signed char Jason A. Donenfeld
2022-10-25 6:19 ` Dan Carpenter
2022-10-25 10:45 ` Greg Kroah-Hartman
2022-10-25 12:21 ` [PATCH v2] staging: rtl8192e: remove bogus ssid character sign test Jason A. Donenfeld
2022-10-25 12:34 ` Dan Carpenter [this message]
2022-10-25 17:35 ` Philipp Hortmann
2022-10-25 17:41 ` Greg KH
2022-10-25 17:43 ` Jason A. Donenfeld
2022-10-25 17:22 ` [PATCH] staging: rtl8192e: use explicitly signed char Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1fXzQIz7nta7aE8@kadam \
--to=dan.carpenter@oracle.com \
--cc=Jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.