From: Peter Xu <peterx@redhat.com>
To: Leonardo Bras <leobras@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [RFC PATCH 0/4] MultiFD zero-copy improvements
Date: Tue, 25 Oct 2022 12:36:03 -0400 [thread overview]
Message-ID: <Y1gQc5LkDptoq2cq@x1n> (raw)
In-Reply-To: <20221025044730.319941-1-leobras@redhat.com>
On Tue, Oct 25, 2022 at 01:47:27AM -0300, Leonardo Bras wrote:
> It all works fine in my tests, but maybe I missed some cornercase.
> Please provide any feedback you find fit.
Personally I very much like the whole series. :)
I just want to make sure it won't start to fail users when switching to
this new version of qemu due to vmlocked restrictions which I expect to
grow. But I see that there're discussions on patch 4 for further
optimizations of lockvm and let's keep the discussion there for this.
The other thing is since it's a patchset for performance optimization only,
it'll always be nice to attach performance numbers. If on slow networks it
won't show a difference worth mentioning that. And ultimately I believe
anyone would be interested to know in which case (e.g. 100g nic?) would
this start to benefit.
Thanks!
--
Peter Xu
prev parent reply other threads:[~2022-10-25 16:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 4:47 [RFC PATCH 0/4] MultiFD zero-copy improvements Leonardo Bras
2022-10-25 4:47 ` [RFC PATCH 1/4] migration/multifd/zero-copy: Create helper function for flushing Leonardo Bras
2022-10-25 9:44 ` Juan Quintela
2022-10-25 4:47 ` [RFC PATCH 2/4] migration/multifd/zero-copy: Merge header & pages send in a single write Leonardo Bras
2022-10-25 9:51 ` Juan Quintela
2022-10-25 13:28 ` Leonardo Brás
2022-10-25 4:47 ` [RFC PATCH 3/4] QIOChannel: Add max_pending parameter to qio_channel_flush() Leonardo Bras
2022-10-25 4:47 ` [RFC PATCH 4/4] migration/multifd/zero-copy: Flush only the LRU half of the header array Leonardo Bras
2022-10-25 8:35 ` Daniel P. Berrangé
2022-10-25 10:07 ` Juan Quintela
2022-10-25 13:47 ` Leonardo Brás
2022-10-25 16:36 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1gQc5LkDptoq2cq@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.