From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B20B4C38A2D for ; Tue, 25 Oct 2022 21:33:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbiJYVd5 (ORCPT ); Tue, 25 Oct 2022 17:33:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232447AbiJYVd4 (ORCPT ); Tue, 25 Oct 2022 17:33:56 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56250106A5D for ; Tue, 25 Oct 2022 14:33:55 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id o65so11694715iof.4 for ; Tue, 25 Oct 2022 14:33:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=aqCyDzBlgI0lxrRS0dVDOBPWnZoyypnDJaDYBUnhBSA=; b=ZbCWAHeaKy2n264Ub+ghiRtRmway0DRQ071l6WoJpSS1lHbUdOyzGEWfAkv7NZ3/Bp lfMxjFqVrLNEI+69N5m/udrQUiRi6+nWfEelZXmTmYKjEXJDakIn6pCkOxktYlUE0UHW NGy62ZV/grMkxizRvH/hcWpI+4d2bBPCfKpSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aqCyDzBlgI0lxrRS0dVDOBPWnZoyypnDJaDYBUnhBSA=; b=Ju2DuGgMbLFUBkyiLYTwQ2HDwh0OqmR1s0Q/AoQtlo5sTl+wJdaXxxilqWJn4FXH7h L0rvTliKwwGXcWUfAbPluFa/l+FSe0IK2wX0RQKh/9uSmLlalk/Wqk3VpleXlyVLZkdU totqxQBOWEEzYm/pG6iaki4YReeJcCdMFua+ozuNDEQI4TWevdnkb4T7TwgfFyOeCUCl Ys74JxZzVrUBsB8l24Blb0E1PZnwsROZ5Kr6fcL9JlEqie7d0Bc1h+ZkmuILXKVeK5Ow SYP2HM/TqjHbaZORGLkNNM2QvpJ0p6FehICnjOcgHMhidQcVApmzRhia2gRFWA20CnZl Us1w== X-Gm-Message-State: ACrzQf2GyS5D6ACzXk6VVB8SXtYsqqqKGzTr/TLkF4XmphKal7J0Kwz2 0nZ0g6D5m7wrTtIOoupMgxCoQg== X-Google-Smtp-Source: AMsMyM697VIOL/dbE1vPoZgpCLB2Ws+ra6abn/XsvHDNZhHcaNpAUdaRm0Fv/A2x82DlF7T0Pz/cAw== X-Received: by 2002:a05:6602:2ac9:b0:6bc:17dd:3800 with SMTP id m9-20020a0566022ac900b006bc17dd3800mr22880722iov.72.1666733634729; Tue, 25 Oct 2022 14:33:54 -0700 (PDT) Received: from localhost (30.23.70.34.bc.googleusercontent.com. [34.70.23.30]) by smtp.gmail.com with UTF8SMTPSA id h12-20020a92c08c000000b003001f822301sm1356232ile.81.2022.10.25.14.33.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Oct 2022 14:33:54 -0700 (PDT) Date: Tue, 25 Oct 2022 21:33:53 +0000 From: Matthias Kaehlcke To: Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , Konrad Dybcio , "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Luca Weiss Subject: Re: [PATCH] thermal: qcom-spmi-temp-alarm: Log the actual max stage 2 threshold Message-ID: References: <20221025171453.1.I13c2a23f276fb63bfc225aeab0bf0db9560a90e0@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221025171453.1.I13c2a23f276fb63bfc225aeab0bf0db9560a90e0@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org I just saw that Luca already posted a similar patch: https://lore.kernel.org/lkml/CAHLCerN+-5qKsRmpuF55RdeUMZJZuiZJ-7O4LnM8+QuHJfs0mQ@mail.gmail.com/T/ Please disregard this one. On Tue, Oct 25, 2022 at 05:15:08PM +0000, Matthias Kaehlcke wrote: > If the critical trip point of the thermal zone is higher than > the max threshold of the PMIC log the actual max threshold of the > chip, not the gen1 max threshold of 140°C. > > Reported-by: Luca Weiss > Signed-off-by: Matthias Kaehlcke > --- > > drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > index be785ab37e53..bdfe2129c357 100644 > --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c > @@ -252,7 +252,8 @@ static int qpnp_tm_update_critical_trip_temp(struct qpnp_tm_chip *chip, > disable_s2_shutdown = true; > else > dev_warn(chip->dev, > - "No ADC is configured and critical temperature is above the maximum stage 2 threshold of 140 C! Configuring stage 2 shutdown at 140 C.\n"); > + "No ADC is configured and critical temperature is above the maximum stage 2 threshold of %d C! Configuring stage 2 shutdown at %d C.\n", > + stage2_threshold_max / 1000, stage2_threshold_max / 1000); > } > > skip: > -- > 2.38.0.135.g90850a2211-goog >