From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22CE4C433FE for ; Wed, 26 Oct 2022 08:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233368AbiJZIdU (ORCPT ); Wed, 26 Oct 2022 04:33:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232865AbiJZIdR (ORCPT ); Wed, 26 Oct 2022 04:33:17 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C7295FDE2 for ; Wed, 26 Oct 2022 01:33:16 -0700 (PDT) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 24A7022061; Wed, 26 Oct 2022 08:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1666773195; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zVU2aHnaAH7d6c5G2vGY5kQYIwa1i3dY4wuvkxw6czE=; b=mase5czrxqPAgDCctSqhxEbUugxDoJdBH6V2rAd4XUJwE3L9xkKEQERBABORfOB2A7epqL 8G/ZmhiVwTVSOIfvkVYsxvU48e01mE7vfDJRJAK6dN+ZsI3NnI78fIuW5c+Te6QnL0rtQl XxQ7h/aMu5SM5EG8hMBmihazaYuOLKs= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id EF9442C141; Wed, 26 Oct 2022 08:33:14 +0000 (UTC) Date: Wed, 26 Oct 2022 10:33:14 +0200 From: Petr Mladek To: John Ogness Cc: Sergey Senozhatsky , Steven Rostedt , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH printk v2 32/38] printk: __pr_flush: use srcu console list iterator Message-ID: References: <20221019145600.1282823-1-john.ogness@linutronix.de> <20221019145600.1282823-33-john.ogness@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221019145600.1282823-33-john.ogness@linutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2022-10-19 17:01:54, John Ogness wrote: > Use srcu console list iteration for console list traversal. > > Document why the console_lock is still necessary. When thinking about it. It might be worth explaining why the srcu traversal is added even when console_lock is still needed. It would make the life of code archaeologists easier. I mean to add a note that it will keep the traversal safe even after console_drivers list manipulation will not longer be serialized using console_lock(). Or something like this. It would be nice to add this to all other patches the introduced srcu and kept console_lock. > Signed-off-by: John Ogness Anyway, the change looks good. Feel free to use: Reviewed-by: Petr Mladek Best Regards, Petr