From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 247ACC38A2D for ; Wed, 26 Oct 2022 12:56:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231597AbiJZM4P (ORCPT ); Wed, 26 Oct 2022 08:56:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233367AbiJZM4O (ORCPT ); Wed, 26 Oct 2022 08:56:14 -0400 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3DEFDAC6B for ; Wed, 26 Oct 2022 05:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666788973; x=1698324973; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=kyhpUikuGFLHKo2ioFMlMZ//ZaX8FD0v5Vs7erLnsms=; b=NhWOjYjSk7omqp+jErxRS4r0iTFUx5im7M5FvZPmotJqVp1Rapnl5EIf 5QLgrpqwq5GnuNw46e+DARuhEl8i7fw7Gs2BYzEmEGrG7wdl57uP+Z2hK M+FPA0xZkxYo2STu4SB6TliX+R5RnE3VOH38Qr6nKTpxt085zVg4KIjvt 7suksGBp531oMGYk349VYl4R/xovB+dwLBbvPE/YVEhW6RCKOdhjvD864 Apsq2GQZsIQOlHu8yp+UkkQK5KexWZ+i5t3v9uA8ycPQSJ5ZNzOTJk3nH cc8X1Esn1RqB5WBxQcyp5sjE6Me0XdYLVF5EbUt/2SRGEmouDXNxgpZuN g==; X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="288332731" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="288332731" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2022 05:56:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10512"; a="631995118" X-IronPort-AV: E=Sophos;i="5.95,214,1661842800"; d="scan'208";a="631995118" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 26 Oct 2022 05:56:11 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1onfx3-002eUo-04; Wed, 26 Oct 2022 15:56:09 +0300 Date: Wed, 26 Oct 2022 15:56:08 +0300 From: Andy Shevchenko To: Jarkko Nikula Cc: linux-i2c@vger.kernel.org, Wolfram Sang , Mika Westerberg , Jan Dabros , Michael Wu , Tian Ye , Luis Oliveira Subject: Re: [PATCH 00/11] i2c: designware: Slave fixes and generic cleanups Message-ID: References: <20221026123912.2833271-1-jarkko.nikula@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221026123912.2833271-1-jarkko.nikula@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Oct 26, 2022 at 03:39:01PM +0300, Jarkko Nikula wrote: > Hi > > I discovered recently while doing other cleanups.that reads and writes > from I2C bus to i2c-designware-slave.c don't work correctly. > > First two patches are fixes to slave code and meant for normal development > cycle since it looks these issues have been always here. > > I Cc'ed Michael Wu who has fixed > i2c-designware-slave.c before and Tian Ye who recently > reported a write issue. > > Could you test first two patches (or the whole set) that my patches won't > cause regressions to your existing test cases or does the 2nd patch fix > the write issue? > > Rest of patches are minor changes and cleanups to both master and slave > parts. > Patchset is done on top of commit fd142e074e89 ("Merge branch > 'i2c/for-current-fixed' into i2c/for-next") but may apply on top of > v6.1-rc1 too. Side note, using --base in `git-format-patch --cover-letter` will help a lot (esp. CIs that take it into consideration). -- With Best Regards, Andy Shevchenko