From: Leon Romanovsky <leon@kernel.org>
To: Saeed Mahameed <saeed@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: Re: [PATCH net-next v1 0/6] Various cleanups for mlx5
Date: Thu, 27 Oct 2022 09:07:52 +0300 [thread overview]
Message-ID: <Y1ogOKDAXRdys2nr@unreal> (raw)
In-Reply-To: <20221026142731.nrmhssgn5dhi7jot@sx1>
On Wed, Oct 26, 2022 at 03:27:31PM +0100, Saeed Mahameed wrote:
> On 25 Oct 14:25, Leon Romanovsky wrote:
> > On Tue, Oct 25, 2022 at 12:00:11PM +0100, Saeed Mahameed wrote:
> > > On 24 Oct 19:59, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@nvidia.com>
> > > >
> > > > Changelog:
> > > > v1:
> > > > Patch #1:
> > > > * Removed extra blank line
> > > > * Removed ipsec initialization for uplink
> > >
> > > This will break functionality, ipsec should only be enabled on nic and
> > > uplink but not on other vport representors.
> >
> > I didn't hear any complain from verification. The devlink patch is in
> > my tree for months already.
> >
>
> the regression is clear in the code. Ask Raed he added the functionality
> for uplink.
Just to wrap this discussion. Last half a year or so, all IPsec bugs found internally
are assigned on me.
Thanks
prev parent reply other threads:[~2022-10-27 6:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 16:59 [PATCH net-next v1 0/6] Various cleanups for mlx5 Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 1/6] net/mlx5e: Support devlink reload of IPsec core Leon Romanovsky
2022-10-25 10:58 ` Saeed Mahameed
2022-10-24 16:59 ` [PATCH net-next v1 2/6] net/mlx5: Return ready to use ASO WQE Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 3/6] net/mlx5e: Don't access directly DMA device pointer Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 4/6] net/mlx5e: Delete always true DMA check Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 5/6] net/mlx5: Remove redundant check Leon Romanovsky
2022-10-24 16:59 ` [PATCH net-next v1 6/6] net/mlx5e: Use read lock for eswitch get callbacks Leon Romanovsky
2022-10-25 11:00 ` [PATCH net-next v1 0/6] Various cleanups for mlx5 Saeed Mahameed
2022-10-25 11:25 ` Leon Romanovsky
2022-10-26 14:27 ` Saeed Mahameed
2022-10-27 6:07 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1ogOKDAXRdys2nr@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.