From: Greg KH <gregkh@linuxfoundation.org>
To: Seth Jenkins <sethjenkins@google.com>
Cc: willy@infradead.org, Liam.Howlett@oracle.com,
stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH stable 4.19-5.19] mm: /proc/pid/smaps_rollup: fix no vma's null-deref
Date: Thu, 27 Oct 2022 08:16:33 +0200 [thread overview]
Message-ID: <Y1oiQbA2cbr3VGNG@kroah.com> (raw)
In-Reply-To: <CALxfFW6a_Fe1rwbXf6LnG-1PvjtwLwGLHYYPr8c-Wda3NNJD8g@mail.gmail.com>
A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Wed, Oct 26, 2022 at 02:32:00PM -0400, Seth Jenkins wrote:
> Hi Greg,
>
> The upstream commit that fixed the issue was not an intentional fix
> AFAIK, but a refactor to switch to maple tree VMA lookups. I was under
> the impression that there were no plans to backport maple trees back
> to stable trees but do let me know if that presumption is incorrect.
> Assuming they're not getting backported, what do you think of this
> instead:
Yes, as Matthew said, backporting maple trees is not a good idea, we
don't want that.
> c4c84f06285e on upstream resolves this issue as part of the switch to
> using maple trees for VMA lookups, but a fix must still be applied to
> stable trees 4.19-5.19.
That's better, yes. Please add that and resend a new version.
thanks,
greg k-h
next prev parent reply other threads:[~2022-10-27 6:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 16:24 [PATCH stable 4.19-5.19] mm: /proc/pid/smaps_rollup: fix no vma's null-deref Seth Jenkins
2022-10-26 16:41 ` Greg KH
2022-10-26 18:32 ` Seth Jenkins
2022-10-26 19:13 ` Matthew Wilcox
2022-10-27 6:16 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-10-27 15:36 Seth Jenkins
2022-10-27 16:44 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1oiQbA2cbr3VGNG@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Liam.Howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=sethjenkins@google.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.