All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Marc Zyngier <maz@kernel.org>,
	Vincent Donnefort <vdonnefort@google.com>,
	kvmarm@lists.linux.dev, catalin.marinas@arm.com, will@kernel.org,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: Hang with nVHE mode and SME
Date: Thu, 27 Oct 2022 13:01:03 +0100	[thread overview]
Message-ID: <Y1py/6L+UtLL0QJy@sirena.org.uk> (raw)
In-Reply-To: <CAFEAcA-mo_ywRnC53aFfkYP=q3zDBD7U4sBSrzg7ZfRQA7QYXA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]

On Thu, Oct 27, 2022 at 10:44:39AM +0100, Peter Maydell wrote:
> On Wed, 26 Oct 2022 at 17:34, Mark Brown <broonie@kernel.org> wrote:
> > On Wed, Oct 26, 2022 at 05:13:46PM +0100, Marc Zyngier wrote:

> > > So the question is whether we work around this in the kernel (not
> > > enabling either KVM or SME if FEAT_FGT is not present), or leave it as
> > > is with the hope that QEMU gets updated.

> > > I'm inclined to do the latter. Thoughts anyone?

> Is the "kernel needs FEAT_FGT here" requirement a strong "the design
> just means it's kind of expected" one, or a weak "the features
> aren't really strongly tied together, it would be easy to do without"
> one?

We need it for nVHE mode since we need nTPIDR2_EL0 to trap access to
TPIDR2_EL0, in VHE mode this is controlled by SCTLR_EL2.EnTP2.  Looking
again I need to double check but I think I missed control of nSMPRI_EL1
which will be needed in both VHE and nVHE cases to trap access to
SMPRI_EL1, that's not controlled by the overall SME enable.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-10-27 12:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 14:29 Hang with nVHE mode and SME Vincent Donnefort
2022-10-26 15:07 ` Mark Brown
2022-10-26 16:13   ` Marc Zyngier
2022-10-26 16:34     ` Mark Brown
2022-10-27  9:44       ` Peter Maydell
2022-10-27 12:01         ` Mark Brown [this message]
2022-10-27 21:16         ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y1py/6L+UtLL0QJy@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=maz@kernel.org \
    --cc=peter.maydell@linaro.org \
    --cc=richard.henderson@linaro.org \
    --cc=vdonnefort@google.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.