Re: [PATCH v2] seccomp: Get actual errno value from failed seccomp functions

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Oct 27, 2022 at 02:55:02PM +0200, Michal Prívozník wrote:
> On 10/26/22 14:33, Daniel P. Berrangé wrote:
> > On Wed, Oct 26, 2022 at 09:30:24AM +0200, Michal Privoznik wrote:
> >> Upon failure, a libseccomp API returns actual errno value very
> >> rarely. Fortunately, after its commit 34bf78ab (contained in
> >> 2.5.0 release), the SCMP_FLTATR_API_SYSRAWRC attribute can be set
> >> which makes subsequent APIs return true errno on failure.
> >>
> >> This is especially critical when seccomp_load() fails, because
> >> generic -ECANCELED says nothing.
> >>
> >> Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
> >> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> >> ---
> >>
> >> v2 of:
> >>
> >> https://lists.gnu.org/archive/html/qemu-devel/2022-10/msg04509.html
> >>
> >> diff to v1:
> >> - added comment when setting SYSRAWRC attribute per Philippe's
> >>   suggestion
> >>
> >>  meson.build            |  9 +++++++++
> >>  softmmu/qemu-seccomp.c | 13 +++++++++++++
> >>  2 files changed, 22 insertions(+)
> > 
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> Thank you. Can somebody merge this please? I don't have commit access.

I'm seccomp subsystem maintainer and have it queued.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|