From: Bagas Sanjaya <bagasdotme@gmail.com>
To: UMWARI JOVIAL <umwarijovial@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy@lists.linux.dev
Subject: Re: [PATCH] Possible repeated word: 'very'
Date: Fri, 28 Oct 2022 14:41:11 +0700 [thread overview]
Message-ID: <Y1uHl4di6R0pFA/i@debian.me> (raw)
In-Reply-To: <20221028070439.GA36889@rdm>
[-- Attachment #1: Type: text/plain, Size: 1449 bytes --]
On Fri, Oct 28, 2022 at 10:04:39AM +0300, UMWARI JOVIAL wrote:
> Reported By checkpatch.pl script
>
> WARNING: Possible repeated word: 'very'
>
> Repetition of the same word in one sentence same line
>
> Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c
> index 090345bad223..30a0276b8b58 100644
> --- a/drivers/staging/rtl8712/rtl871x_xmit.c
> +++ b/drivers/staging/rtl8712/rtl871x_xmit.c
> @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf)
> * If we turn on USE_RXTHREAD, then, no need for critical section.
> * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue...
> *
> - * Must be very very cautious...
> + * Must be very cautious...
> *
> */
> struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)
NAK!
You send patch with the same content as [1], for which Greg already replied
as [2].
The code and its comments imply that calling r8712_alloc_xmitframe() must be
done with extreme caution, isn't it?
Thanks.
[1]: https://lore.kernel.org/lkml/20221028051420.GA30073@rdm/
[2]: https://lore.kernel.org/lkml/Y1tx8XjmR5QKV9lQ@kroah.com/
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2022-10-28 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 7:04 [PATCH] Possible repeated word: 'very' UMWARI JOVIAL
2022-10-28 7:35 ` Nam Cao
2022-10-28 7:41 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1uHl4di6R0pFA/i@debian.me \
--to=bagasdotme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=umwarijovial@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.