From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BA7F1FAE for ; Fri, 28 Oct 2022 09:29:42 +0000 (UTC) Received: by mail-ej1-f43.google.com with SMTP id q9so11702108ejd.0 for ; Fri, 28 Oct 2022 02:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bKzHROW3HlqVHFCQVYEIAGQO/GEF/7B37Q2yOLqpTPE=; b=acC1NH65fUHn+22X/MVKkVYc6pCCpJTS8anQGCsKRR7fejXeE/X/BY4MQTQbrUdYrO /zUDL5rfOXVPoIOi8aQmru/rBDm35rwQwnz/LEPthxbjGv12PZRu6dTLUQWjHCKAKKWj xlHubTSrs2IyVpI4UAFd2z726R+FG7O9NVFYXgEOqGvPgy9i+TU18+pgkEviSlWRiRUU IaUWJ+wIL0pcMH0UvivkifftNqQ/+DwbVtbi71Sb28s8K08Tn0hb9w8hXyUDRZWWt/Ez /icWm4QkaL/d2N01KarCI6JZZvh0yQ/vg3bPraCUQl6fx3wropNkioqoRMYbFm0eKMGJ v0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bKzHROW3HlqVHFCQVYEIAGQO/GEF/7B37Q2yOLqpTPE=; b=ZiV4qIu6rKFoHg5yxvqtB82qrq7SWJ4dOn5pfI8BIehJssp0sTdhmT9b4+Q8KoUww9 Oo+sMfDB4jIQecz4UVVxqfDQNrUzR6lwftuC45jqTlGi71LDjoMPNAvqeOIV0egaUotA meLVppioESw/i7/XSAA0ohijF0ZOl8245AOldQblGMciQNNJzyphoPV4eSPIgsaXRKhA R0R3hoGUld5bs+yjlmgoGRAitD0OITBA8AsDX3ZKLQaYinWq3BpOXz5AKNBQMxDqT40v 9ta9Xxk1HJ2xrsN5/CLhYg/TXDTDuzLww0SRASNp/3l0QjY6+5UjiUnbMQqc/15q9kYo HG6w== X-Gm-Message-State: ACrzQf1C8VBoV1B/5NLJ4UV2GDfxNvoc+nb2iLpY3zF6Xpeir0EG+RPZ V1TDBlDmhqDSYptWpE/6amDa4A== X-Google-Smtp-Source: AMsMyM4PKCzkFjNUPVQTRmDdJVp41feWg/IGBeQ3XOnOrubUEl8MuW8Vq2rx6HtRpjEyThZ6kj50Ng== X-Received: by 2002:a17:907:2c75:b0:78d:c201:e9aa with SMTP id ib21-20020a1709072c7500b0078dc201e9aamr46266130ejc.235.1666949380721; Fri, 28 Oct 2022 02:29:40 -0700 (PDT) Received: from google.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id r18-20020a17090609d200b0078d38cda2b1sm1819419eje.202.2022.10.28.02.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 02:29:40 -0700 (PDT) Date: Fri, 28 Oct 2022 09:29:37 +0000 From: Quentin Perret To: Oliver Upton Cc: Will Deacon , kvmarm@lists.linux.dev, Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , James Morse , Chao Peng , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 02/25] KVM: arm64: Allow attaching of non-coalescable pages to a hyp pool Message-ID: References: <20221020133827.5541-1-will@kernel.org> <20221020133827.5541-3-will@kernel.org> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Friday 28 Oct 2022 at 08:09:28 (+0000), Oliver Upton wrote: > On Fri, Oct 28, 2022 at 12:17:40AM +0000, Oliver Upton wrote: > > Assuming this is kept as-is... > > > > This check reads really odd to me, but I understand how it applies to > > the use case here. Perhaps create a helper (to be shared with > > __find_buddy_nocheck()) and add a nice comment atop it describing the > > significance of pages that exist outside the boundaries of the buddy > > allocator. > > Sorry, I'm a moron. The check in __find_buddy_nocheck() is of course > necessary and irrelevant to the comment I've made above. But maybe I've > proved my point by tripping over it? :-) A comment won't hurt for sure, I'll add that for the next version. Cheers! Quentin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D7B7ECAAA1 for ; Fri, 28 Oct 2022 09:31:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Y+cB3lUBUhiLS1eVLroUxTdXx4S3JQxDWb15TX/NJiI=; b=NZENUChT5aC03l ULqvBEll2NWZ45j7iCPM1L5o2YYIYqt2+JMsx6m3+dJEvHRviAYLKyfKUeXY4O1Bs30Nzwjo1uNqn 9t43XNThs0O3CcksJfZbiHk14qT4eBesWq8PIYY2zoJdI/+JzbHmz+B7oMGJghIjjE5mHxRRVvOcV fgscdF6l1TQgXBZ7yqufSunr9v+RIifNqXF9gNApgLqtfPrYQVj0ZGhjBrsx3/ETvfDdBlOpn9GyK jyLw9XJCy92g6SdsvgxS57ARwZZ7uz2io6/M9XWtjnkruIR9w2js7s+/I5HQGSUI9vZCTUOnZ3W/J 4aJw2+aZFcU6y6N6tuAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooLgS-00GKbK-5T; Fri, 28 Oct 2022 09:29:48 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ooLgM-00GKYa-6W for linux-arm-kernel@lists.infradead.org; Fri, 28 Oct 2022 09:29:43 +0000 Received: by mail-ej1-x62c.google.com with SMTP id f27so11626908eje.1 for ; Fri, 28 Oct 2022 02:29:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bKzHROW3HlqVHFCQVYEIAGQO/GEF/7B37Q2yOLqpTPE=; b=acC1NH65fUHn+22X/MVKkVYc6pCCpJTS8anQGCsKRR7fejXeE/X/BY4MQTQbrUdYrO /zUDL5rfOXVPoIOi8aQmru/rBDm35rwQwnz/LEPthxbjGv12PZRu6dTLUQWjHCKAKKWj xlHubTSrs2IyVpI4UAFd2z726R+FG7O9NVFYXgEOqGvPgy9i+TU18+pgkEviSlWRiRUU IaUWJ+wIL0pcMH0UvivkifftNqQ/+DwbVtbi71Sb28s8K08Tn0hb9w8hXyUDRZWWt/Ez /icWm4QkaL/d2N01KarCI6JZZvh0yQ/vg3bPraCUQl6fx3wropNkioqoRMYbFm0eKMGJ v0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bKzHROW3HlqVHFCQVYEIAGQO/GEF/7B37Q2yOLqpTPE=; b=7hl/Jb8AwmQwdZkfMKNpPpMqTG3EbXxHctVqmSqkyUO3++sLM05Lg6RnBou3g+AmiY i6BXEud9bxgVrjW8uoNbxzAjYvWy9kMWHkECXFTyUCelpSIp9kDtXzQL4OPShGvZxO0L t+p0+cTK4l303t2gl7sHSs4AiaytsYtNT5yEiHd52Vxf1BAxfIjHESiF/tznc2XtKxnb MFSHMtFQuJLyrJAc6i9MhqDH2lJjPhsVBFnT+xSwoxbn9agmVuTZaa0FNc1B2Ylq6eFv hdEkpfIvs4Bl4Ijt8VOAZ7giE2O3OiVf8bkrqtmP/eu/DqRplC9UQydS42R8pZsFloFf AEWQ== X-Gm-Message-State: ACrzQf3LpRKDiLWOzw7A//jvqa+zFvxNdK1wY6Ec5G2oKBSmO9Ly0ylf E7rnLbOwvCQ2Ka876+aNyWrM/A== X-Google-Smtp-Source: AMsMyM4PKCzkFjNUPVQTRmDdJVp41feWg/IGBeQ3XOnOrubUEl8MuW8Vq2rx6HtRpjEyThZ6kj50Ng== X-Received: by 2002:a17:907:2c75:b0:78d:c201:e9aa with SMTP id ib21-20020a1709072c7500b0078dc201e9aamr46266130ejc.235.1666949380721; Fri, 28 Oct 2022 02:29:40 -0700 (PDT) Received: from google.com (64.227.90.34.bc.googleusercontent.com. [34.90.227.64]) by smtp.gmail.com with ESMTPSA id r18-20020a17090609d200b0078d38cda2b1sm1819419eje.202.2022.10.28.02.29.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 02:29:40 -0700 (PDT) Date: Fri, 28 Oct 2022 09:29:37 +0000 From: Quentin Perret To: Oliver Upton Cc: Will Deacon , kvmarm@lists.linux.dev, Sean Christopherson , Vincent Donnefort , Alexandru Elisei , Catalin Marinas , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , James Morse , Chao Peng , Suzuki K Poulose , Mark Rutland , Fuad Tabba , Marc Zyngier , kernel-team@android.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 02/25] KVM: arm64: Allow attaching of non-coalescable pages to a hyp pool Message-ID: References: <20221020133827.5541-1-will@kernel.org> <20221020133827.5541-3-will@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221028_022942_284309_DAC3D611 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Friday 28 Oct 2022 at 08:09:28 (+0000), Oliver Upton wrote: > On Fri, Oct 28, 2022 at 12:17:40AM +0000, Oliver Upton wrote: > > Assuming this is kept as-is... > > > > This check reads really odd to me, but I understand how it applies to > > the use case here. Perhaps create a helper (to be shared with > > __find_buddy_nocheck()) and add a nice comment atop it describing the > > significance of pages that exist outside the boundaries of the buddy > > allocator. > > Sorry, I'm a moron. The check in __find_buddy_nocheck() is of course > necessary and irrelevant to the comment I've made above. But maybe I've > proved my point by tripping over it? :-) A comment won't hurt for sure, I'll add that for the next version. Cheers! Quentin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel