From: Dan Robertson <dan@dlrobertson.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] iio: accel: bma400: Ensure VDDIO is enable defore reading the chip ID.
Date: Fri, 28 Oct 2022 13:07:47 +0000 [thread overview]
Message-ID: <Y1vUI9ppqVkoEuuv@dlrobertson.com> (raw)
In-Reply-To: <20221002144133.3771029-1-jic23@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 709 bytes --]
On Sun, Oct 02, 2022 at 03:41:33PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
>
> The regulator enables were after the check on the chip variant, which was
> very unlikely to return a correct value when not powered.
> Presumably all the device anyone is testing on have a regulator that
> is already powered up when this code runs for reasons beyond the scope
> of this driver. Move the read call down a few lines.
>
> Fixes: 3cf7ded15e40 ("iio: accel: bma400: basic regulator support")
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Dan Robertson <dan@dlrobertson.com>
Thanks for catching this!
Cheers,
- Dan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-10-28 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-02 14:41 [PATCH] iio: accel: bma400: Ensure VDDIO is enable defore reading the chip ID Jonathan Cameron
2022-10-28 13:07 ` Dan Robertson [this message]
2022-10-29 11:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vUI9ppqVkoEuuv@dlrobertson.com \
--to=dan@dlrobertson.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.