From: Peter Zijlstra <peterz@infradead.org>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Yujie Liu <yujie.liu@intel.com>,
oe-lkp@lists.linux.dev, lkp@intel.com,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org,
fengwei.yin@intel.com, ying.huang@intel.com,
fstests@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [tip:x86/core] [kallsyms] f138918162: WARNING:CPU:#PID:#at_fs/xfs/xfs_message.c:#xfs_buf_alert_ratelimited.cold-#[xfs]
Date: Fri, 28 Oct 2022 21:52:18 +0200 [thread overview]
Message-ID: <Y1wy8nvCWmXssMnY@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <Y1q2/fdvXI67MRch@hirez.programming.kicks-ass.net>
On Thu, Oct 27, 2022 at 06:51:09PM +0200, Peter Zijlstra wrote:
>
> > However, I noticed that the callsite in the WARNING: message has changed
> > from the usual 'asswarn' (which is the caller of WARN_ON) to
> > 'xfs_buf_alert_ratelimited', which seems totally wrong since XFS log
> > recovery doesn't touch xfs_buf objects at all.
>
> Yeah; and I've meanwhile found more cases where it goes sideways.
>
> I'll revert this patch and try an alternative approach. I'll post
> patches tomorrow or something.
Now posted:
https://lkml.kernel.org/r/20221028194022.388521751@infradead.org
next prev parent reply other threads:[~2022-10-28 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 9:10 [tip:x86/core] [kallsyms] f138918162: WARNING:CPU:#PID:#at_fs/xfs/xfs_message.c:#xfs_buf_alert_ratelimited.cold-#[xfs] kernel test robot
2022-10-26 9:51 ` Peter Zijlstra
2022-10-26 12:06 ` Peter Zijlstra
2022-10-27 2:09 ` Yujie Liu
2022-10-27 2:24 ` Yujie Liu
2022-10-27 16:20 ` Darrick J. Wong
2022-10-27 16:51 ` Peter Zijlstra
2022-10-28 19:52 ` Peter Zijlstra [this message]
2022-11-02 9:20 ` [tip: x86/core] kallsyms: Revert "Take callthunks into account" tip-bot2 for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1wy8nvCWmXssMnY@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=djwong@kernel.org \
--cc=fengwei.yin@intel.com \
--cc=fstests@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.